[dashboard/fullScreen] override z-index override#21704
Merged
spalger merged 1 commit intoelastic:masterfrom Aug 6, 2018
Merged
[dashboard/fullScreen] override z-index override#21704spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
cjcenizal
approved these changes
Aug 6, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally, looks good! We should run the CI a few times to check for flakiness.
Contributor
💚 Build Succeeded |
Contributor
Author
|
I think we'll test this for flakiness plenty in our two PRs, I'd rather get it in. |
Contributor
💔 Build Failed |
Contributor
Author
|
Failure is because I said the magic word in my previous comment, then aborted the build it triggered. |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Aug 6, 2018
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Aug 6, 2018
spalger
pushed a commit
that referenced
this pull request
Aug 7, 2018
spalger
pushed a commit
that referenced
this pull request
Aug 7, 2018
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing #21629 we ran into a situation where KUI was setting the z-index for elements that are focused, which causes the exit fullscreen button to get stuck behind panels, causing functional tests to break. This impacts #21302 as well, so I'm sending this as a separate PR so we can get unblocked.