Skip to content

[8.x] Retry release to fix flaky tests (#216781) #216798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Apr 2, 2025
Merged

[8.x] Retry release to fix flaky tests (#216781) #216798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions ...observability_ai_assistant/server/service/distributed_lock_manager/lock_manager_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,20 +285,26 @@ export async function withLock<T>(
`Lock "${lockId}" acquired. Extending TTL every ${prettyMilliseconds(extendInterval)}`
);

let extendTTlPromise = Promise.resolve(true);
const intervalId = setInterval(() => {
lockManager.extendTtl().catch((err) => {
logger.error(`Failed to extend lock "${lockId}":`, err);
});
// wait for the previous extendTtl request to finish before sending the next one. This is to avoid flooding ES with extendTtl requests in cases where ES is slow to respond.
extendTTlPromise = extendTTlPromise
.then(() => lockManager.extendTtl())
.catch((err) => {
logger.error(`Failed to extend lock "${lockId}":`, err);
return false;
});
}, extendInterval);

try {
return await callback();
} finally {
clearInterval(intervalId);
try {
clearInterval(intervalId);
await extendTTlPromise;
await lockManager.release();
} catch (error) {
logger.error(`Failed to release lock "${lockId}": ${error.message}`);
logger.error(`Failed to release lock "${lockId}" in withLock: ${error.message}`);
}
}
}
Expand Down