Retry "lock release" to fix flaky tests#216781
Merged
sorenlouv merged 2 commits intoelastic:mainfrom Apr 2, 2025
Merged
Conversation
sorenlouv
added
backport:version
dgieselaar
approved these changes
Apr 2, 2025
Contributor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14218371346 |
Contributor
💚 Build Succeeded
Metrics [docs]
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 2, 2025
Related to elastic#216397 Closes elastic#216763 This change ensures that we do not send the `release` request and `extendTtl` request simultaneously in `withLock`. This caused a conflict causing tests to fail: ``` └-> "before all" hook for "should return the result of the callback" │ERROR Failed to release lock "my_lock_with_ttl_extension": version_conflict_engine_exception │ Root causes: │ version_conflict_engine_exception: [my_lock_with_ttl_extension]: version conflict, required seqNo [43], primary term [1]. current document has seqNo [44] and primary term [1] ``` Flaky tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8142 (cherry picked from commit 7275d2e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 2, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [Retry release to fix flaky tests (#216781)](#216781) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-04-02T11:21:20Z","message":"Retry release to fix flaky tests (#216781)\n\nRelated to https://github.com/elastic/kibana/pull/216397\nCloses https://github.com/elastic/kibana/issues/216763\n\nThis change ensures that we do not send the `release` request and\n`extendTtl` request simultaneously in `withLock`. This caused a conflict\ncausing tests to fail:\n\n```\n └-> \"before all\" hook for \"should return the result of the callback\"\n │ERROR Failed to release lock \"my_lock_with_ttl_extension\": version_conflict_engine_exception\n │ \tRoot causes:\n │ \t\tversion_conflict_engine_exception: [my_lock_with_ttl_extension]: version conflict, required seqNo [43], primary term [1]. current document has seqNo [44] and primary term [1]\n```\n\nFlaky tests:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8142","sha":"7275d2e8bd834303898e3f95c5fd1ab734e92947","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Obs AI Assistant","backport:version","v9.1.0","v8.19.0"],"title":"Retry release to fix flaky tests","number":216781,"url":"https://github.com/elastic/kibana/pull/216781","mergeCommit":{"message":"Retry release to fix flaky tests (#216781)\n\nRelated to https://github.com/elastic/kibana/pull/216397\nCloses https://github.com/elastic/kibana/issues/216763\n\nThis change ensures that we do not send the `release` request and\n`extendTtl` request simultaneously in `withLock`. This caused a conflict\ncausing tests to fail:\n\n```\n └-> \"before all\" hook for \"should return the result of the callback\"\n │ERROR Failed to release lock \"my_lock_with_ttl_extension\": version_conflict_engine_exception\n │ \tRoot causes:\n │ \t\tversion_conflict_engine_exception: [my_lock_with_ttl_extension]: version conflict, required seqNo [43], primary term [1]. current document has seqNo [44] and primary term [1]\n```\n\nFlaky tests:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8142","sha":"7275d2e8bd834303898e3f95c5fd1ab734e92947"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216781","number":216781,"mergeCommit":{"message":"Retry release to fix flaky tests (#216781)\n\nRelated to https://github.com/elastic/kibana/pull/216397\nCloses https://github.com/elastic/kibana/issues/216763\n\nThis change ensures that we do not send the `release` request and\n`extendTtl` request simultaneously in `withLock`. This caused a conflict\ncausing tests to fail:\n\n```\n └-> \"before all\" hook for \"should return the result of the callback\"\n │ERROR Failed to release lock \"my_lock_with_ttl_extension\": version_conflict_engine_exception\n │ \tRoot causes:\n │ \t\tversion_conflict_engine_exception: [my_lock_with_ttl_extension]: version conflict, required seqNo [43], primary term [1]. current document has seqNo [44] and primary term [1]\n```\n\nFlaky tests:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8142","sha":"7275d2e8bd834303898e3f95c5fd1ab734e92947"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
sorenlouv
changed the title
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8142[❌] x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts: 175/200 tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #216397
Closes #216763
This change ensures that we do not send the
releaserequest andextendTtlrequest simultaneously inwithLock. This caused a conflict causing tests to fail:Flaky tests:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8142