Skip to content

[8.x] [Console] Fix parsing requests with errors (#215568)#216713

Merged
ElenaStoeva merged 6 commits intoelastic:8.xfrom
ElenaStoeva:backport/8.x/pr-215568
Apr 10, 2025
Merged

[8.x] [Console] Fix parsing requests with errors (#215568)#216713
ElenaStoeva merged 6 commits intoelastic:8.xfrom
ElenaStoeva:backport/8.x/pr-215568

Conversation

@ElenaStoeva
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Fixes elastic#211031

## Summary

This PR fixes the selection of requests in Console when a request
contains an error. It also adds an error toast when the user tries to
send a request containing an error, as the response from Elasticsearch
is usually too long and not very helpful.

https://github.com/user-attachments/assets/4de10953-9ee5-489b-94fb-fd8a772bd598
(cherry picked from commit 4557b73)

# Conflicts:
#	src/platform/packages/shared/kbn-monaco/src/console/console_parsed_requests_provider.ts
#	src/platform/packages/shared/kbn-monaco/src/console/parser.test.ts
@ElenaStoeva ElenaStoeva added the backport This PR is a backport of another PR label Apr 1, 2025
@ElenaStoeva ElenaStoeva enabled auto-merge (squash) April 1, 2025 19:00
@ElenaStoeva ElenaStoeva self-assigned this Apr 1, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 2, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / console parser case insensitive methods allows mixed case methods
  • [job] [logs] Jest Tests #18 / console parser case insensitive methods allows mixed case methods

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/monaco 125 126 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 185.2KB 185.9KB +737.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/monaco 3 4 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +177.0B
Unknown metric groups

API count

id before after diff
@kbn/monaco 125 126 +1

History

cc @ElenaStoeva

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/monaco 125 126 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 185.2KB 185.9KB +737.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/monaco 3 4 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +177.0B
Unknown metric groups

API count

id before after diff
@kbn/monaco 125 126 +1

History

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva requested a review from sabarasaba April 10, 2025 11:19
@ElenaStoeva ElenaStoeva merged commit 0b81bce into elastic:8.x Apr 10, 2025
8 checks passed
@ElenaStoeva ElenaStoeva deleted the backport/8.x/pr-215568 branch January 31, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants