[ML] Replace legacy SCSS overwrites#216698
Merged
Merged
Conversation
rbrtj
added
chore
:ml
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
71 tasks
ryankeairns
approved these changes
Apr 2, 2025
| '.brush .selection': { | ||
| stroke: 'none', | ||
| fill: euiTheme.colors.vis.euiColorVisGrey2, | ||
| opacity: '0.5 !important', |
Contributor
There was a problem hiding this comment.
@walterra did you look at removing this opacity setting when originally creating this component? In dark theme particularly, the contrast at 0.5 makes the brush quite hard to distinguish from the background of the chart if it weren't for the brush handles.
0.5 opacity:
Without opacity setting:
Contributor
There was a problem hiding this comment.
I did not originally. We could just remove the opacity setting now (I think with borealis there's an effort to get rid of transparencies anyway).
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Overall looks good. Just left a comment on the brush styling.
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @rbrtj |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14311745739 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 7, 2025
Part of elastic#140695 This PR replaces all remaining SCSS overrides in ML. > ml/public/application/_index.scss > ./job_selector/_index.scss > ./job_selector/_job_selector.scss > ./rule_editor/_index.scss > ./rule_editor/_rule_editor.scss > ./anomalies_table/_index.scss > ./anomalies_table/_anomalies_table.scss > data_visualizer/public/application/common/components/stats_table/components/field_data_row/column_chart.scss > data_visualizer/public/application/common/components/field_type_icon/_index.scss > data_visualizer/public/application/common/components/field_type_icon/_field_type_icon.scss > x-pack/platform/packages/private/ml/aiops_components/src/dual_brush/dual_brush.scss There are minor color changes in the `dual brush` and `GanttBar` in the Job Selector. | Before | After | | ------------- | ------------- | | <img width="1217" alt="dual-brush-before-light" src="https://github.com/user-attachments/assets/e87f1600-c1f1-42ef-a4f8-a8d5b21e2ca7" /> | <img width="881" alt="dual-brush-after-light" src="https://github.com/user-attachments/assets/17996e65-50dc-42e8-9b9a-4757f2b30309" /> | | <img width="863" alt="dual-brush-before-dark" src="https://github.com/user-attachments/assets/685fe511-b715-457b-8173-ece0d41f7bef" /> | <img width="865" alt="dual-brush-after-dark" src="https://github.com/user-attachments/assets/593b6085-281b-49b2-b0fd-9ae6f44b6684" /> | | <img width="576" alt="job_selector_before_light" src="https://github.com/user-attachments/assets/ce2438c1-a54f-4066-bb4d-b86412d55e1e" /> | <img width="564" alt="job_selector_after_light" src="https://github.com/user-attachments/assets/74cb28d3-73c3-4836-ae53-f64f7730cf09" /> | | <img width="581" alt="job_selector_before_dark" src="https://github.com/user-attachments/assets/7be93e06-12a0-4715-ac35-74711e08c761" /> | <img width="567" alt="job_selector_after_dark" src="https://github.com/user-attachments/assets/c3af92ee-f510-4f40-a99a-04f446652d91" /> | | <img width="574" alt="role_editor_before_light" src="https://github.com/user-attachments/assets/8e8e33b8-2688-4526-9062-20dab205dcbf" /> | <img width="564" alt="rule_editor_after_light" src="https://github.com/user-attachments/assets/98142dfc-b74a-4bbd-af8c-c6c041805826" /> | | <img width="576" alt="role_editor_before_dark" src="https://github.com/user-attachments/assets/e534c5f1-f75a-433d-91d8-dc57e059e407" /> | <img width="572" alt="rule_editor_after_dark" src="https://github.com/user-attachments/assets/2f56394f-4585-4176-a178-ef85394ab46d" /> | | <img width="572" alt="quick_role_editor_before_light" src="https://github.com/user-attachments/assets/7f414295-e799-4073-84b8-d2bd94eb293f" /> | <img width="567" alt="quick_role_editor_after_light" src="https://github.com/user-attachments/assets/1d7bbc7b-bc44-4753-b9b6-6cac8cfb8953" /> | | <img width="578" alt="quick_role_editor_before_dark" src="https://github.com/user-attachments/assets/f1d5291e-ef72-4e40-a614-b909193ec060" /> | <img width="562" alt="quick_role_editor_after_dark" src="https://github.com/user-attachments/assets/90c2927a-0bf2-4f70-a13c-7937ae2bf476" /> | | <img width="1205" alt="discover_vis_before_light" src="https://github.com/user-attachments/assets/899311e7-d10b-48fe-91e1-95c3af7f5608" /> | <img width="1201" alt="discover-vis-after-light" src="https://github.com/user-attachments/assets/05f0dcde-6a1b-4139-95ba-19a24ad4fdcf" /> | | <img width="1207" alt="discover-vis-before-dark" src="https://github.com/user-attachments/assets/cde9e49e-b9c3-4bd5-9bd5-32b4f09ce834" /> | <img width="1207" alt="discover-viz-after-dark" src="https://github.com/user-attachments/assets/544e44a9-3676-448d-9348-d88a67284a59" /> | | <img width="1160" alt="anomalies_table_before_light" src="https://github.com/user-attachments/assets/9be79294-9808-4509-a1cb-02e342d9abe2" /> | <img width="1136" alt="anomalies_table_after_light" src="https://github.com/user-attachments/assets/3b3ce7ad-6f67-4caf-b12d-1839bb2c08ab" /> | | <img width="1152" alt="anomalies_table_before_dark" src="https://github.com/user-attachments/assets/8e5af9fd-90f5-4f85-bd5b-40dc0ab74d0a" /> | <img width="1144" alt="anomalies_table_after_dark" src="https://github.com/user-attachments/assets/c6ca08b6-e816-49d2-8c15-9ec9bb1dd983" /> | | <img width="668" alt="category_examples_before" src="https://github.com/user-attachments/assets/9bfd1978-27fe-41bc-9828-f94314e420a6" /> | <img width="1101" alt="category_examples_after" src="https://github.com/user-attachments/assets/72c58a22-6d1e-4901-898c-9c54c46eb3a9" /> | (cherry picked from commit 9f932a0)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] Replace legacy SCSS overwrites (#216698)](#216698) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-07T14:23:17Z","message":"[ML] Replace legacy SCSS overwrites (#216698)\n\nPart of https://github.com/elastic/kibana/issues/140695\n\nThis PR replaces all remaining SCSS overrides in ML.\n\n> ml/public/application/_index.scss\n> ./job_selector/_index.scss\n> ./job_selector/_job_selector.scss\n> ./rule_editor/_index.scss\n> ./rule_editor/_rule_editor.scss\n> ./anomalies_table/_index.scss \n> ./anomalies_table/_anomalies_table.scss\n>\ndata_visualizer/public/application/common/components/stats_table/components/field_data_row/column_chart.scss\n>\ndata_visualizer/public/application/common/components/field_type_icon/_index.scss\n>\ndata_visualizer/public/application/common/components/field_type_icon/_field_type_icon.scss\n>\nx-pack/platform/packages/private/ml/aiops_components/src/dual_brush/dual_brush.scss\n\nThere are minor color changes in the `dual brush` and `GanttBar` in the\nJob Selector.\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1217\" alt=\"dual-brush-before-light\"\nsrc=\"https://github.com/user-attachments/assets/e87f1600-c1f1-42ef-a4f8-a8d5b21e2ca7\"\n/> | <img width=\"881\" alt=\"dual-brush-after-light\"\nsrc=\"https://github.com/user-attachments/assets/17996e65-50dc-42e8-9b9a-4757f2b30309\"\n/> |\n| <img width=\"863\" alt=\"dual-brush-before-dark\"\nsrc=\"https://github.com/user-attachments/assets/685fe511-b715-457b-8173-ece0d41f7bef\"\n/> | <img width=\"865\" alt=\"dual-brush-after-dark\"\nsrc=\"https://github.com/user-attachments/assets/593b6085-281b-49b2-b0fd-9ae6f44b6684\"\n/> |\n| <img width=\"576\" alt=\"job_selector_before_light\"\nsrc=\"https://github.com/user-attachments/assets/ce2438c1-a54f-4066-bb4d-b86412d55e1e\"\n/> | <img width=\"564\" alt=\"job_selector_after_light\"\nsrc=\"https://github.com/user-attachments/assets/74cb28d3-73c3-4836-ae53-f64f7730cf09\"\n/> |\n| <img width=\"581\" alt=\"job_selector_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/7be93e06-12a0-4715-ac35-74711e08c761\"\n/> | <img width=\"567\" alt=\"job_selector_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/c3af92ee-f510-4f40-a99a-04f446652d91\"\n/> |\n| <img width=\"574\" alt=\"role_editor_before_light\"\nsrc=\"https://github.com/user-attachments/assets/8e8e33b8-2688-4526-9062-20dab205dcbf\"\n/> | <img width=\"564\" alt=\"rule_editor_after_light\"\nsrc=\"https://github.com/user-attachments/assets/98142dfc-b74a-4bbd-af8c-c6c041805826\"\n/> |\n| <img width=\"576\" alt=\"role_editor_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/e534c5f1-f75a-433d-91d8-dc57e059e407\"\n/> | <img width=\"572\" alt=\"rule_editor_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/2f56394f-4585-4176-a178-ef85394ab46d\"\n/> |\n| <img width=\"572\" alt=\"quick_role_editor_before_light\"\nsrc=\"https://github.com/user-attachments/assets/7f414295-e799-4073-84b8-d2bd94eb293f\"\n/> | <img width=\"567\" alt=\"quick_role_editor_after_light\"\nsrc=\"https://github.com/user-attachments/assets/1d7bbc7b-bc44-4753-b9b6-6cac8cfb8953\"\n/> |\n| <img width=\"578\" alt=\"quick_role_editor_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/f1d5291e-ef72-4e40-a614-b909193ec060\"\n/> | <img width=\"562\" alt=\"quick_role_editor_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/90c2927a-0bf2-4f70-a13c-7937ae2bf476\"\n/> |\n| <img width=\"1205\" alt=\"discover_vis_before_light\"\nsrc=\"https://github.com/user-attachments/assets/899311e7-d10b-48fe-91e1-95c3af7f5608\"\n/> | <img width=\"1201\" alt=\"discover-vis-after-light\"\nsrc=\"https://github.com/user-attachments/assets/05f0dcde-6a1b-4139-95ba-19a24ad4fdcf\"\n/> |\n| <img width=\"1207\" alt=\"discover-vis-before-dark\"\nsrc=\"https://github.com/user-attachments/assets/cde9e49e-b9c3-4bd5-9bd5-32b4f09ce834\"\n/> | <img width=\"1207\" alt=\"discover-viz-after-dark\"\nsrc=\"https://github.com/user-attachments/assets/544e44a9-3676-448d-9348-d88a67284a59\"\n/> |\n| <img width=\"1160\" alt=\"anomalies_table_before_light\"\nsrc=\"https://github.com/user-attachments/assets/9be79294-9808-4509-a1cb-02e342d9abe2\"\n/> | <img width=\"1136\" alt=\"anomalies_table_after_light\"\nsrc=\"https://github.com/user-attachments/assets/3b3ce7ad-6f67-4caf-b12d-1839bb2c08ab\"\n/> |\n| <img width=\"1152\" alt=\"anomalies_table_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/8e5af9fd-90f5-4f85-bd5b-40dc0ab74d0a\"\n/> | <img width=\"1144\" alt=\"anomalies_table_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/c6ca08b6-e816-49d2-8c15-9ec9bb1dd983\"\n/> |\n| <img width=\"668\" alt=\"category_examples_before\"\nsrc=\"https://github.com/user-attachments/assets/9bfd1978-27fe-41bc-9828-f94314e420a6\"\n/> | <img width=\"1101\" alt=\"category_examples_after\"\nsrc=\"https://github.com/user-attachments/assets/72c58a22-6d1e-4901-898c-9c54c46eb3a9\"\n/> |","sha":"9f932a099b3b7202931aa59ec390a57642c4ad16","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore",":ml","release_note:skip","backport:version","v9.1.0","v8.19.0","scss-removal"],"title":"[ML] Replace legacy SCSS overwrites","number":216698,"url":"https://github.com/elastic/kibana/pull/216698","mergeCommit":{"message":"[ML] Replace legacy SCSS overwrites (#216698)\n\nPart of https://github.com/elastic/kibana/issues/140695\n\nThis PR replaces all remaining SCSS overrides in ML.\n\n> ml/public/application/_index.scss\n> ./job_selector/_index.scss\n> ./job_selector/_job_selector.scss\n> ./rule_editor/_index.scss\n> ./rule_editor/_rule_editor.scss\n> ./anomalies_table/_index.scss \n> ./anomalies_table/_anomalies_table.scss\n>\ndata_visualizer/public/application/common/components/stats_table/components/field_data_row/column_chart.scss\n>\ndata_visualizer/public/application/common/components/field_type_icon/_index.scss\n>\ndata_visualizer/public/application/common/components/field_type_icon/_field_type_icon.scss\n>\nx-pack/platform/packages/private/ml/aiops_components/src/dual_brush/dual_brush.scss\n\nThere are minor color changes in the `dual brush` and `GanttBar` in the\nJob Selector.\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1217\" alt=\"dual-brush-before-light\"\nsrc=\"https://github.com/user-attachments/assets/e87f1600-c1f1-42ef-a4f8-a8d5b21e2ca7\"\n/> | <img width=\"881\" alt=\"dual-brush-after-light\"\nsrc=\"https://github.com/user-attachments/assets/17996e65-50dc-42e8-9b9a-4757f2b30309\"\n/> |\n| <img width=\"863\" alt=\"dual-brush-before-dark\"\nsrc=\"https://github.com/user-attachments/assets/685fe511-b715-457b-8173-ece0d41f7bef\"\n/> | <img width=\"865\" alt=\"dual-brush-after-dark\"\nsrc=\"https://github.com/user-attachments/assets/593b6085-281b-49b2-b0fd-9ae6f44b6684\"\n/> |\n| <img width=\"576\" alt=\"job_selector_before_light\"\nsrc=\"https://github.com/user-attachments/assets/ce2438c1-a54f-4066-bb4d-b86412d55e1e\"\n/> | <img width=\"564\" alt=\"job_selector_after_light\"\nsrc=\"https://github.com/user-attachments/assets/74cb28d3-73c3-4836-ae53-f64f7730cf09\"\n/> |\n| <img width=\"581\" alt=\"job_selector_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/7be93e06-12a0-4715-ac35-74711e08c761\"\n/> | <img width=\"567\" alt=\"job_selector_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/c3af92ee-f510-4f40-a99a-04f446652d91\"\n/> |\n| <img width=\"574\" alt=\"role_editor_before_light\"\nsrc=\"https://github.com/user-attachments/assets/8e8e33b8-2688-4526-9062-20dab205dcbf\"\n/> | <img width=\"564\" alt=\"rule_editor_after_light\"\nsrc=\"https://github.com/user-attachments/assets/98142dfc-b74a-4bbd-af8c-c6c041805826\"\n/> |\n| <img width=\"576\" alt=\"role_editor_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/e534c5f1-f75a-433d-91d8-dc57e059e407\"\n/> | <img width=\"572\" alt=\"rule_editor_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/2f56394f-4585-4176-a178-ef85394ab46d\"\n/> |\n| <img width=\"572\" alt=\"quick_role_editor_before_light\"\nsrc=\"https://github.com/user-attachments/assets/7f414295-e799-4073-84b8-d2bd94eb293f\"\n/> | <img width=\"567\" alt=\"quick_role_editor_after_light\"\nsrc=\"https://github.com/user-attachments/assets/1d7bbc7b-bc44-4753-b9b6-6cac8cfb8953\"\n/> |\n| <img width=\"578\" alt=\"quick_role_editor_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/f1d5291e-ef72-4e40-a614-b909193ec060\"\n/> | <img width=\"562\" alt=\"quick_role_editor_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/90c2927a-0bf2-4f70-a13c-7937ae2bf476\"\n/> |\n| <img width=\"1205\" alt=\"discover_vis_before_light\"\nsrc=\"https://github.com/user-attachments/assets/899311e7-d10b-48fe-91e1-95c3af7f5608\"\n/> | <img width=\"1201\" alt=\"discover-vis-after-light\"\nsrc=\"https://github.com/user-attachments/assets/05f0dcde-6a1b-4139-95ba-19a24ad4fdcf\"\n/> |\n| <img width=\"1207\" alt=\"discover-vis-before-dark\"\nsrc=\"https://github.com/user-attachments/assets/cde9e49e-b9c3-4bd5-9bd5-32b4f09ce834\"\n/> | <img width=\"1207\" alt=\"discover-viz-after-dark\"\nsrc=\"https://github.com/user-attachments/assets/544e44a9-3676-448d-9348-d88a67284a59\"\n/> |\n| <img width=\"1160\" alt=\"anomalies_table_before_light\"\nsrc=\"https://github.com/user-attachments/assets/9be79294-9808-4509-a1cb-02e342d9abe2\"\n/> | <img width=\"1136\" alt=\"anomalies_table_after_light\"\nsrc=\"https://github.com/user-attachments/assets/3b3ce7ad-6f67-4caf-b12d-1839bb2c08ab\"\n/> |\n| <img width=\"1152\" alt=\"anomalies_table_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/8e5af9fd-90f5-4f85-bd5b-40dc0ab74d0a\"\n/> | <img width=\"1144\" alt=\"anomalies_table_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/c6ca08b6-e816-49d2-8c15-9ec9bb1dd983\"\n/> |\n| <img width=\"668\" alt=\"category_examples_before\"\nsrc=\"https://github.com/user-attachments/assets/9bfd1978-27fe-41bc-9828-f94314e420a6\"\n/> | <img width=\"1101\" alt=\"category_examples_after\"\nsrc=\"https://github.com/user-attachments/assets/72c58a22-6d1e-4901-898c-9c54c46eb3a9\"\n/> |","sha":"9f932a099b3b7202931aa59ec390a57642c4ad16"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216698","number":216698,"mergeCommit":{"message":"[ML] Replace legacy SCSS overwrites (#216698)\n\nPart of https://github.com/elastic/kibana/issues/140695\n\nThis PR replaces all remaining SCSS overrides in ML.\n\n> ml/public/application/_index.scss\n> ./job_selector/_index.scss\n> ./job_selector/_job_selector.scss\n> ./rule_editor/_index.scss\n> ./rule_editor/_rule_editor.scss\n> ./anomalies_table/_index.scss \n> ./anomalies_table/_anomalies_table.scss\n>\ndata_visualizer/public/application/common/components/stats_table/components/field_data_row/column_chart.scss\n>\ndata_visualizer/public/application/common/components/field_type_icon/_index.scss\n>\ndata_visualizer/public/application/common/components/field_type_icon/_field_type_icon.scss\n>\nx-pack/platform/packages/private/ml/aiops_components/src/dual_brush/dual_brush.scss\n\nThere are minor color changes in the `dual brush` and `GanttBar` in the\nJob Selector.\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"1217\" alt=\"dual-brush-before-light\"\nsrc=\"https://github.com/user-attachments/assets/e87f1600-c1f1-42ef-a4f8-a8d5b21e2ca7\"\n/> | <img width=\"881\" alt=\"dual-brush-after-light\"\nsrc=\"https://github.com/user-attachments/assets/17996e65-50dc-42e8-9b9a-4757f2b30309\"\n/> |\n| <img width=\"863\" alt=\"dual-brush-before-dark\"\nsrc=\"https://github.com/user-attachments/assets/685fe511-b715-457b-8173-ece0d41f7bef\"\n/> | <img width=\"865\" alt=\"dual-brush-after-dark\"\nsrc=\"https://github.com/user-attachments/assets/593b6085-281b-49b2-b0fd-9ae6f44b6684\"\n/> |\n| <img width=\"576\" alt=\"job_selector_before_light\"\nsrc=\"https://github.com/user-attachments/assets/ce2438c1-a54f-4066-bb4d-b86412d55e1e\"\n/> | <img width=\"564\" alt=\"job_selector_after_light\"\nsrc=\"https://github.com/user-attachments/assets/74cb28d3-73c3-4836-ae53-f64f7730cf09\"\n/> |\n| <img width=\"581\" alt=\"job_selector_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/7be93e06-12a0-4715-ac35-74711e08c761\"\n/> | <img width=\"567\" alt=\"job_selector_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/c3af92ee-f510-4f40-a99a-04f446652d91\"\n/> |\n| <img width=\"574\" alt=\"role_editor_before_light\"\nsrc=\"https://github.com/user-attachments/assets/8e8e33b8-2688-4526-9062-20dab205dcbf\"\n/> | <img width=\"564\" alt=\"rule_editor_after_light\"\nsrc=\"https://github.com/user-attachments/assets/98142dfc-b74a-4bbd-af8c-c6c041805826\"\n/> |\n| <img width=\"576\" alt=\"role_editor_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/e534c5f1-f75a-433d-91d8-dc57e059e407\"\n/> | <img width=\"572\" alt=\"rule_editor_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/2f56394f-4585-4176-a178-ef85394ab46d\"\n/> |\n| <img width=\"572\" alt=\"quick_role_editor_before_light\"\nsrc=\"https://github.com/user-attachments/assets/7f414295-e799-4073-84b8-d2bd94eb293f\"\n/> | <img width=\"567\" alt=\"quick_role_editor_after_light\"\nsrc=\"https://github.com/user-attachments/assets/1d7bbc7b-bc44-4753-b9b6-6cac8cfb8953\"\n/> |\n| <img width=\"578\" alt=\"quick_role_editor_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/f1d5291e-ef72-4e40-a614-b909193ec060\"\n/> | <img width=\"562\" alt=\"quick_role_editor_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/90c2927a-0bf2-4f70-a13c-7937ae2bf476\"\n/> |\n| <img width=\"1205\" alt=\"discover_vis_before_light\"\nsrc=\"https://github.com/user-attachments/assets/899311e7-d10b-48fe-91e1-95c3af7f5608\"\n/> | <img width=\"1201\" alt=\"discover-vis-after-light\"\nsrc=\"https://github.com/user-attachments/assets/05f0dcde-6a1b-4139-95ba-19a24ad4fdcf\"\n/> |\n| <img width=\"1207\" alt=\"discover-vis-before-dark\"\nsrc=\"https://github.com/user-attachments/assets/cde9e49e-b9c3-4bd5-9bd5-32b4f09ce834\"\n/> | <img width=\"1207\" alt=\"discover-viz-after-dark\"\nsrc=\"https://github.com/user-attachments/assets/544e44a9-3676-448d-9348-d88a67284a59\"\n/> |\n| <img width=\"1160\" alt=\"anomalies_table_before_light\"\nsrc=\"https://github.com/user-attachments/assets/9be79294-9808-4509-a1cb-02e342d9abe2\"\n/> | <img width=\"1136\" alt=\"anomalies_table_after_light\"\nsrc=\"https://github.com/user-attachments/assets/3b3ce7ad-6f67-4caf-b12d-1839bb2c08ab\"\n/> |\n| <img width=\"1152\" alt=\"anomalies_table_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/8e5af9fd-90f5-4f85-bd5b-40dc0ab74d0a\"\n/> | <img width=\"1144\" alt=\"anomalies_table_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/c6ca08b6-e816-49d2-8c15-9ec9bb1dd983\"\n/> |\n| <img width=\"668\" alt=\"category_examples_before\"\nsrc=\"https://github.com/user-attachments/assets/9bfd1978-27fe-41bc-9828-f94314e420a6\"\n/> | <img width=\"1101\" alt=\"category_examples_after\"\nsrc=\"https://github.com/user-attachments/assets/72c58a22-6d1e-4901-898c-9c54c46eb3a9\"\n/> |","sha":"9f932a099b3b7202931aa59ec390a57642c4ad16"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
baileycash-elastic
pushed a commit
to baileycash-elastic/kibana
that referenced
this pull request
Apr 7, 2025
Part of elastic#140695 This PR replaces all remaining SCSS overrides in ML. > ml/public/application/_index.scss > ./job_selector/_index.scss > ./job_selector/_job_selector.scss > ./rule_editor/_index.scss > ./rule_editor/_rule_editor.scss > ./anomalies_table/_index.scss > ./anomalies_table/_anomalies_table.scss > data_visualizer/public/application/common/components/stats_table/components/field_data_row/column_chart.scss > data_visualizer/public/application/common/components/field_type_icon/_index.scss > data_visualizer/public/application/common/components/field_type_icon/_field_type_icon.scss > x-pack/platform/packages/private/ml/aiops_components/src/dual_brush/dual_brush.scss There are minor color changes in the `dual brush` and `GanttBar` in the Job Selector. | Before | After | | ------------- | ------------- | | <img width="1217" alt="dual-brush-before-light" src="https://github.com/user-attachments/assets/e87f1600-c1f1-42ef-a4f8-a8d5b21e2ca7" /> | <img width="881" alt="dual-brush-after-light" src="https://github.com/user-attachments/assets/17996e65-50dc-42e8-9b9a-4757f2b30309" /> | | <img width="863" alt="dual-brush-before-dark" src="https://github.com/user-attachments/assets/685fe511-b715-457b-8173-ece0d41f7bef" /> | <img width="865" alt="dual-brush-after-dark" src="https://github.com/user-attachments/assets/593b6085-281b-49b2-b0fd-9ae6f44b6684" /> | | <img width="576" alt="job_selector_before_light" src="https://github.com/user-attachments/assets/ce2438c1-a54f-4066-bb4d-b86412d55e1e" /> | <img width="564" alt="job_selector_after_light" src="https://github.com/user-attachments/assets/74cb28d3-73c3-4836-ae53-f64f7730cf09" /> | | <img width="581" alt="job_selector_before_dark" src="https://github.com/user-attachments/assets/7be93e06-12a0-4715-ac35-74711e08c761" /> | <img width="567" alt="job_selector_after_dark" src="https://github.com/user-attachments/assets/c3af92ee-f510-4f40-a99a-04f446652d91" /> | | <img width="574" alt="role_editor_before_light" src="https://github.com/user-attachments/assets/8e8e33b8-2688-4526-9062-20dab205dcbf" /> | <img width="564" alt="rule_editor_after_light" src="https://github.com/user-attachments/assets/98142dfc-b74a-4bbd-af8c-c6c041805826" /> | | <img width="576" alt="role_editor_before_dark" src="https://github.com/user-attachments/assets/e534c5f1-f75a-433d-91d8-dc57e059e407" /> | <img width="572" alt="rule_editor_after_dark" src="https://github.com/user-attachments/assets/2f56394f-4585-4176-a178-ef85394ab46d" /> | | <img width="572" alt="quick_role_editor_before_light" src="https://github.com/user-attachments/assets/7f414295-e799-4073-84b8-d2bd94eb293f" /> | <img width="567" alt="quick_role_editor_after_light" src="https://github.com/user-attachments/assets/1d7bbc7b-bc44-4753-b9b6-6cac8cfb8953" /> | | <img width="578" alt="quick_role_editor_before_dark" src="https://github.com/user-attachments/assets/f1d5291e-ef72-4e40-a614-b909193ec060" /> | <img width="562" alt="quick_role_editor_after_dark" src="https://github.com/user-attachments/assets/90c2927a-0bf2-4f70-a13c-7937ae2bf476" /> | | <img width="1205" alt="discover_vis_before_light" src="https://github.com/user-attachments/assets/899311e7-d10b-48fe-91e1-95c3af7f5608" /> | <img width="1201" alt="discover-vis-after-light" src="https://github.com/user-attachments/assets/05f0dcde-6a1b-4139-95ba-19a24ad4fdcf" /> | | <img width="1207" alt="discover-vis-before-dark" src="https://github.com/user-attachments/assets/cde9e49e-b9c3-4bd5-9bd5-32b4f09ce834" /> | <img width="1207" alt="discover-viz-after-dark" src="https://github.com/user-attachments/assets/544e44a9-3676-448d-9348-d88a67284a59" /> | | <img width="1160" alt="anomalies_table_before_light" src="https://github.com/user-attachments/assets/9be79294-9808-4509-a1cb-02e342d9abe2" /> | <img width="1136" alt="anomalies_table_after_light" src="https://github.com/user-attachments/assets/3b3ce7ad-6f67-4caf-b12d-1839bb2c08ab" /> | | <img width="1152" alt="anomalies_table_before_dark" src="https://github.com/user-attachments/assets/8e5af9fd-90f5-4f85-bd5b-40dc0ab74d0a" /> | <img width="1144" alt="anomalies_table_after_dark" src="https://github.com/user-attachments/assets/c6ca08b6-e816-49d2-8c15-9ec9bb1dd983" /> | | <img width="668" alt="category_examples_before" src="https://github.com/user-attachments/assets/9bfd1978-27fe-41bc-9828-f94314e420a6" /> | <img width="1101" alt="category_examples_after" src="https://github.com/user-attachments/assets/72c58a22-6d1e-4901-898c-9c54c46eb3a9" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #140695
This PR replaces all remaining SCSS overrides in ML.
There are minor color changes in the
dual brushandGanttBarin the Job Selector.