Skip to content

[A11y][APM] Add aria-label to technical preview badge#216483

Merged
rmyz merged 2 commits intoelastic:mainfrom
rmyz:212093-a11y-apm-tecnical-preview-badge
Apr 1, 2025
Merged

[A11y][APM] Add aria-label to technical preview badge#216483
rmyz merged 2 commits intoelastic:mainfrom
rmyz:212093-a11y-apm-tecnical-preview-badge

Conversation

@rmyz
Copy link
Contributor

@rmyz rmyz commented Mar 31, 2025

Summary

Fixes #212093

This PR adds the aria-label prop so screen readers work with this tooltip text.
image

@rmyz rmyz self-assigned this Mar 31, 2025
@rmyz rmyz added release_note:fix apm Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. backport:version Backport to applied version labels a11y Accessibility issue v8.19.0 labels Mar 31, 2025
@rmyz rmyz changed the title refactor: add aria label to technical preview badge [A11y][APM] Add aria-label to technical preview badge Mar 31, 2025
@rmyz rmyz marked this pull request as ready for review March 31, 2025 14:30
@rmyz rmyz requested a review from a team March 31, 2025 14:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.5MB 2.5MB +330.0B

cc @rmyz

@rmyz rmyz merged commit 8767adc into elastic:main Apr 1, 2025
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14191710590

@rmyz rmyz deleted the 212093-a11y-apm-tecnical-preview-badge branch April 1, 2025 09:10
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 1, 2025
## Summary

Fixes elastic#212093

This PR adds the `aria-label` prop so screen readers work with this
tooltip text.

![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)

(cherry picked from commit 8767adc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 1, 2025
… (#216601)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[A11y][APM] Add `aria-label` to technical preview badge
(#216483)](#216483)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-04-01T09:08:27Z","message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v9.1.0","v8.19.0"],"title":"[A11y][APM]
Add `aria-label` to technical preview
badge","number":216483,"url":"https://github.com/elastic/kibana/pull/216483","mergeCommit":{"message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216483","number":216483,"mergeCommit":{"message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
@rmyz rmyz added v8.18.0 v9.0.1 backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Apr 9, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14350959408

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 9, 2025
## Summary

Fixes elastic#212093

This PR adds the `aria-label` prop so screen readers work with this
tooltip text.

![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)

(cherry picked from commit 8767adc)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 9, 2025
## Summary

Fixes elastic#212093

This PR adds the `aria-label` prop so screen readers work with this
tooltip text.

![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)

(cherry picked from commit 8767adc)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.18
8.x Cherrypick failed because the selected commit (8767adc) is empty. It looks like the commit was already backported in #216601
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 216483

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 9, 2025
…) (#217611)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[A11y][APM] Add `aria-label` to technical preview badge
(#216483)](#216483)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-04-01T09:08:27Z","message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM]
Add `aria-label` to technical preview
badge","number":216483,"url":"https://github.com/elastic/kibana/pull/216483","mergeCommit":{"message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216483","number":216483,"mergeCommit":{"message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216601","number":216601,"state":"MERGED","mergeCommit":{"sha":"5561abe7fcaf697171e4d494ad5db7863e9b7fe4","message":"[8.x]
[A11y][APM] Add `aria-label` to technical preview badge (#216483)
(#216601)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[A11y][APM] Add `aria-label` to technical preview
badge\n(#216483)](https://github.com/elastic/kibana/pull/216483)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Sergi Romeu
<sergi.romeu@elastic.co>"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 9, 2025
… (#217612)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[A11y][APM] Add `aria-label` to technical preview badge
(#216483)](#216483)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-04-01T09:08:27Z","message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM]
Add `aria-label` to technical preview
badge","number":216483,"url":"https://github.com/elastic/kibana/pull/216483","mergeCommit":{"message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216483","number":216483,"mergeCommit":{"message":"[A11y][APM]
Add `aria-label` to technical preview badge (#216483)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/212093\n\nThis
PR adds the `aria-label` prop so screen readers work with this\ntooltip
text.\n\n![image](https://github.com/user-attachments/assets/8c3d345d-68be-42cb-ab6f-addafd0d7683)","sha":"8767adc6222f5201a37bf6ed84ac4418d05b57a0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216601","number":216601,"state":"MERGED","mergeCommit":{"sha":"5561abe7fcaf697171e4d494ad5db7863e9b7fe4","message":"[8.x]
[A11y][APM] Add `aria-label` to technical preview badge (#216483)
(#216601)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[A11y][APM] Add `aria-label` to technical preview
badge\n(#216483)](https://github.com/elastic/kibana/pull/216483)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Sergi Romeu
<sergi.romeu@elastic.co>"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility issue apm backport:version Backport to applied version labels release_note:fix Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Observability:Applications:Traces page]Missing element and tooltip text announcement

5 participants