[9.0] [Security Solution] [Detections] Fix flakey EQL shard test (#215757)#216375
Merged
dhurley14 merged 1 commit intoelastic:9.0from Mar 28, 2025
Merged
[9.0] [Security Solution] [Detections] Fix flakey EQL shard test (#215757)#216375dhurley14 merged 1 commit intoelastic:9.0from
dhurley14 merged 1 commit intoelastic:9.0from
Conversation
…15757) ## Summary Ref: elastic#209024 Flake caused by occasionally hitting max signals on the "good" shard and never triggering the error from the runtime field on the "bad" shard. By moving the bad runtime field to the `packetbeat` index and changing the rule query in the test to an `and` we can ensure the rule queries both good and bad shards. ### Checklist - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit d869d47) # Conflicts: # x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/eql/trial_license_complete_tier/eql.ts
1 task
marshallmain
approved these changes
Mar 28, 2025
rylnd
added a commit
that referenced
this pull request
Aug 29, 2025
…15757) (#233535) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] [Detections] Fix flakey EQL shard test (#215757)](#215757) Closes #209024; details can be found there. <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devin W. Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2025-03-28T18:47:15Z","message":"[Security Solution] [Detections] Fix flakey EQL shard test (#215757)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/209024\n\nFlake caused by occasionally hitting max signals on the \"good\" shard and\nnever triggering the error from the runtime field on the \"bad\" shard. By\nmoving the bad runtime field to the `packetbeat` index and changing the\nrule query in the test to an `and` we can ensure the rule queries both\ngood and bad shards.\n\n### Checklist\n\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"d869d472f0b9b55c635580c4d7d15faff8b8c215","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","Team:Detection Engine","backport:version","v9.1.0","v9.0.1"],"title":"[Security Solution] [Detections] Fix flakey EQL shard test","number":215757,"url":"https://github.com/elastic/kibana/pull/215757","mergeCommit":{"message":"[Security Solution] [Detections] Fix flakey EQL shard test (#215757)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/209024\n\nFlake caused by occasionally hitting max signals on the \"good\" shard and\nnever triggering the error from the runtime field on the \"bad\" shard. By\nmoving the bad runtime field to the `packetbeat` index and changing the\nrule query in the test to an `and` we can ensure the rule queries both\ngood and bad shards.\n\n### Checklist\n\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"d869d472f0b9b55c635580c4d7d15faff8b8c215"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216375","number":216375,"state":"MERGED","mergeCommit":{"sha":"a2002e0bd3692dd9dfeca80d0dbc38dd3a2af18a","message":"[9.0] [Security Solution] [Detections] Fix flakey EQL shard test (#215757) (#216375)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] [Detections] Fix flakey EQL shard test\n(#215757)](https://github.com/elastic/kibana/pull/215757)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215757","number":215757,"mergeCommit":{"message":"[Security Solution] [Detections] Fix flakey EQL shard test (#215757)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/209024\n\nFlake caused by occasionally hitting max signals on the \"good\" shard and\nnever triggering the error from the runtime field on the \"bad\" shard. By\nmoving the bad runtime field to the `packetbeat` index and changing the\nrule query in the test to an `and` we can ensure the rule queries both\ngood and bad shards.\n\n### Checklist\n\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"d869d472f0b9b55c635580c4d7d15faff8b8c215"}}]}] BACKPORT--> --------- Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation