[APM][OTel] Fix layers issue for ESQL visualization by adding textBased layers#216358
Merged
Conversation
jennypavlova
added
the
Team:obs-ux-infra_services - DEPRECATED
…ork-if-embedded-dashboard-includes-esql-visualizations
JonasKunz
reviewed
Mar 31, 2025
Contributor
JonasKunz
left a comment
JonasKunz
left a comment
There was a problem hiding this comment.
It works ... kind of. The dashboard is displayed, but it seems to be in "edit mode":
There are dashed lines around the panels, the panels can be dragged around and it is possible to open the visualization settings via the pen-icon:
…pp/metrics/static_dashboard/dashboards/dashboard_catalog.ts Co-authored-by: Jonas Kunz <j+github@kunzj.de>
Member
Author
@JonasKunz Thank you for checking! |
Member
Author
|
/ci |
…ork-if-embedded-dashboard-includes-esql-visualizations
Member
Author
|
/ci |
jennypavlova
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
changed the title
textBased layerstextBased layers
…ork-if-embedded-dashboard-includes-esql-visualizations
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
added
release_note:fix
backport:prev-minor
ci:cloud-redeploy
Member
Author
|
Hi @JonasKunz, I will open this PR as it will fix this issue and the "edit issue" we should address separately ( I will open a separate issue for that to collaborate with @elastic/kibana-presentation team to fix it - I am not sure if it's a bug as it worked like that before this one 🤔 so I guess a regression of something else or a dashboards change ) Issue added: #217065 |
jennypavlova
changed the title
textBased layerstextBased layers
jennypavlova
changed the title
textBased layerstextBased layers
…ork-if-embedded-dashboard-includes-esql-visualizations
|
Can we please backport it to 8.x? |
…ork-if-embedded-dashboard-includes-esql-visualizations
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
Contributor
|
Also gave it another go with some EDOT Java data. Dashboard looks fine and correct |
JonasKunz
approved these changes
Apr 7, 2025
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14310306879 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 7, 2025
…sed` layers (elastic#216358) Closes elastic#215675 ## Summary This PR fixes the issue with the ESQL visualization by supporting `textBased` layers. For testing, there is a link to the serverless env of this PR and it should be tested EDOT Java SDK as shown in [the screenshot in this comment](elastic#216358 (review)) --------- Co-authored-by: Jonas Kunz <j+github@kunzj.de> (cherry picked from commit 523fa76)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 7, 2025
…sed` layers (elastic#216358) Closes elastic#215675 ## Summary This PR fixes the issue with the ESQL visualization by supporting `textBased` layers. For testing, there is a link to the serverless env of this PR and it should be tested EDOT Java SDK as shown in [the screenshot in this comment](elastic#216358 (review)) --------- Co-authored-by: Jonas Kunz <j+github@kunzj.de> (cherry picked from commit 523fa76)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 7, 2025
…sed` layers (elastic#216358) Closes elastic#215675 ## Summary This PR fixes the issue with the ESQL visualization by supporting `textBased` layers. For testing, there is a link to the serverless env of this PR and it should be tested EDOT Java SDK as shown in [the screenshot in this comment](elastic#216358 (review)) --------- Co-authored-by: Jonas Kunz <j+github@kunzj.de> (cherry picked from commit 523fa76)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
|
I think a backport to the next 8.x release (8.19) would be sufficient, having it already in 8.18.x would be a nice-to-have. We don't need support in previous versions, I'm even not sure if everything works there correctly. I originally created the dashboard in 8.18, so I'm confident that it works there and looks correct. |
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2025
…textBased` layers (#216358) (#217324) # Backport This will backport the following commits from `main` to `9.0`: - [[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)](#216358) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-07T13:20:12Z","message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","ci:cloud-redeploy","ci:project-deploy-observability","Team:obs-ux-infra_services","v9.1.0"],"title":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers","number":216358,"url":"https://github.com/elastic/kibana/pull/216358","mergeCommit":{"message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216358","number":216358,"mergeCommit":{"message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd"}}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2025
…textBased` layers (#216358) (#217323) # Backport This will backport the following commits from `main` to `8.x`: - [[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)](#216358) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-07T13:20:12Z","message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","ci:cloud-redeploy","ci:project-deploy-observability","Team:obs-ux-infra_services","v9.1.0"],"title":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers","number":216358,"url":"https://github.com/elastic/kibana/pull/216358","mergeCommit":{"message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216358","number":216358,"mergeCommit":{"message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd"}}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2025
…`textBased` layers (#216358) (#217321) # Backport This will backport the following commits from `main` to `8.18`: - [[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)](#216358) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-07T13:20:12Z","message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","ci:cloud-redeploy","ci:project-deploy-observability","Team:obs-ux-infra_services","v9.1.0"],"title":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers","number":216358,"url":"https://github.com/elastic/kibana/pull/216358","mergeCommit":{"message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216358","number":216358,"mergeCommit":{"message":"[APM][OTel] Fix layers issue for ESQL visualization by adding `textBased` layers (#216358)\n\nCloses #215675 \n\n## Summary\n\nThis PR fixes the issue with the ESQL visualization by supporting\n`textBased` layers. For testing, there is a link to the serverless env\nof this PR and it should be tested EDOT Java SDK as shown in [the\nscreenshot in this\ncomment](https://github.com/elastic/kibana/pull/216358#pullrequestreview-2728718952)\n\n---------\n\nCo-authored-by: Jonas Kunz <j+github@kunzj.de>","sha":"523fa7689cb5edabf613ee46fbce647609b22bdd"}}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
baileycash-elastic
pushed a commit
to baileycash-elastic/kibana
that referenced
this pull request
Apr 7, 2025
…sed` layers (elastic#216358) Closes elastic#215675 ## Summary This PR fixes the issue with the ESQL visualization by supporting `textBased` layers. For testing, there is a link to the serverless env of this PR and it should be tested EDOT Java SDK as shown in [the screenshot in this comment](elastic#216358 (review)) --------- Co-authored-by: Jonas Kunz <j+github@kunzj.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #215675
Summary
This PR fixes the issue with the ESQL visualization by supporting
textBasedlayers. For testing, there is a link to the serverless env of this PR and it should be tested EDOT Java SDK as shown in the screenshot in this comment