[ML] Replace Legacy Base Theme Usage#216307
Merged
rbrtj merged 14 commits intoelastic:mainfrom Apr 2, 2025
Merged
Conversation
rbrtj
added
:ml
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
rbrtj
added
backport:all-open
..._analytics/pages/analytics_exploration/components/feature_importance/decision_path_chart.tsx
Show resolved
Hide resolved
Contributor
|
Not related to your changes here, but I noticed this effect in the multi-metric job wizard charts where the headers are transparent. Maybe we could fix this as part of this PR? 
In light theme, it looks ok: 
|
Contributor
Author
The mentioned issue is addressed in elastic/eui#8519. |
| const { euiTheme, colorMode } = useEuiTheme(); | ||
| const panels: Panel[] = []; | ||
|
|
||
| const isLightTheme = colorMode === 'LIGHT'; |
Member
There was a problem hiding this comment.
nit pick
Suggested change
| const isLightTheme = colorMode === 'LIGHT'; | |
| const isLightTheme = colorMode === COLOR_MODES_STANDARD.light; |
peteharverson
approved these changes
Apr 1, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest changes and LGTM
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @rbrtj |
Contributor
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14219991430 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 2, 2025
Fix for: elastic#213974 Replacing legacy base theme with appropriate theme from the charts hook. | Before | After | | ------------- | ------------- | | <img width="404" alt="decision_path_before_light" src="https://github.com/user-attachments/assets/217cb07d-65a2-4ac0-948b-9950af1e2663" /> |  | |  | <img width="403" alt="decision_path_after_dark" src="https://github.com/user-attachments/assets/5fc47999-e8c6-48f1-9293-03f23ce437e0" /> | | <img width="769" alt="feature_importance_before_light" src="https://github.com/user-attachments/assets/6d25f980-0dd2-4a6a-a43f-450afa76fa62" /> |  | | <img width="767" alt="feature_importance_before_dark" src="https://github.com/user-attachments/assets/db7eb5d7-80b3-49fa-99a5-1ae204fdbcc6" /> |  | | <img width="536" alt="datafeed_chart_before_light" src="https://github.com/user-attachments/assets/a5230c96-50f4-4754-a09f-8fe429da5f8d" /> | <img width="728" alt="image" src="https://github.com/user-attachments/assets/12d37527-cdec-410c-a8db-3c1176a6e1c9" /> | | <img width="497" alt="datafeed_chart_before_dark" src="https://github.com/user-attachments/assets/3db9a313-baed-4abd-9cec-33abffcfd9d9" /> | <img width="732" alt="datafeed_chart_after_dark" src="https://github.com/user-attachments/assets/b8bf681a-f873-43a7-ad2d-2775ae91d4e3" /> | | <img width="813" alt="anomaly_chart_before_light" src="https://github.com/user-attachments/assets/cf7cab54-513f-40dc-bb28-dbb7d93850b5" /> | <img width="805" alt="anomaly_chart_after_light" src="https://github.com/user-attachments/assets/25b95962-00ec-4066-895a-71ee771609c9" /> | | <img width="795" alt="anomaly_chart_before_dark" src="https://github.com/user-attachments/assets/a87e2f8e-b871-409a-9485-9b05a5195025" /> | <img width="802" alt="anomaly_chart_after_dark" src="https://github.com/user-attachments/assets/ac27f414-c5fa-409b-b289-4f629de4e729" /> | | <img width="799" alt="event_rate_chart_before_light" src="https://github.com/user-attachments/assets/346fdfaf-4c71-4e1d-ad72-ac3ef8abde32" /> | <img width="801" alt="event_rate_chart_after_light" src="https://github.com/user-attachments/assets/23a14bee-bd89-4dea-ad67-c29116e7e275" /> | | <img width="797" alt="event_rate_chart_before_dark" src="https://github.com/user-attachments/assets/7c255206-299c-4dfd-9134-06517f82ba23" /> | <img width="810" alt="event_rate_chart_after_dark" src="https://github.com/user-attachments/assets/6f2c912e-cdeb-4be4-84a1-1520eec65d01" /> | (cherry picked from commit 62a1589)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
rbrtj
added
backport:version
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14220253694 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rbrtj
added a commit
to rbrtj/kibana
that referenced
this pull request
Apr 2, 2025
Fix for: elastic#213974 Replacing legacy base theme with appropriate theme from the charts hook. | Before | After | | ------------- | ------------- | | <img width="404" alt="decision_path_before_light" src="https://github.com/user-attachments/assets/217cb07d-65a2-4ac0-948b-9950af1e2663" /> |  | |  | <img width="403" alt="decision_path_after_dark" src="https://github.com/user-attachments/assets/5fc47999-e8c6-48f1-9293-03f23ce437e0" /> | | <img width="769" alt="feature_importance_before_light" src="https://github.com/user-attachments/assets/6d25f980-0dd2-4a6a-a43f-450afa76fa62" /> |  | | <img width="767" alt="feature_importance_before_dark" src="https://github.com/user-attachments/assets/db7eb5d7-80b3-49fa-99a5-1ae204fdbcc6" /> |  | | <img width="536" alt="datafeed_chart_before_light" src="https://github.com/user-attachments/assets/a5230c96-50f4-4754-a09f-8fe429da5f8d" /> | <img width="728" alt="image" src="https://github.com/user-attachments/assets/12d37527-cdec-410c-a8db-3c1176a6e1c9" /> | | <img width="497" alt="datafeed_chart_before_dark" src="https://github.com/user-attachments/assets/3db9a313-baed-4abd-9cec-33abffcfd9d9" /> | <img width="732" alt="datafeed_chart_after_dark" src="https://github.com/user-attachments/assets/b8bf681a-f873-43a7-ad2d-2775ae91d4e3" /> | | <img width="813" alt="anomaly_chart_before_light" src="https://github.com/user-attachments/assets/cf7cab54-513f-40dc-bb28-dbb7d93850b5" /> | <img width="805" alt="anomaly_chart_after_light" src="https://github.com/user-attachments/assets/25b95962-00ec-4066-895a-71ee771609c9" /> | | <img width="795" alt="anomaly_chart_before_dark" src="https://github.com/user-attachments/assets/a87e2f8e-b871-409a-9485-9b05a5195025" /> | <img width="802" alt="anomaly_chart_after_dark" src="https://github.com/user-attachments/assets/ac27f414-c5fa-409b-b289-4f629de4e729" /> | | <img width="799" alt="event_rate_chart_before_light" src="https://github.com/user-attachments/assets/346fdfaf-4c71-4e1d-ad72-ac3ef8abde32" /> | <img width="801" alt="event_rate_chart_after_light" src="https://github.com/user-attachments/assets/23a14bee-bd89-4dea-ad67-c29116e7e275" /> | | <img width="797" alt="event_rate_chart_before_dark" src="https://github.com/user-attachments/assets/7c255206-299c-4dfd-9134-06517f82ba23" /> | <img width="810" alt="event_rate_chart_after_dark" src="https://github.com/user-attachments/assets/6f2c912e-cdeb-4be4-84a1-1520eec65d01" /> | (cherry picked from commit 62a1589) # Conflicts: # x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/feature_importance/decision_path_chart.tsx # x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/total_feature_importance_summary/feature_importance_summary.tsx # x-pack/platform/plugins/shared/ml/public/application/jobs/jobs_list/components/datafeed_chart_flyout/datafeed_chart_flyout.tsx
rbrtj
added a commit
that referenced
this pull request
Apr 2, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] Replace Legacy Base Theme Usage (#216307)](#216307) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-02T12:47:42Z","message":"[ML] Replace Legacy Base Theme Usage (#216307)\n\nFix for: https://github.com/elastic/kibana/issues/213974\nReplacing legacy base theme with appropriate theme from the charts hook.\n\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"404\" alt=\"decision_path_before_light\"\nsrc=\"https://github.com/user-attachments/assets/217cb07d-65a2-4ac0-948b-9950af1e2663\"\n/> |\n\n|\n|\n\n| <img width=\"403\" alt=\"decision_path_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/5fc47999-e8c6-48f1-9293-03f23ce437e0\"\n/> |\n| <img width=\"769\" alt=\"feature_importance_before_light\"\nsrc=\"https://github.com/user-attachments/assets/6d25f980-0dd2-4a6a-a43f-450afa76fa62\"\n/> |\n\n|\n| <img width=\"767\" alt=\"feature_importance_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/db7eb5d7-80b3-49fa-99a5-1ae204fdbcc6\"\n/> |\n\n|\n| <img width=\"536\" alt=\"datafeed_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/a5230c96-50f4-4754-a09f-8fe429da5f8d\"\n/> | <img width=\"728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/12d37527-cdec-410c-a8db-3c1176a6e1c9\"\n/> |\n| <img width=\"497\" alt=\"datafeed_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/3db9a313-baed-4abd-9cec-33abffcfd9d9\"\n/> | <img width=\"732\" alt=\"datafeed_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/b8bf681a-f873-43a7-ad2d-2775ae91d4e3\"\n/> |\n| <img width=\"813\" alt=\"anomaly_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/cf7cab54-513f-40dc-bb28-dbb7d93850b5\"\n/> | <img width=\"805\" alt=\"anomaly_chart_after_light\"\nsrc=\"https://github.com/user-attachments/assets/25b95962-00ec-4066-895a-71ee771609c9\"\n/> |\n| <img width=\"795\" alt=\"anomaly_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/a87e2f8e-b871-409a-9485-9b05a5195025\"\n/> | <img width=\"802\" alt=\"anomaly_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/ac27f414-c5fa-409b-b289-4f629de4e729\"\n/> |\n| <img width=\"799\" alt=\"event_rate_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/346fdfaf-4c71-4e1d-ad72-ac3ef8abde32\"\n/> | <img width=\"801\" alt=\"event_rate_chart_after_light\"\nsrc=\"https://github.com/user-attachments/assets/23a14bee-bd89-4dea-ad67-c29116e7e275\"\n/> |\n| <img width=\"797\" alt=\"event_rate_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/7c255206-299c-4dfd-9134-06517f82ba23\"\n/> | <img width=\"810\" alt=\"event_rate_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/6f2c912e-cdeb-4be4-84a1-1520eec65d01\"\n/> |","sha":"62a1589ed1cf4769a76ac2999cc18182a9b23dfa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Team:ML","backport:version","v9.1.0","v8.19.0"],"title":"[ML] Replace Legacy Base Theme Usage","number":216307,"url":"https://github.com/elastic/kibana/pull/216307","mergeCommit":{"message":"[ML] Replace Legacy Base Theme Usage (#216307)\n\nFix for: https://github.com/elastic/kibana/issues/213974\nReplacing legacy base theme with appropriate theme from the charts hook.\n\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"404\" alt=\"decision_path_before_light\"\nsrc=\"https://github.com/user-attachments/assets/217cb07d-65a2-4ac0-948b-9950af1e2663\"\n/> |\n\n|\n|\n\n| <img width=\"403\" alt=\"decision_path_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/5fc47999-e8c6-48f1-9293-03f23ce437e0\"\n/> |\n| <img width=\"769\" alt=\"feature_importance_before_light\"\nsrc=\"https://github.com/user-attachments/assets/6d25f980-0dd2-4a6a-a43f-450afa76fa62\"\n/> |\n\n|\n| <img width=\"767\" alt=\"feature_importance_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/db7eb5d7-80b3-49fa-99a5-1ae204fdbcc6\"\n/> |\n\n|\n| <img width=\"536\" alt=\"datafeed_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/a5230c96-50f4-4754-a09f-8fe429da5f8d\"\n/> | <img width=\"728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/12d37527-cdec-410c-a8db-3c1176a6e1c9\"\n/> |\n| <img width=\"497\" alt=\"datafeed_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/3db9a313-baed-4abd-9cec-33abffcfd9d9\"\n/> | <img width=\"732\" alt=\"datafeed_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/b8bf681a-f873-43a7-ad2d-2775ae91d4e3\"\n/> |\n| <img width=\"813\" alt=\"anomaly_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/cf7cab54-513f-40dc-bb28-dbb7d93850b5\"\n/> | <img width=\"805\" alt=\"anomaly_chart_after_light\"\nsrc=\"https://github.com/user-attachments/assets/25b95962-00ec-4066-895a-71ee771609c9\"\n/> |\n| <img width=\"795\" alt=\"anomaly_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/a87e2f8e-b871-409a-9485-9b05a5195025\"\n/> | <img width=\"802\" alt=\"anomaly_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/ac27f414-c5fa-409b-b289-4f629de4e729\"\n/> |\n| <img width=\"799\" alt=\"event_rate_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/346fdfaf-4c71-4e1d-ad72-ac3ef8abde32\"\n/> | <img width=\"801\" alt=\"event_rate_chart_after_light\"\nsrc=\"https://github.com/user-attachments/assets/23a14bee-bd89-4dea-ad67-c29116e7e275\"\n/> |\n| <img width=\"797\" alt=\"event_rate_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/7c255206-299c-4dfd-9134-06517f82ba23\"\n/> | <img width=\"810\" alt=\"event_rate_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/6f2c912e-cdeb-4be4-84a1-1520eec65d01\"\n/> |","sha":"62a1589ed1cf4769a76ac2999cc18182a9b23dfa"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216307","number":216307,"mergeCommit":{"message":"[ML] Replace Legacy Base Theme Usage (#216307)\n\nFix for: https://github.com/elastic/kibana/issues/213974\nReplacing legacy base theme with appropriate theme from the charts hook.\n\n\n| Before | After |\n| ------------- | ------------- |\n| <img width=\"404\" alt=\"decision_path_before_light\"\nsrc=\"https://github.com/user-attachments/assets/217cb07d-65a2-4ac0-948b-9950af1e2663\"\n/> |\n\n|\n|\n\n| <img width=\"403\" alt=\"decision_path_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/5fc47999-e8c6-48f1-9293-03f23ce437e0\"\n/> |\n| <img width=\"769\" alt=\"feature_importance_before_light\"\nsrc=\"https://github.com/user-attachments/assets/6d25f980-0dd2-4a6a-a43f-450afa76fa62\"\n/> |\n\n|\n| <img width=\"767\" alt=\"feature_importance_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/db7eb5d7-80b3-49fa-99a5-1ae204fdbcc6\"\n/> |\n\n|\n| <img width=\"536\" alt=\"datafeed_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/a5230c96-50f4-4754-a09f-8fe429da5f8d\"\n/> | <img width=\"728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/12d37527-cdec-410c-a8db-3c1176a6e1c9\"\n/> |\n| <img width=\"497\" alt=\"datafeed_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/3db9a313-baed-4abd-9cec-33abffcfd9d9\"\n/> | <img width=\"732\" alt=\"datafeed_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/b8bf681a-f873-43a7-ad2d-2775ae91d4e3\"\n/> |\n| <img width=\"813\" alt=\"anomaly_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/cf7cab54-513f-40dc-bb28-dbb7d93850b5\"\n/> | <img width=\"805\" alt=\"anomaly_chart_after_light\"\nsrc=\"https://github.com/user-attachments/assets/25b95962-00ec-4066-895a-71ee771609c9\"\n/> |\n| <img width=\"795\" alt=\"anomaly_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/a87e2f8e-b871-409a-9485-9b05a5195025\"\n/> | <img width=\"802\" alt=\"anomaly_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/ac27f414-c5fa-409b-b289-4f629de4e729\"\n/> |\n| <img width=\"799\" alt=\"event_rate_chart_before_light\"\nsrc=\"https://github.com/user-attachments/assets/346fdfaf-4c71-4e1d-ad72-ac3ef8abde32\"\n/> | <img width=\"801\" alt=\"event_rate_chart_after_light\"\nsrc=\"https://github.com/user-attachments/assets/23a14bee-bd89-4dea-ad67-c29116e7e275\"\n/> |\n| <img width=\"797\" alt=\"event_rate_chart_before_dark\"\nsrc=\"https://github.com/user-attachments/assets/7c255206-299c-4dfd-9134-06517f82ba23\"\n/> | <img width=\"810\" alt=\"event_rate_chart_after_dark\"\nsrc=\"https://github.com/user-attachments/assets/6f2c912e-cdeb-4be4-84a1-1520eec65d01\"\n/> |","sha":"62a1589ed1cf4769a76ac2999cc18182a9b23dfa"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #213974
Replacing legacy base theme with appropriate theme from the charts hook.