[ML] Anomalies table: Enhances display for anomaly time function values#216142
Merged
rbrtj merged 15 commits intoelastic:mainfrom Apr 2, 2025
Merged
[ML] Anomalies table: Enhances display for anomaly time function values#216142rbrtj merged 15 commits intoelastic:mainfrom
rbrtj merged 15 commits intoelastic:mainfrom
Conversation
rbrtj
added
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
peteharverson
changed the title
15 tasks
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Really like the addition of the +1 / -1 to clarify the values here. Overall looks good, just left a couple of comments.
| })); | ||
|
|
||
| const baseProps = { | ||
| value: 42.5, |
Contributor
There was a problem hiding this comment.
Is it worth setting more decimal places in the test value here to check that the formatting truncates the number of decimal places to the expected value? (Although we are doing this in the format_value.ts tests, so maybe not needed here too).
Contributor
Author
There was a problem hiding this comment.
I think it's not necessary, as format_value.ts is tested properly, and here we just want to ensure that the component correctly uses the formatter and displays its output.
...rm/plugins/shared/ml/public/application/components/anomalies_table/anomaly_value_display.tsx
Outdated
Show resolved
Hide resolved
| source | ||
| description: ( | ||
| <AnomalyValueDisplay | ||
| value={anomaly.source.anomaly_score_explanation?.upper_confidence_bound} |
Contributor
There was a problem hiding this comment.
@valeriy42 out of interest, why do some anomalies not have the upper / lower bounds set?
...st/alerting_api_integration/security_and_spaces/group5/tests/alerting/rule_types_internal.ts
Show resolved
Hide resolved
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/rule_types_internal.ts
Show resolved
Hide resolved
darnautov
reviewed
Mar 28, 2025
...ugins/shared/ml/public/application/components/anomalies_table/anomaly_value_display.test.tsx
Outdated
Show resolved
Hide resolved
...rm/plugins/shared/ml/public/application/components/anomalies_table/anomaly_value_display.tsx
Outdated
Show resolved
Hide resolved
...tform/plugins/shared/ml/public/application/components/anomalies_table/anomaly_value_utils.ts
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/ml/public/application/formatters/format_value.ts
Outdated
Show resolved
Hide resolved
peteharverson
approved these changes
Mar 31, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest changes and LGTM
Contributor
💚 Build Succeeded
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
cc @rbrtj |
rbrtj
added
backport:version
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14214670756 |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14214670806 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 2, 2025
…es (elastic#216142) Introducing tooltips and `+1` / `-1` subscripts for date values to improve readability for the values of `time_of_day` anomaly detection function. Fix for: elastic#213882 It turns out the formatting was correct for the screenshot provided in the issue as the upper bound is pointing to the next day.  Format following these changes:   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e510e53)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 2, 2025
…es (elastic#216142) Introducing tooltips and `+1` / `-1` subscripts for date values to improve readability for the values of `time_of_day` anomaly detection function. Fix for: elastic#213882 It turns out the formatting was correct for the screenshot provided in the issue as the upper bound is pointing to the next day.  Format following these changes:   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e510e53)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 2, 2025
…n values (#216142) (#216755) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Anomalies table: Enhances display for anomaly time function values (#216142)](#216142) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-02T07:59:30Z","message":"[ML] Anomalies table: Enhances display for anomaly time function values (#216142)\n\nIntroducing tooltips and `+1` / `-1` subscripts for date values to\nimprove readability for the values of `time_of_day` anomaly detection\nfunction.\n\nFix for: https://github.com/elastic/kibana/issues/213882\nIt turns out the formatting was correct for the screenshot provided in\nthe issue as the upper bound is pointing to the next day.\n\n\n\n\nFormat following these changes:\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e510e533a4bc7f701467e34131064aaa207133ab","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Anomaly Detection","Team:ML","backport:version","v9.1.0","v8.19.0"],"title":"[ML] Anomalies table: Enhances display for anomaly time function values","number":216142,"url":"https://github.com/elastic/kibana/pull/216142","mergeCommit":{"message":"[ML] Anomalies table: Enhances display for anomaly time function values (#216142)\n\nIntroducing tooltips and `+1` / `-1` subscripts for date values to\nimprove readability for the values of `time_of_day` anomaly detection\nfunction.\n\nFix for: https://github.com/elastic/kibana/issues/213882\nIt turns out the formatting was correct for the screenshot provided in\nthe issue as the upper bound is pointing to the next day.\n\n\n\n\nFormat following these changes:\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e510e533a4bc7f701467e34131064aaa207133ab"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216142","number":216142,"mergeCommit":{"message":"[ML] Anomalies table: Enhances display for anomaly time function values (#216142)\n\nIntroducing tooltips and `+1` / `-1` subscripts for date values to\nimprove readability for the values of `time_of_day` anomaly detection\nfunction.\n\nFix for: https://github.com/elastic/kibana/issues/213882\nIt turns out the formatting was correct for the screenshot provided in\nthe issue as the upper bound is pointing to the next day.\n\n\n\n\nFormat following these changes:\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e510e533a4bc7f701467e34131064aaa207133ab"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing tooltips and
+1/-1subscripts for date values to improve readability for the values oftime_of_dayanomaly detection function.Fix for: #213882
It turns out the formatting was correct for the screenshot provided in the issue as the upper bound is pointing to the next day.
Format following these changes:
