Skip to content

Audit info and error logs in observability plugin #216111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryam-saeidi merged 3 commits into from
Mar 27, 2025
Merged

Audit info and error logs in observability plugin #216111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85b921e
Audit info and error logs in observability plugin
maryam-saeidi Mar 25, 2025
7c11f0a
Merge branch 'main' into audit-observability-log-level
maryam-saeidi Mar 27, 2025
d281b6b
Audit warning logs
maryam-saeidi Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...ns/observability/plugins/observability/server/lib/annotations/register_annotation_apis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,19 @@ export function registerAnnotationAPIs({
return response.ok({
body: res,
});
} catch (err) {
logger.error(err);
} catch (error) {
const statusCode = error.output?.statusCode ?? 500;
const errorMessage = error.output?.payload?.message ?? 'An internal server error occurred';
if (statusCode >= 500) {
logger.error(errorMessage, { error });
} else {
logger.debug(errorMessage, { error });
}

return response.custom({
statusCode: err.output?.statusCode ?? 500,
statusCode,
body: {
message: err.output?.payload?.message ?? 'An internal server error occurred',
message: errorMessage,
},
});
}
Expand Down
4 changes: 2 additions & 2 deletions ...olutions/observability/plugins/observability/server/services/related_dashboards_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class RelatedDashboardsClient {
const panels = d.attributes.panels;
const matchingPanels = this.getPanelsByIndex(index, panels);
if (matchingPanels.length > 0) {
this.logger.info(
this.logger.debug(
() => `Found ${matchingPanels.length} panel(s) in dashboard ${d.id} using index ${index}`
);
relevantDashboards.push({
Expand Down Expand Up @@ -151,7 +151,7 @@ export class RelatedDashboardsClient {
matchingPanels.map((p) => Array.from(p.matchingFields)).flat()
);
if (matchingPanels.length > 0) {
this.logger.info(
this.logger.debug(
() =>
`Found ${matchingPanels.length} panel(s) in dashboard ${
d.id
Expand Down
3 changes: 1 addition & 2 deletions x-pack/solutions/observability/plugins/observability/server/utils/create_or_update_index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ export async function createOrUpdateIndex({
},
{
onFailedAttempt: (e) => {
logger.warn(`Could not create index: '${index}'. Retrying...`);
logger.warn(e);
logger.warn(`Could not create index: '${index}'. Retrying...`, { error: e });
},
}
);
Expand Down
9 changes: 6 additions & 3 deletions ...tions/observability/plugins/observability/server/utils/create_or_update_index_template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,15 @@ export async function createOrUpdateIndexTemplate({
},
{
onFailedAttempt: (e) => {
logger.warn(`Could not create index template: '${indexTemplate.name}'. Retrying...`);
logger.warn(e);
logger.warn(`Could not create index template: '${indexTemplate.name}'. Retrying...`, {
error: e,
});
},
}
);
} catch (e) {
logger.error(`Could not create index template: '${indexTemplate.name}'. Error: ${e.message}.`);
logger.error(`Could not create index template: '${indexTemplate.name}'. Error: ${e.message}.`, {
error: e,
});
}
}