[ES|QL] Move to query locations#216110
Merged
drewdaemon merged 21 commits intoelastic:mainfrom Mar 27, 2025
Merged
Conversation
drewdaemon
changed the title
drewdaemon
added
v9.1.0
v8.19.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Mar 27, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
A gain in readability, LGTM, code review only
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14100472994 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
added a commit
to drewdaemon/kibana
that referenced
this pull request
Mar 27, 2025
This PR replaces `FunctionDefinition.supportedCommands` and `FunctionDefinition.supportedOptions` with `FunctionDefinition.locationsAvailable`. This will still allow us fine-grained control over where functions are suggested and allows in various contexts but it is extensible to any scenario—no longer confined to rigid lists of "option" and command names. Prerequisite to elastic#209359 (cherry picked from commit 8e6428b)
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
stratoula
added a commit
that referenced
this pull request
Mar 31, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Move to query locations (#216110)](#216110) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-03-27T06:41:50Z","message":"[ES|QL] Move to query locations (#216110)\n\n## Summary\n\nThis PR replaces `FunctionDefinition.supportedCommands` and\n`FunctionDefinition.supportedOptions` with\n`FunctionDefinition.locationsAvailable`.\n\nThis will still allow us fine-grained control over where functions are\nsuggested and allows in various contexts but it is extensible to any\nscenario—no longer confined to rigid lists of \"option\" and command\nnames.\n\nPrerequisite to https://github.com/elastic/kibana/issues/209359","sha":"8e6428b452b67486bade7d74e38ea37295aa6deb","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Move to query locations","number":216110,"url":"https://github.com/elastic/kibana/pull/216110","mergeCommit":{"message":"[ES|QL] Move to query locations (#216110)\n\n## Summary\n\nThis PR replaces `FunctionDefinition.supportedCommands` and\n`FunctionDefinition.supportedOptions` with\n`FunctionDefinition.locationsAvailable`.\n\nThis will still allow us fine-grained control over where functions are\nsuggested and allows in various contexts but it is extensible to any\nscenario—no longer confined to rigid lists of \"option\" and command\nnames.\n\nPrerequisite to https://github.com/elastic/kibana/issues/209359","sha":"8e6428b452b67486bade7d74e38ea37295aa6deb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216110","number":216110,"mergeCommit":{"message":"[ES|QL] Move to query locations (#216110)\n\n## Summary\n\nThis PR replaces `FunctionDefinition.supportedCommands` and\n`FunctionDefinition.supportedOptions` with\n`FunctionDefinition.locationsAvailable`.\n\nThis will still allow us fine-grained control over where functions are\nsuggested and allows in various contexts but it is extensible to any\nscenario—no longer confined to rigid lists of \"option\" and command\nnames.\n\nPrerequisite to https://github.com/elastic/kibana/issues/209359","sha":"8e6428b452b67486bade7d74e38ea37295aa6deb"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
kibanamachine
removed
the
backport missing
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
## Summary This PR replaces `FunctionDefinition.supportedCommands` and `FunctionDefinition.supportedOptions` with `FunctionDefinition.locationsAvailable`. This will still allow us fine-grained control over where functions are suggested and allows in various contexts but it is extensible to any scenario—no longer confined to rigid lists of "option" and command names. Prerequisite to elastic#209359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
FunctionDefinition.supportedCommandsandFunctionDefinition.supportedOptionswithFunctionDefinition.locationsAvailable.This will still allow us fine-grained control over where functions are suggested and allows in various contexts but it is extensible to any scenario—no longer confined to rigid lists of "option" and command names.
Prerequisite to #209359