[Fleet] Keep the query params returnAppId and returnPath when switching tabs the integration details page#216094
Merged
kgeller merged 2 commits intoelastic:mainfrom Mar 27, 2025
Merged
Conversation
kgeller
added
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @kgeller |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…tching tabs the integration details page (elastic#216094) ## Summary Updates so that `returnAppId` and `returnPath` are maintained when the user switches tabs on the Integrations details page. ## Details We currently have custom logic so that callers of the integrations cards can customize the destinations of the back, cancel and save buttons. This fixes that flow so that that customization is kept if the user switches tabs. Followup to elastic#215561 ## Screen recordings https://github.com/user-attachments/assets/016ae86a-9d2f-434f-88cc-f34aeff9e14d Relates - elastic/security-team#11789
angorayc
pushed a commit
to angorayc/kibana
that referenced
this pull request
May 29, 2025
…tching tabs the integration details page (elastic#216094) ## Summary Updates so that `returnAppId` and `returnPath` are maintained when the user switches tabs on the Integrations details page. ## Details We currently have custom logic so that callers of the integrations cards can customize the destinations of the back, cancel and save buttons. This fixes that flow so that that customization is kept if the user switches tabs. Followup to elastic#215561 ## Screen recordings https://github.com/user-attachments/assets/016ae86a-9d2f-434f-88cc-f34aeff9e14d Relates - elastic/security-team#11789 (cherry picked from commit e5b81ac)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
angorayc
added
backport:version
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15322288302 |
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15322288342 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 29, 2025
…tching tabs the integration details page (elastic#216094) ## Summary Updates so that `returnAppId` and `returnPath` are maintained when the user switches tabs on the Integrations details page. ## Details We currently have custom logic so that callers of the integrations cards can customize the destinations of the back, cancel and save buttons. This fixes that flow so that that customization is kept if the user switches tabs. Followup to elastic#215561 ## Screen recordings https://github.com/user-attachments/assets/016ae86a-9d2f-434f-88cc-f34aeff9e14d Relates - elastic/security-team#11789 (cherry picked from commit e5b81ac)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 29, 2025
…hen switching tabs the integration details page (#216094) (#221915) # Backport This will backport the following commits from `main` to `8.19`: - [[Fleet] Keep the query params `returnAppId` and `returnPath` when switching tabs the integration details page (#216094)](#216094) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kylie Meli","email":"kylie.geller@elastic.co"},"sourceCommit":{"committedDate":"2025-03-27T15:26:53Z","message":"[Fleet] Keep the query params `returnAppId` and `returnPath` when switching tabs the integration details page (#216094)\n\n## Summary\n\nUpdates so that `returnAppId` and `returnPath` are maintained when the\nuser switches tabs on the Integrations details page.\n\n## Details\n\nWe currently have custom logic so that callers of the integrations cards\ncan customize the destinations of the back, cancel and save buttons.\nThis fixes that flow so that that customization is kept if the user\nswitches tabs.\n\nFollowup to https://github.com/elastic/kibana/pull/215561\n\n## Screen recordings\n\n\nhttps://github.com/user-attachments/assets/016ae86a-9d2f-434f-88cc-f34aeff9e14d\n\nRelates\n- https://github.com/elastic/security-team/issues/11789","sha":"e5b81ace3f83d8bc1a613eae241f41633de79337","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:version","v9.1.0","v8.19.0"],"title":"[Fleet] Keep the query params `returnAppId` and `returnPath` when switching tabs the integration details page","number":216094,"url":"https://github.com/elastic/kibana/pull/216094","mergeCommit":{"message":"[Fleet] Keep the query params `returnAppId` and `returnPath` when switching tabs the integration details page (#216094)\n\n## Summary\n\nUpdates so that `returnAppId` and `returnPath` are maintained when the\nuser switches tabs on the Integrations details page.\n\n## Details\n\nWe currently have custom logic so that callers of the integrations cards\ncan customize the destinations of the back, cancel and save buttons.\nThis fixes that flow so that that customization is kept if the user\nswitches tabs.\n\nFollowup to https://github.com/elastic/kibana/pull/215561\n\n## Screen recordings\n\n\nhttps://github.com/user-attachments/assets/016ae86a-9d2f-434f-88cc-f34aeff9e14d\n\nRelates\n- https://github.com/elastic/security-team/issues/11789","sha":"e5b81ace3f83d8bc1a613eae241f41633de79337"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216094","number":216094,"mergeCommit":{"message":"[Fleet] Keep the query params `returnAppId` and `returnPath` when switching tabs the integration details page (#216094)\n\n## Summary\n\nUpdates so that `returnAppId` and `returnPath` are maintained when the\nuser switches tabs on the Integrations details page.\n\n## Details\n\nWe currently have custom logic so that callers of the integrations cards\ncan customize the destinations of the back, cancel and save buttons.\nThis fixes that flow so that that customization is kept if the user\nswitches tabs.\n\nFollowup to https://github.com/elastic/kibana/pull/215561\n\n## Screen recordings\n\n\nhttps://github.com/user-attachments/assets/016ae86a-9d2f-434f-88cc-f34aeff9e14d\n\nRelates\n- https://github.com/elastic/security-team/issues/11789","sha":"e5b81ace3f83d8bc1a613eae241f41633de79337"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/221911","number":221911,"branch":"8.19","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Kylie Meli <kylie.geller@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates so that
returnAppIdandreturnPathare maintained when the user switches tabs on the Integrations details page.Details
We currently have custom logic so that callers of the integrations cards can customize the destinations of the back, cancel and save buttons. This fixes that flow so that that customization is kept if the user switches tabs.
Followup to #215561
Screen recordings
Screen.Recording.2025-03-26.at.2.11.57.PM.mov
Relates