Skip to content

[SharedUX] SCSS migration share plugin#216078

Merged
paulinashakirova merged 4 commits into
elastic:mainfrom
paulinashakirova:scss-migration-shared-plugin
Apr 7, 2025
Merged

[SharedUX] SCSS migration share plugin#216078
paulinashakirova merged 4 commits into
elastic:mainfrom
paulinashakirova:scss-migration-shared-plugin

Conversation

@paulinashakirova
Copy link
Copy Markdown
Contributor

@paulinashakirova paulinashakirova commented Mar 26, 2025

Summary

This PR is a part of SCSS migration of SharedUX team code.
Here is a meta issue for it.

@paulinashakirova paulinashakirova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Mar 26, 2025
@paulinashakirova paulinashakirova self-assigned this Mar 26, 2025
@paulinashakirova paulinashakirova changed the title [SharedUX] SCSS migration shared plugin [SharedUX] SCSS migration share plugin Mar 26, 2025
@paulinashakirova paulinashakirova marked this pull request as ready for review March 28, 2025 09:24
@paulinashakirova paulinashakirova requested review from a team as code owners March 28, 2025 09:24
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 28, 2025

Pinging @elastic/appex-sharedux (Team:SharedUX)

@paulinashakirova paulinashakirova marked this pull request as draft March 28, 2025 12:18
@paulinashakirova paulinashakirova marked this pull request as ready for review April 2, 2025 19:33
eokoneyo
eokoneyo approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code changes LGTM.
Screenshot 2025-04-04 at 09 45 24

@paulinashakirova paulinashakirova requested a review from a team as a code owner April 7, 2025 10:03
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 7, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 85 72 -13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 52.6KB 52.6KB +15.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 58.9KB 54.4KB -4.5KB

History

cc @paulinashakirova

@paulinashakirova paulinashakirova merged commit bb748ee into elastic:main Apr 7, 2025
@paulinashakirova paulinashakirova deleted the scss-migration-shared-plugin branch April 7, 2025 15:05
baileycash-elastic pushed a commit to baileycash-elastic/kibana that referenced this pull request Apr 7, 2025
@paulinashakirova @baileycash-elastic
[SharedUX] SCSS migration share plugin (elastic#216078)
968c0e7 
## Summary

This PR is a part of SCSS migration of SharedUX team code.
Here is a [meta](elastic/kibana-team#1417)
issue for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@cnasikas cnasikas cnasikas approved these changes

@eokoneyo eokoneyo eokoneyo approved these changes

Assignees

@paulinashakirova paulinashakirova

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes scss-removal Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@paulinashakirova @elasticmachine @ryankeairns @cnasikas @eokoneyo @tsullivan @kibanamachine