[Custom threshold rule] Allow group for ip type fields !!#216062
Merged
shahzad31 merged 6 commits intoelastic:mainfrom Apr 15, 2025
Merged
[Custom threshold rule] Allow group for ip type fields !!#216062shahzad31 merged 6 commits intoelastic:mainfrom
shahzad31 merged 6 commits intoelastic:mainfrom
Conversation
Allow group by for ip fields !!
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
shahzad31
added
release_note:fix
backport:all-open
shahzad31
commented
Mar 26, 2025
...servability/plugins/observability/public/components/custom_threshold/components/group_by.tsx
Outdated
Show resolved
Hide resolved
…mponents/custom_threshold/components/group_by.tsx
fkanout
approved these changes
Apr 7, 2025
Contributor
fkanout
left a comment
fkanout
left a comment
There was a problem hiding this comment.
Tested it and works as expected
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14476498142 |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2025
) (#218338) # Backport This will backport the following commits from `main` to `9.0`: - [[Custom threshold rule] Allow group for ip type fields !! (#216062)](#216062) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T18:15:02Z","message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold rule] Allow group for ip type fields !!","number":216062,"url":"https://github.com/elastic/kibana/pull/216062","mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216062","number":216062,"mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
1 task
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2025
) (#218337) # Backport This will backport the following commits from `main` to `8.x`: - [[Custom threshold rule] Allow group for ip type fields !! (#216062)](#216062) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T18:15:02Z","message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold rule] Allow group for ip type fields !!","number":216062,"url":"https://github.com/elastic/kibana/pull/216062","mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216062","number":216062,"mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2025
…6062) (#218334) # Backport This will backport the following commits from `main` to `8.16`: - [[Custom threshold rule] Allow group for ip type fields !! (#216062)](#216062) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T18:15:02Z","message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold rule] Allow group for ip type fields !!","number":216062,"url":"https://github.com/elastic/kibana/pull/216062","mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216062","number":216062,"mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2025
…6062) (#218335) # Backport This will backport the following commits from `main` to `8.17`: - [[Custom threshold rule] Allow group for ip type fields !! (#216062)](#216062) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T18:15:02Z","message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold rule] Allow group for ip type fields !!","number":216062,"url":"https://github.com/elastic/kibana/pull/216062","mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216062","number":216062,"mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Apr 17, 2025
…6062) (#218336) # Backport This will backport the following commits from `main` to `8.18`: - [[Custom threshold rule] Allow group for ip type fields !! (#216062)](#216062) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T18:15:02Z","message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold rule] Allow group for ip type fields !!","number":216062,"url":"https://github.com/elastic/kibana/pull/216062","mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216062","number":216062,"mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 17, 2025
…6062) (#218332) # Backport This will backport the following commits from `main` to `7.17`: - [[Custom threshold rule] Allow group for ip type fields !! (#216062)](#216062) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T18:15:02Z","message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-management","v9.1.0"],"title":"[Custom threshold rule] Allow group for ip type fields !!","number":216062,"url":"https://github.com/elastic/kibana/pull/216062","mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216062","number":216062,"mergeCommit":{"message":"[Custom threshold rule] Allow group for ip type fields !! (#216062)\n\nAllow group by for ip fields !!\n\n---------\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83f3d614ccb66bca3aa626a6db39c0f41eb1a9f1"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added
v7.17.29
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow group by for ip fields !!