[Synthetics] Added task to sync global parameters when they are added, edited or deleted#216015
Merged
cesco-f merged 15 commits intoelastic:mainfrom May 22, 2025
Merged
[Synthetics] Added task to sync global parameters when they are added, edited or deleted#216015cesco-f merged 15 commits intoelastic:mainfrom
cesco-f merged 15 commits intoelastic:mainfrom
Conversation
cesco-f
added
backport:version
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
cesco-f
force-pushed
the
sync-params
branch
4 times, most recently
from
3c5b42b to
e3e6ce4
Compare
cesco-f
force-pushed
the
sync-params
branch
2 times, most recently
from
3d870cb to
7a1813e
Compare
shahzad31
reviewed
Apr 28, 2025
x-pack/test/plugin_api_integration/test_suites/task_manager/check_registered_task_types.ts
Outdated
Show resolved
Hide resolved
shahzad31
reviewed
Apr 28, 2025
...utions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.ts
Outdated
Show resolved
Hide resolved
shahzad31
reviewed
Apr 28, 2025
...utions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.ts
Outdated
Show resolved
Hide resolved
kdelemme
reviewed
Apr 28, 2025
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
I have a question about the need for scheduled interval vs ad-hoc scheduling of the task, but otherwise LGTM.
Just one comment about the lastStartedAt state set in case of error
...utions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.ts
Show resolved
Hide resolved
...utions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.ts
Show resolved
Hide resolved
pmuellr
approved these changes
Apr 28, 2025
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
No blockers, but left some comments that would probably be useful to address.
Just so I understand, there will only ever be one task created, which will - based on other activity - be run with runSoon(). And otherwise will be on a 10m interval.
...utions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.ts
Outdated
Show resolved
Hide resolved
...utions/observability/plugins/synthetics/server/tasks/sync_private_locations_monitors_task.ts
Show resolved
Hide resolved
shahzad31
reviewed
Apr 30, 2025
...k/solutions/observability/plugins/synthetics/server/synthetics_service/synthetics_service.ts
Outdated
Show resolved
Hide resolved
cesco-f
force-pushed
the
sync-params
branch
2 times, most recently
from
74bff86 to
18da351
Compare
…eck_registered_task_types.ts
…/sync_private_locations_monitors_task.ts
…/sync_private_locations_monitors_task.ts
also improved TS
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15182080803 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
cesco-f
added a commit
to cesco-f/kibana
that referenced
this pull request
May 22, 2025
…, edited or deleted (elastic#216015) This will improve PR elastic#216197. A new task is created using the task manager every time a global parameter is created, edited or deleted. When params is updated/remove/added it will sync task soon, and task also continue to run every 10 minutes. ### Execution In the task we check if params have been changed since last run or param total have changes since last run, in that case we sync private locations data with package polices ## Testing Add few browser synthetics monitors in a test private location Add/Update or delete a param , make sure relevant agent policy is updated with params. Go to fleet agent policy, view agent policy yaml and notice params field for a browser monitor in yaml. --------- Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 0a838e4) # Conflicts: # x-pack/solutions/observability/plugins/synthetics/server/routes/settings/sync_global_params.ts # x-pack/solutions/observability/plugins/synthetics/server/synthetics_service/sync_global_params.ts # x-pack/solutions/observability/plugins/synthetics/server/synthetics_service/synthetics_monitor/synthetics_monitor_client.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cesco-f
added a commit
to cesco-f/kibana
that referenced
this pull request
May 22, 2025
…, edited or deleted (elastic#216015) This will improve PR elastic#216197. A new task is created using the task manager every time a global parameter is created, edited or deleted. When params is updated/remove/added it will sync task soon, and task also continue to run every 10 minutes. In the task we check if params have been changed since last run or param total have changes since last run, in that case we sync private locations data with package polices Add few browser synthetics monitors in a test private location Add/Update or delete a param , make sure relevant agent policy is updated with params. Go to fleet agent policy, view agent policy yaml and notice params field for a browser monitor in yaml. --------- Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 0a838e4)
cesco-f
added a commit
to cesco-f/kibana
that referenced
this pull request
May 22, 2025
…, edited or deleted (elastic#216015) This will improve PR elastic#216197. A new task is created using the task manager every time a global parameter is created, edited or deleted. When params is updated/remove/added it will sync task soon, and task also continue to run every 10 minutes. In the task we check if params have been changed since last run or param total have changes since last run, in that case we sync private locations data with package polices Add few browser synthetics monitors in a test private location Add/Update or delete a param , make sure relevant agent policy is updated with params. Go to fleet agent policy, view agent policy yaml and notice params field for a browser monitor in yaml. --------- Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 0a838e4)
cesco-f
added a commit
to cesco-f/kibana
that referenced
this pull request
May 22, 2025
…, edited or deleted (elastic#216015) This will improve PR elastic#216197. A new task is created using the task manager every time a global parameter is created, edited or deleted. When params is updated/remove/added it will sync task soon, and task also continue to run every 10 minutes. In the task we check if params have been changed since last run or param total have changes since last run, in that case we sync private locations data with package polices Add few browser synthetics monitors in a test private location Add/Update or delete a param , make sure relevant agent policy is updated with params. Go to fleet agent policy, view agent policy yaml and notice params field for a browser monitor in yaml. --------- Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit 0a838e4)
cesco-f
added a commit
that referenced
this pull request
May 23, 2025
…e added, edited or deleted (#216015) (#221243) # Backport This will backport the following commits from `main` to `8.19`: - [[Synthetics] Added task to sync global parameters when they are added, edited or deleted (#216015)](#216015) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-05-22T08:43:57Z","message":"[Synthetics] Added task to sync global parameters when they are added, edited or deleted (#216015)\n\nThis will improve PR #216197.\n\nA new task is created using the task manager every time a global\nparameter is created, edited or deleted.\n\nWhen params is updated/remove/added it will sync task soon, and task\nalso continue to run every 10 minutes.\n\n\n### Execution\n\nIn the task we check if params have been changed since last run or param\ntotal have changes since last run, in that case we sync private\nlocations data with package polices\n\n## Testing\n\nAdd few browser synthetics monitors in a test private location\n\nAdd/Update or delete a param , make sure relevant agent policy is\nupdated with params. Go to fleet agent policy, view agent policy yaml\nand notice params field for a browser monitor in yaml.\n\n---------\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"0a838e43883e83a42defc4f5840829c10223f820","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Synthetics] Added task to sync global parameters when they are added, edited or deleted","number":216015,"url":"https://github.com/elastic/kibana/pull/216015","mergeCommit":{"message":"[Synthetics] Added task to sync global parameters when they are added, edited or deleted (#216015)\n\nThis will improve PR #216197.\n\nA new task is created using the task manager every time a global\nparameter is created, edited or deleted.\n\nWhen params is updated/remove/added it will sync task soon, and task\nalso continue to run every 10 minutes.\n\n\n### Execution\n\nIn the task we check if params have been changed since last run or param\ntotal have changes since last run, in that case we sync private\nlocations data with package polices\n\n## Testing\n\nAdd few browser synthetics monitors in a test private location\n\nAdd/Update or delete a param , make sure relevant agent policy is\nupdated with params. Go to fleet agent policy, view agent policy yaml\nand notice params field for a browser monitor in yaml.\n\n---------\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"0a838e43883e83a42defc4f5840829c10223f820"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216015","number":216015,"mergeCommit":{"message":"[Synthetics] Added task to sync global parameters when they are added, edited or deleted (#216015)\n\nThis will improve PR #216197.\n\nA new task is created using the task manager every time a global\nparameter is created, edited or deleted.\n\nWhen params is updated/remove/added it will sync task soon, and task\nalso continue to run every 10 minutes.\n\n\n### Execution\n\nIn the task we check if params have been changed since last run or param\ntotal have changes since last run, in that case we sync private\nlocations data with package polices\n\n## Testing\n\nAdd few browser synthetics monitors in a test private location\n\nAdd/Update or delete a param , make sure relevant agent policy is\nupdated with params. Go to fleet agent policy, view agent policy yaml\nand notice params field for a browser monitor in yaml.\n\n---------\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>","sha":"0a838e43883e83a42defc4f5840829c10223f820"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…, edited or deleted (elastic#216015) This will improve PR elastic#216197. A new task is created using the task manager every time a global parameter is created, edited or deleted. When params is updated/remove/added it will sync task soon, and task also continue to run every 10 minutes. ### Execution In the task we check if params have been changed since last run or param total have changes since last run, in that case we sync private locations data with package polices ## Testing Add few browser synthetics monitors in a test private location Add/Update or delete a param , make sure relevant agent policy is updated with params. Go to fleet agent policy, view agent policy yaml and notice params field for a browser monitor in yaml. --------- Co-authored-by: Shahzad <shahzad31comp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will improve PR #216197.
A new task is created using the task manager every time a global parameter is created, edited or deleted.
When params is updated/remove/added it will sync task soon, and task also continue to run every 10 minutes.
Execution
In the task we check if params have been changed since last run or param total have changes since last run, in that case we sync private locations data with package polices
Testing
Add few browser synthetics monitors in a test private location
Add/Update or delete a param , make sure relevant agent policy is updated with params. Go to fleet agent policy, view agent policy yaml and notice params field for a browser monitor in yaml.