Skip to content

[9.0] [Lens/SCSS] Replace scss to css-in-js for Lens codebase (#209768)#215976

Closed
nickofthyme wants to merge 1 commit intoelastic:9.0from
nickofthyme:backport/9.0/pr-209768
Closed

[9.0] [Lens/SCSS] Replace scss to css-in-js for Lens codebase (#209768)#215976
nickofthyme wants to merge 1 commit intoelastic:9.0from
nickofthyme:backport/9.0/pr-209768

Conversation

@nickofthyme
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

Replace SCSS in css-in-js for Lens codebase

(cherry picked from commit de52f41)

# Conflicts:
#	x-pack/platform/plugins/shared/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss
#	x-pack/platform/plugins/shared/lens/public/visualization_container.scss
#	x-pack/platform/plugins/shared/lens/public/visualizations/xy/xy_config_panel/axis_settings_popover.tsx
@nickofthyme nickofthyme added the backport This PR is a backport of another PR label Mar 26, 2025
@nickofthyme nickofthyme enabled auto-merge (squash) March 26, 2025 02:09
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1585 1414 -171

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotationListing 206.4KB 206.5KB +89.0B
lens 1.5MB 1.4MB -85.4KB
total -85.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 49.7KB 49.5KB -156.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
lens 22 23 +1

Total ESLint disabled count

id before after diff
lens 22 23 +1

@nickofthyme nickofthyme added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Mar 27, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge this on 9.0

auto-merge was automatically disabled March 27, 2025 14:47

Pull request was closed

@nickofthyme nickofthyme deleted the backport/9.0/pr-209768 branch July 30, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants