[A11y][APM] Use nameTooltip api for dependencies tables#215940
Merged
rmyz merged 2 commits intoelastic:mainfrom Mar 26, 2025
Merged
[A11y][APM] Use nameTooltip api for dependencies tables#215940rmyz merged 2 commits intoelastic:mainfrom
nameTooltip api for dependencies tables#215940rmyz merged 2 commits intoelastic:mainfrom
Conversation
rmyz
added
release_note:fix
apm
backport:prev-major
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
cauemarcondes
approved these changes
Mar 25, 2025
Contributor
cauemarcondes
left a comment
cauemarcondes
left a comment
There was a problem hiding this comment.
LGTM. Could you add a video showing it working?
Contributor
Author
@cauemarcondes video added in the description |
jennypavlova
approved these changes
Mar 26, 2025
...vability/plugins/apm/public/components/shared/dependencies_table/get_span_metric_columns.tsx
Show resolved
Hide resolved
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @rmyz |
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/14083880770 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 26, 2025
…5940) ## Summary Closes elastic#195041 This PR addresses the issue where the table name's tooltip cannot be focused with keyboard. ## Video https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc (cherry picked from commit 35f8739)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 26, 2025
…5940) ## Summary Closes elastic#195041 This PR addresses the issue where the table name's tooltip cannot be focused with keyboard. ## Video https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc (cherry picked from commit 35f8739)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
rmyz
added a commit
to rmyz/kibana
that referenced
this pull request
Mar 26, 2025
…5940) ## Summary Closes elastic#195041 This PR addresses the issue where the table name's tooltip cannot be focused with keyboard. ## Video https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc (cherry picked from commit 35f8739) # Conflicts: # x-pack/plugins/observability_solution/apm/public/components/app/dependency_detail_operations/dependency_detail_operations_list/index.tsx # x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/get_span_metric_columns.tsx # x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/index.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rmyz
added a commit
to rmyz/kibana
that referenced
this pull request
Mar 26, 2025
…5940) ## Summary Closes elastic#195041 This PR addresses the issue where the table name's tooltip cannot be focused with keyboard. ## Video https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc (cherry picked from commit 35f8739) # Conflicts: # x-pack/plugins/observability_solution/apm/public/components/app/dependency_detail_operations/dependency_detail_operations_list/index.tsx # x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/get_span_metric_columns.tsx # x-pack/plugins/observability_solution/apm/public/components/shared/dependencies_table/index.tsx
rmyz
added
backport:version
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/14084470466 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 26, 2025
…5940) ## Summary Closes elastic#195041 This PR addresses the issue where the table name's tooltip cannot be focused with keyboard. ## Video https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc (cherry picked from commit 35f8739)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 26, 2025
) (#216035) # Backport This will backport the following commits from `main` to `8.x`: - [[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)](#215940) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-03-26T12:58:34Z","message":"[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the issue where the table name's tooltip cannot be\nfocused with keyboard.\n\n## Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","backport:prev-major","Team:obs-ux-infra_services","a11y","v9.1.0"],"title":"[A11y][APM] Use `nameTooltip` api for dependencies tables","number":215940,"url":"https://github.com/elastic/kibana/pull/215940","mergeCommit":{"message":"[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the issue where the table name's tooltip cannot be\nfocused with keyboard.\n\n## Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215940","number":215940,"mergeCommit":{"message":"[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the issue where the table name's tooltip cannot be\nfocused with keyboard.\n\n## Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 26, 2025
) (#216042) # Backport This will backport the following commits from `main` to `9.0`: - [[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)](#215940) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-03-26T12:58:34Z","message":"[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the issue where the table name's tooltip cannot be\nfocused with keyboard.\n\n## Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm","Team:obs-ux-infra_services","backport:version","a11y","v9.1.0"],"title":"[A11y][APM] Use `nameTooltip` api for dependencies tables","number":215940,"url":"https://github.com/elastic/kibana/pull/215940","mergeCommit":{"message":"[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the issue where the table name's tooltip cannot be\nfocused with keyboard.\n\n## Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215940","number":215940,"mergeCommit":{"message":"[A11y][APM] Use `nameTooltip` api for dependencies tables (#215940)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/195041\n\nThis PR addresses the issue where the table name's tooltip cannot be\nfocused with keyboard.\n\n## Video\n\n\nhttps://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc","sha":"35f8739b9a1a8f9bc231161afa39118f7ff4fbaa"}},{"url":"https://github.com/elastic/kibana/pull/216034","number":216034,"branch":"8.18","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/216035","number":216035,"branch":"8.x","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/216036","number":216036,"branch":"8.17","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/216038","number":216038,"branch":"8.16","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…5940) ## Summary Closes elastic#195041 This PR addresses the issue where the table name's tooltip cannot be focused with keyboard. ## Video https://github.com/user-attachments/assets/bec887fd-5a3b-4fa9-b84b-17a1a4187fbc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #195041
This PR addresses the issue where the table name's tooltip cannot be focused with keyboard.
Video
Kapture.2025-03-26.at.09.27.10.mp4