Skip to content

[Lens] Show drag and drop options in the in-line editor#215892

Merged
mariairiartef merged 2 commits intoelastic:mainfrom
mariairiartef:lens/215441
Mar 25, 2025
Merged

[Lens] Show drag and drop options in the in-line editor#215892
mariairiartef merged 2 commits intoelastic:mainfrom
mariairiartef:lens/215441

Conversation

@mariairiartef
Copy link
Contributor

@mariairiartef mariairiartef commented Mar 25, 2025

Summary

Closes #215441

Adds the euiYScroll styles only to the Lens Editor app, not to the Lens in-line editor.

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Screen recording

Screen.Recording.2025-03-25.at.15.20.12.mov

@mariairiartef mariairiartef added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Lens labels Mar 25, 2025
@mariairiartef mariairiartef self-assigned this Mar 25, 2025
@mariairiartef mariairiartef added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Mar 25, 2025
@mariairiartef mariairiartef changed the title [Lens] Show drag and drop options in in-line editor [Lens] Show drag and drop options in the in-line editor Mar 25, 2025
@mariairiartef mariairiartef marked this pull request as ready for review March 25, 2025 14:24
@mariairiartef mariairiartef requested a review from a team as a code owner March 25, 2025 14:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Issue resolved 🚢

@mariairiartef mariairiartef enabled auto-merge (squash) March 25, 2025 14:58
@mariairiartef mariairiartef merged commit f62960c into elastic:main Mar 25, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +12.0B

cc @nickofthyme @mariairiartef

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14065749796

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Lens/SCSS] Replace scss to css-in-js for Lens codebase (#209768)

Manual backport

To create the backport manually run:

node scripts/backport --pr 215892

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 27, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215892 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215892 locally

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14065749796

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 31, 2025
## Summary

Closes elastic#215441

Adds the euiYScroll styles only to the Lens Editor app, not to the Lens
in-line editor.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Screen recording

https://github.com/user-attachments/assets/3e86bcb8-f79d-4b96-91f8-e04d53a510ad
(cherry picked from commit f62960c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 31, 2025
… (#216518)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] Show drag and drop options in the in-line editor
(#215892)](#215892)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Maria
Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-25T17:04:09Z","message":"[Lens]
Show drag and drop options in the in-line editor (#215892)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/215441\n\nAdds the euiYScroll
styles only to the Lens Editor app, not to the Lens\nin-line
editor.\n\n### Checklist\n\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Screen
recording\n\n\nhttps://github.com/user-attachments/assets/3e86bcb8-f79d-4b96-91f8-e04d53a510ad","sha":"f62960c1d872e7dffef0a64ef94f3b3470b4b158","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport
missing","backport:version","v9.1.0","v8.19.0"],"title":"[Lens] Show
drag and drop options in the in-line
editor","number":215892,"url":"https://github.com/elastic/kibana/pull/215892","mergeCommit":{"message":"[Lens]
Show drag and drop options in the in-line editor (#215892)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/215441\n\nAdds the euiYScroll
styles only to the Lens Editor app, not to the Lens\nin-line
editor.\n\n### Checklist\n\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Screen
recording\n\n\nhttps://github.com/user-attachments/assets/3e86bcb8-f79d-4b96-91f8-e04d53a510ad","sha":"f62960c1d872e7dffef0a64ef94f3b3470b4b158"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215892","number":215892,"mergeCommit":{"message":"[Lens]
Show drag and drop options in the in-line editor (#215892)\n\n##
Summary\n\nCloses
https://github.com/elastic/kibana/issues/215441\n\nAdds the euiYScroll
styles only to the Lens Editor app, not to the Lens\nin-line
editor.\n\n### Checklist\n\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Screen
recording\n\n\nhttps://github.com/user-attachments/assets/3e86bcb8-f79d-4b96-91f8-e04d53a510ad","sha":"f62960c1d872e7dffef0a64ef94f3b3470b4b158"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2025
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
## Summary

Closes elastic#215441

Adds the euiYScroll styles only to the Lens Editor app, not to the Lens
in-line editor.

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Screen recording


https://github.com/user-attachments/assets/3e86bcb8-f79d-4b96-91f8-e04d53a510ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Lens] Inline editing drag and drop options are hidden

4 participants