[ES|QL] Add Builder and parser support for function map expressions#215862
Merged
vadimkibana merged 3 commits intoelastic:mainfrom Mar 26, 2025
Merged
[ES|QL] Add Builder and parser support for function map expressions#215862vadimkibana merged 3 commits intoelastic:mainfrom
Builder and parser support for function map expressions#215862vadimkibana merged 3 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI StepsHistory |
Contributor
Author
|
/ci |
vadimkibana
added
review
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14083571668 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 26, 2025
…elastic#215862) ## Summary Closes elastic#214361 ES|QL function can have a last optional argument which is a map of values. This PR adds parsing support for this syntax: ``` FN(1, 2, 3, { "this" : "is", "a": "map" }) ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 404de07)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Mar 26, 2025
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Mar 28, 2025
…ssions (#215862) (#216030) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Add `Builder` and parser support for function map expressions (#215862)](#215862) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Vadim Kibana","email":"82822460+vadimkibana@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-26T12:43:24Z","message":"[ES|QL] Add `Builder` and parser support for function map expressions (#215862)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/214361\n\nES|QL function can have a last optional argument which is a map of\nvalues. This PR adds parsing support for this syntax:\n\n```\nFN(1, 2, 3, { \"this\" : \"is\", \"a\": \"map\" })\n```\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"404de07e4ad9a1af1ad164187ff1fd41006c89fe","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Add `Builder` and parser support for function map expressions","number":215862,"url":"https://github.com/elastic/kibana/pull/215862","mergeCommit":{"message":"[ES|QL] Add `Builder` and parser support for function map expressions (#215862)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/214361\n\nES|QL function can have a last optional argument which is a map of\nvalues. This PR adds parsing support for this syntax:\n\n```\nFN(1, 2, 3, { \"this\" : \"is\", \"a\": \"map\" })\n```\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"404de07e4ad9a1af1ad164187ff1fd41006c89fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215862","number":215862,"mergeCommit":{"message":"[ES|QL] Add `Builder` and parser support for function map expressions (#215862)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/214361\n\nES|QL function can have a last optional argument which is a map of\nvalues. This PR adds parsing support for this syntax:\n\n```\nFN(1, 2, 3, { \"this\" : \"is\", \"a\": \"map\" })\n```\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"404de07e4ad9a1af1ad164187ff1fd41006c89fe"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
kibanamachine
removed
the
backport missing
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…elastic#215862) ## Summary Closes elastic#214361 ES|QL function can have a last optional argument which is a map of values. This PR adds parsing support for this syntax: ``` FN(1, 2, 3, { "this" : "is", "a": "map" }) ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #214361
ES|QL function can have a last optional argument which is a map of values. This PR adds parsing support for this syntax:
Checklist