Skip to content
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
afffcdb
progress
shahzad31 Mar 24, 2025
9c364ec
update types
shahzad31 Mar 24, 2025
7f6b28a
handle openc ase
shahzad31 Mar 24, 2025
76e89e4
handle context
shahzad31 Mar 25, 2025
835fb7a
Merge branch 'main' of https://github.com/elastic/kibana into related…
shahzad31 Mar 25, 2025
3fa36d1
wip
shahzad31 Mar 25, 2025
397c40a
Merge branch 'main' of https://github.com/elastic/kibana into related…
shahzad31 Mar 25, 2025
c36cc91
handle table
shahzad31 Mar 25, 2025
43d9cf8
fix types
shahzad31 Mar 25, 2025
55366c2
revert
shahzad31 Mar 25, 2025
791786a
Merge branch 'main' of https://github.com/elastic/kibana into related…
shahzad31 Mar 25, 2025
db8c604
revert
shahzad31 Mar 25, 2025
d581f06
handle types
shahzad31 Mar 25, 2025
f27c5d2
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine Mar 25, 2025
a7763a1
Merge branch 'main' of https://github.com/elastic/kibana into related…
shahzad31 Mar 26, 2025
b478b59
remove unused
shahzad31 Mar 26, 2025
ab3c789
Merge branch 'main' of https://github.com/elastic/kibana into related…
shahzad31 Mar 26, 2025
ba24dd7
fix jest tests
shahzad31 Mar 26, 2025
bcd3383
fix more jest tests
shahzad31 Mar 26, 2025
0890214
fix more jest tests
shahzad31 Mar 26, 2025
afedc39
Merge branch 'main' of https://github.com/elastic/kibana into related…
shahzad31 Mar 27, 2025
b20da11
fix tests
shahzad31 Mar 27, 2025
4690950
fix tests
shahzad31 Mar 27, 2025
a211f95
PR feedback
shahzad31 Mar 28, 2025
626923e
Merge branch 'main' into related-alerts
shahzad31 Mar 28, 2025
de7946d
Merge branch 'main' into related-alerts
shahzad31 Mar 28, 2025
ea56aca
Merge branch 'main' into related-alerts
dominiqueclarke Mar 31, 2025
4f36da8
add unit test
dominiqueclarke Apr 1, 2025
a0c45c6
add integration test
dominiqueclarke Apr 1, 2025
1c3de19
adjust types
dominiqueclarke Apr 2, 2025
a647a90
Merge branch 'main' into related-alerts
dominiqueclarke Apr 2, 2025
a559fc1
Merge branch 'main' of https://github.com/elastic/kibana into pr/shah…
dominiqueclarke Apr 3, 2025
4ad695c
remove sort fields control
dominiqueclarke Apr 3, 2025
d303220
Merge branch 'related-alerts' of https://github.com/shahzad31/kibana …
dominiqueclarke Apr 3, 2025
fa11357
adjust sort order
dominiqueclarke Apr 3, 2025
c447232
add ability to track scores when using field sorts
dominiqueclarke Apr 7, 2025
32ec62b
adjust copy
dominiqueclarke Apr 7, 2025
5103880
Merge branch 'main' of https://github.com/elastic/kibana into pr/shah…
dominiqueclarke Apr 7, 2025
1723ed3
Ensure individual score results is greater than 0
kdelemme Apr 8, 2025
831b9e7
adjust trackScores and add a test
dominiqueclarke Apr 9, 2025
d341b70
adjust sizing of actions column and prevent sorting actions on indivi…
dominiqueclarke Apr 9, 2025
f27601b
adjust types
dominiqueclarke Apr 9, 2025
ea688d6
Merge branch 'main' into related-alerts
dominiqueclarke Apr 9, 2025
e0f6dab
adjust types
dominiqueclarke Apr 9, 2025
22c4f92
Merge branch 'main' into related-alerts
dominiqueclarke Apr 10, 2025
e53e193
Merge branch 'main' of https://github.com/elastic/kibana into pr/shah…
dominiqueclarke Apr 10, 2025
0641f85
adjust css for alert actions
dominiqueclarke Apr 10, 2025
0a427a2
Merge branch 'related-alerts' of https://github.com/shahzad31/kibana …
dominiqueclarke Apr 10, 2025
eb1a31e
Merge branch 'main' into related-alerts
dominiqueclarke Apr 10, 2025
aecab6b
Merge branch 'main' of https://github.com/elastic/kibana into pr/shah…
dominiqueclarke Apr 10, 2025
75b403c
adjust types
dominiqueclarke Apr 10, 2025
624623c
Merge branch 'related-alerts' of https://github.com/shahzad31/kibana …
dominiqueclarke Apr 10, 2025
14cc8a0
Remove newline at end of kibana.jsonc file
dominiqueclarke Apr 10, 2025
5bc4667
remove whitespace
dominiqueclarke Apr 10, 2025
0e98a91
handle number type in cell renders
dominiqueclarke Apr 10, 2025
b6f1c86
add unit test
dominiqueclarke Apr 13, 2025
3e795d0
Merge branch 'main' of https://github.com/elastic/kibana into pr/shah…
dominiqueclarke Apr 13, 2025
001a597
Merge branch 'main' of https://github.com/elastic/kibana into pr/shah…
dominiqueclarke Apr 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { JsonValue } from '@kbn/utility-types';
export interface MetaAlertFields {
_id: string;
_index: string;
_score?: string | JsonValue[];
Comment thread
shahzad31 marked this conversation as resolved.
Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_score?: string | JsonValue[];
_score?: number;

@umbopepato umbopepato Apr 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To type this correctly as a number a bunch of other types must be updated accordingly (due to how TS represents additional property types) but I cannot suggest all the changes through GitHub so here's a patch:

diff --git a/src/platform/packages/shared/kbn-alerting-types/alerts_types.ts b/src/platform/packages/shared/kbn-alerting-types/alerts_types.ts
index 24230a96336..f519e842cb9 100644
--- a/src/platform/packages/shared/kbn-alerting-types/alerts_types.ts
+++ b/src/platform/packages/shared/kbn-alerting-types/alerts_types.ts
@@ -30,7 +30,7 @@ export type KnownAlertFields = {
   [Property in TechnicalRuleDataFieldName]?: JsonValue[];
 };
 
-export type UnknownAlertFields = Record<string, string | JsonValue[]>;
+export type UnknownAlertFields = Record<string, string | number | JsonValue[]>;
 
 /**
  * Alert document type as returned by alerts search requests
diff --git a/src/platform/packages/shared/response-ops/alerts-table/components/default_alerts_flyout.tsx b/src/platform/packages/shared/response-ops/alerts-table/components/default_alerts_flyout.tsx
index 77c3cc66733..a055869b82a 100644
--- a/src/platform/packages/shared/response-ops/alerts-table/components/default_alerts_flyout.tsx
+++ b/src/platform/packages/shared/response-ops/alerts-table/components/default_alerts_flyout.tsx
@@ -12,6 +12,7 @@ import { EuiDescriptionList, EuiPanel, EuiTabbedContentTab, EuiTitle } from '@el
 import { ALERT_RULE_NAME } from '@kbn/rule-data-utils';
 import { i18n } from '@kbn/i18n';
 import { ScrollableFlyoutTabbedContent, AlertFieldsTable } from '@kbn/alerts-ui-shared';
+import { JsonValue } from '@kbn/utility-types';
 import { AdditionalContext, FlyoutSectionProps } from '../types';
 import { defaultAlertsTableColumns } from '../configuration';
 import { DefaultCellValue } from './default_cell_value';
@@ -43,7 +44,7 @@ export const DefaultAlertsFlyoutBody = <AC extends AdditionalContext>(
         <EuiPanel hasShadow={false} data-test-subj="overviewTabPanel">
           <EuiDescriptionList
             listItems={(columns ?? defaultAlertsTableColumns).map((column) => {
-              const value = alert[column.id]?.[0];
+              const value = (alert[column.id] as JsonValue[])?.[0];
 
               return {
                 title: (column.displayAsText as string) ?? column.id,
diff --git a/src/platform/packages/shared/response-ops/alerts-table/components/default_cell_value.tsx b/src/platform/packages/shared/response-ops/alerts-table/components/default_cell_value.tsx
index 97bcdc88a8a..8cfeba5c63c 100644
--- a/src/platform/packages/shared/response-ops/alerts-table/components/default_cell_value.tsx
+++ b/src/platform/packages/shared/response-ops/alerts-table/components/default_cell_value.tsx
@@ -94,7 +94,7 @@ export const DefaultCellValue = ({
 /**
  * Extracts the value from the raw json ES field
  */
-const extractFieldValue = (rawValue: string | JsonValue[]) => {
+const extractFieldValue = (rawValue: string | number | JsonValue[]) => {
   const value = Array.isArray(rawValue) ? rawValue.join() : rawValue;
 
   if (!isEmpty(value)) {
diff --git a/x-pack/solutions/observability/plugins/observability/public/components/alerts_table/common/cell_value.tsx b/x-pack/solutions/observability/plugins/observability/public/components/alerts_table/common/cell_value.tsx
index 9ac39f42aeb..724bde5cc11 100644
--- a/x-pack/solutions/observability/plugins/observability/public/components/alerts_table/common/cell_value.tsx
+++ b/x-pack/solutions/observability/plugins/observability/public/components/alerts_table/common/cell_value.tsx
@@ -26,6 +26,7 @@ import {
 } from '@kbn/rule-data-utils';
 import { isEmpty } from 'lodash';
 import type { Alert } from '@kbn/alerting-types';
+import type { JsonValue } from '@kbn/utility-types';
 import {
   RELATED_ACTIONS_COL,
   RELATED_ALERT_REASON,
@@ -44,7 +45,7 @@ import AlertActions from '../../alert_actions/alert_actions';
 
 export const getAlertFieldValue = (alert: Alert, fieldName: string) => {
   // can be updated when working on https://github.com/elastic/kibana/issues/140819
-  const rawValue = alert[fieldName];
+  const rawValue = alert[fieldName] as JsonValue[];
   const value = Array.isArray(rawValue) ? rawValue.join() : rawValue;
 
   if (!isEmpty(value)) {

}

export interface LegacyField {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,22 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import { catchError, filter, lastValueFrom, map, of } from 'rxjs';
import type {
MappingRuntimeFields,
QueryDslFieldAndFormat,
QueryDslQueryContainer,
SortCombinations,
} from '@elastic/elasticsearch/lib/api/types';
import type {
Alert,
EsQuerySnapshot,
LegacyField,
RuleRegistrySearchRequest,
RuleRegistrySearchResponse,
} from '@kbn/alerting-types';
import { set } from '@kbn/safer-lodash-set';
import type { DataPublicPluginStart } from '@kbn/data-plugin/public';
import type {
MappingRuntimeFields,
QueryDslFieldAndFormat,
QueryDslQueryContainer,
SortCombinations,
} from '@elastic/elasticsearch/lib/api/types';
import { set } from '@kbn/safer-lodash-set';
import { catchError, filter, lastValueFrom, map, of } from 'rxjs';

export interface SearchAlertsParams {
// Dependencies
Expand Down Expand Up @@ -167,6 +167,7 @@ const parseAlerts = (rawResponse: RuleRegistrySearchResponse['rawResponse']) =>
acc.push({
...hit.fields,
_id: hit._id,
_score: hit._score,
_index: hit._index,
} as Alert);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@
"common"
]
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import React from 'react';
import ReactDOM from 'react-dom';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { PerformanceContextProvider } from '@kbn/ebt-tools';
import { InspectorContextProvider } from '@kbn/observability-shared-plugin/public';
import { i18n } from '@kbn/i18n';
import { Router, Routes, Route } from '@kbn/shared-ux-router';
import { AppMountParameters, APP_WRAPPER_CLASS, CoreStart } from '@kbn/core/public';
Expand Down Expand Up @@ -114,8 +115,10 @@ export const renderApp = ({
<RedirectAppLinks coreStart={core} data-test-subj="observabilityMainContainer">
<PerformanceContextProvider>
<QueryClientProvider client={queryClient}>
<App />
<HideableReactQueryDevTools />
<InspectorContextProvider>
<App />
<HideableReactQueryDevTools />
</InspectorContextProvider>
</QueryClientProvider>
</PerformanceContextProvider>
</RedirectAppLinks>
Expand Down
Loading