[Obs AI Assistant] Use built-in inference endpoints over specific models by sorenlouv · Pull Request #215591 · elastic/kibana

sorenlouv · 2025-03-21T23:35:09Z

Relates to https://github.com/elastic/obs-ai-assistant-team/issues/161

Updates POST /internal/observability_ai_assistant/kb/setup API by adding inference_id. This makes it possible to use any inference endpoint, and thereby any model in the knowledge base. For now we will only expose the built-in inference endpoints for E5 and ELSER as options in the UI
Improve re-indexing so it increments the current index and writes to the new one. Previously we would re-index to a temporary index, and then back again to the original index
Improve re-indexing so different consumers cannot run multiple re-index operations simultaneously

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/knowledge_base_callout.tsx

elasticmachine · 2025-03-22T05:40:29Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

github-actions · 2025-03-22T07:42:08Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

…-fix'

…renlouv/kibana into make-inference-task-type-configurable

…task-type-configurable

…ries

…task-type-configurable

x-pack/platform/plugins/shared/observability_ai_assistant/server/routes/knowledge_base/route.ts

x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_knowledge_base.tsx

viduni94 · 2025-04-17T16:02:09Z

Hey @sorenlouv
With the changes in your PR, we will be solving this issue too, am I right?
As per my understanding, when this PR is merged, we will stop using our custom inference endpoint. Just wanted to confirm.

viduni94 · 2025-04-17T17:43:10Z

x-pack/platform/plugins/shared/observability_ai_assistant/server/routes/knowledge_base/route.ts

-  params: t.partial({
-    query: t.partial({
-      model_id: t.string,
+  params: t.type({


Is there a reason to pass this as a query param instead of in the body since this is a POST request?

…of an error

elasticmachine · 2025-04-22T17:26:55Z

💔 Build Failed

Buildkite Build
Commit: 250c147
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-215591-250c147323ef

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #96 / Observability AI Assistant Functional tests knowledge_base_management/index.spec.ts Knowledge management tab "before all" hook in "Knowledge management tab"
[job] [logs] FTR Configs #96 / Observability AI Assistant Functional tests knowledge_base_management/index.spec.ts Knowledge management tab "before all" hook in "Knowledge management tab"
[job] [logs] FTR Configs #64 / Serverless Observability - Deployment-agnostic APM API integration tests observability AI Assistant context "before all" hook in "context"
[job] [logs] FTR Configs #64 / Serverless Observability - Deployment-agnostic APM API integration tests observability AI Assistant context "before all" hook in "context"
[job] [logs] FTR Configs #126 / Stateful Observability - Deployment-agnostic API integration tests Observability Alerting Custom Threshold rule CUSTOM_EQ - AVG - BYTES - FIRED Rule creation should set correct action variables

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ai-assistant`	105	106	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observabilityAIAssistantApp`	240.2KB	240.1KB	-70.0B
`observabilityAiAssistantManagement`	84.1KB	84.1KB	+55.0B
`searchAssistant`	165.5KB	165.4KB	-70.0B
total			-85.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/ai-assistant`	105	106	+1

History

sorenlouv · 2025-04-23T13:36:38Z

Replaced by #218448

…Knowledge Base (#218448) Closes elastic/obs-ai-team#230 Closes elastic/obs-ai-team#232 Related to #215591 ## Summary This PR implements the changes related to the first phase of supporing multilingual Knowledge Base. The users have the ability to pick the `e5-small` model for the Knowledge Base, if they want support for languages other than English. <img width="610" alt="image" src="https://github.com/user-attachments/assets/4c815aa4-aa97-4845-98c5-e079dd92f23a" /> <img width="1281" alt="image" src="https://github.com/user-attachments/assets/7c1bcd82-5464-497f-a053-7fe271da1cdd" /> <img width="1280" alt="image" src="https://github.com/user-attachments/assets/bc084e90-c291-44ea-8560-e033729bfcca" /> When the KB model is not allocated due to nodes scaling down: ![image](https://github.com/user-attachments/assets/2f52e31e-81e4-4824-bc5b-b97df714da5c) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Upgrade testing steps ### 9.0 - 9.1 (main) Checkout `9.0` branch and start Kibana and ES. ES must be started with `path.data` to persist data: ``` yarn es snapshot --license trial --E path.data=/Users/sorenlouv/elastic/es_data/upgrade_test_9.0 ``` --------- Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>

…Knowledge Base (elastic#218448) Closes elastic/obs-ai-team#230 Closes elastic/obs-ai-team#232 Related to elastic#215591 ## Summary This PR implements the changes related to the first phase of supporing multilingual Knowledge Base. The users have the ability to pick the `e5-small` model for the Knowledge Base, if they want support for languages other than English. <img width="610" alt="image" src="https://github.com/user-attachments/assets/4c815aa4-aa97-4845-98c5-e079dd92f23a" /> <img width="1281" alt="image" src="https://github.com/user-attachments/assets/7c1bcd82-5464-497f-a053-7fe271da1cdd" /> <img width="1280" alt="image" src="https://github.com/user-attachments/assets/bc084e90-c291-44ea-8560-e033729bfcca" /> When the KB model is not allocated due to nodes scaling down: ![image](https://github.com/user-attachments/assets/2f52e31e-81e4-4824-bc5b-b97df714da5c) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Upgrade testing steps ### 9.0 - 9.1 (main) Checkout `9.0` branch and start Kibana and ES. ES must be started with `path.data` to persist data: ``` yarn es snapshot --license trial --E path.data=/Users/sorenlouv/elastic/es_data/upgrade_test_9.0 ``` --------- Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com> (cherry picked from commit dc019f8) # Conflicts: # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json # x-pack/platform/plugins/shared/observability_ai_assistant/server/service/inference_endpoint.ts # x-pack/platform/plugins/shared/observability_ai_assistant/server/service/knowledge_base_service/reindex_knowledge_base.ts # x-pack/platform/plugins/shared/observability_ai_assistant/server/service/startup_migrations/create_or_update_index_assets.ts # x-pack/platform/plugins/shared/observability_ai_assistant/server/service/startup_migrations/populate_missing_semantic_text_field_migration.ts # x-pack/solutions/observability/plugins/observability_ai_assistant_management/tsconfig.json # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/chat/chat.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_and_populate_missing_semantic_text_fields.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_reindex_to_fix_sparse_vector_support.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_setup.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_status.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/utils/knowledge_base.ts

…Knowledge Base (elastic#218448) Closes elastic/obs-ai-team#230 Closes elastic/obs-ai-team#232 Related to elastic#215591 ## Summary This PR implements the changes related to the first phase of supporing multilingual Knowledge Base. The users have the ability to pick the `e5-small` model for the Knowledge Base, if they want support for languages other than English. <img width="610" alt="image" src="https://github.com/user-attachments/assets/4c815aa4-aa97-4845-98c5-e079dd92f23a" /> <img width="1281" alt="image" src="https://github.com/user-attachments/assets/7c1bcd82-5464-497f-a053-7fe271da1cdd" /> <img width="1280" alt="image" src="https://github.com/user-attachments/assets/bc084e90-c291-44ea-8560-e033729bfcca" /> When the KB model is not allocated due to nodes scaling down: ![image](https://github.com/user-attachments/assets/2f52e31e-81e4-4824-bc5b-b97df714da5c) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Upgrade testing steps ### 9.0 - 9.1 (main) Checkout `9.0` branch and start Kibana and ES. ES must be started with `path.data` to persist data: ``` yarn es snapshot --license trial --E path.data=/Users/sorenlouv/elastic/es_data/upgrade_test_9.0 ``` --------- Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>

Make inference task type configurable

2f931c8

sorenlouv commented Mar 21, 2025

View reviewed changes

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/knowledge_base_callout.tsx Outdated Show resolved Hide resolved

Remove SelectKnowledgeBaseModel

68819ef

sorenlouv changed the title ~~[Obs AI Assistant] Make inference task type configurable~~ [Obs AI Assistant] Add task_type param to. setup API and improve re-indexing logic Mar 22, 2025

sorenlouv marked this pull request as ready for review March 22, 2025 00:19

sorenlouv requested review from a team as code owners March 22, 2025 00:19

Update i18n

ce96765

botelastic bot added the Team:Obs AI Assistant Observability AI Assistant label Mar 22, 2025

sorenlouv added backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.1.0 v8.19.0 labels Mar 22, 2025

Fix functional test

5397a87

botelastic bot added the ci:project-deploy-observability Create an Observability project label Mar 22, 2025

sorenlouv and others added 4 commits March 22, 2025 08:58

Improve reindex so it does not delete existing target index

3770d3f

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

23b031e

…-fix'

remove driver import

911c947

Rename alias to writeIndexAlias

be207d6

sorenlouv force-pushed the make-inference-task-type-configurable branch from be0ef22 to be207d6 Compare March 23, 2025 23:31

sorenlouv added 8 commits March 24, 2025 11:26

Add missing concreteWriteIndex

3f193bb

Add test for index asserts. Only re-index if there are entries in KB

5108b7f

Renaming

3008a8d

Merge branch 'make-inference-task-type-configurable' of github.com:so…

d95997e

…renlouv/kibana into make-inference-task-type-configurable

Fix tests

33cb013

Rename re-index test

1018f25

Remove elser from method names

73b41db

Merge branch 'main' of github.com:elastic/kibana into make-inference-…

e03bf88

…task-type-configurable

sorenlouv added 3 commits April 11, 2025 13:39

Merge branch 'main' of github.com:elastic/kibana into make-inference-…

d4c9ff0

…task-type-configurable

Undo client side changes

0ce75b5

Use writeIndexAlias instead of indexPatterns for conversation que…

2f56793

…ries

sorenlouv changed the title ~~[Obs AI Assistant] Enable custom inference endpoints in KB~~ [Obs AI Assistant] Use built-in inference endpoints over specific models Apr 13, 2025

sorenlouv added 5 commits April 13, 2025 15:22

Merge branch 'main' into make-inference-task-type-configurable

20dc795

Fix lint issues

b3b26a8

Fix i18n

90ab9ab

Merge branch 'main' of github.com:elastic/kibana into make-inference-…

ab47c70

…task-type-configurable

Fix test

917d652

viduni94 reviewed Apr 14, 2025

View reviewed changes

sorenlouv and others added 2 commits April 14, 2025 21:28

Address feedback

500b49e

Fix i18n

47bbc71

viduni94 mentioned this pull request Apr 16, 2025

[Obs AI Assistant] Specify embedding model during onboarding for the Knowledge Base #218448

Merged

4 tasks

sorenlouv and others added 2 commits April 16, 2025 20:10

Merge branch 'main' into make-inference-task-type-configurable

be6de9b

Merge branch 'main' into make-inference-task-type-configurable

6570594

viduni94 reviewed Apr 17, 2025

View reviewed changes

viduni94 added 6 commits April 20, 2025 15:07

Merge branch 'main' into make-inference-task-type-configurable

d6ec1d2

Merge branch 'main' into make-inference-task-type-configurable

fc5bb0b

Merge branch 'main' into make-inference-task-type-configurable

3984665

When trained model stats are not found, return not_installed instead …

6649b50

…of an error

Merge branch 'main' into make-inference-task-type-configurable

1d17118

Merge branch 'main' into make-inference-task-type-configurable

250c147

sorenlouv closed this Apr 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Obs AI Assistant] Use built-in inference endpoints over specific models#215591

[Obs AI Assistant] Use built-in inference endpoints over specific models#215591
sorenlouv wants to merge 70 commits intoelastic:mainfrom
sorenlouv:make-inference-task-type-configurable

sorenlouv commented Mar 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

elasticmachine commented Mar 22, 2025

Uh oh!

github-actions bot commented Mar 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

viduni94 commented Apr 17, 2025

Uh oh!

viduni94 Apr 17, 2025

Uh oh!

elasticmachine commented Apr 22, 2025 •

edited

Loading

API count

Uh oh!

sorenlouv commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sorenlouv commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Mar 22, 2025

Uh oh!

github-actions bot commented Mar 22, 2025

🤖 GitHub comments

Uh oh!

Uh oh!

Uh oh!

Uh oh!

viduni94 commented Apr 17, 2025

Uh oh!

viduni94 Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

Uh oh!

sorenlouv commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sorenlouv commented Mar 21, 2025 •

edited

Loading

elasticmachine commented Apr 22, 2025 •

edited

Loading