[9.0] initial @kbn/scout-security plugin (#210433)#215528
Merged
MadameSheema merged 4 commits intoelastic:9.0from Mar 21, 2025
Merged
[9.0] initial @kbn/scout-security plugin (#210433)#215528MadameSheema merged 4 commits intoelastic:9.0from
MadameSheema merged 4 commits intoelastic:9.0from
Conversation
## Summary Closes elastic#210298 In this PR we are adding the initial structure for the @kibana/scout-security package, note that this is not ready to be used and any new test using this package, is not going to be executed as part of the regular pipelines, meaning, you are not going to add coverage to the application. @kibana/scout-security package is a test package that extends @kbn/scout with test helpers specifically designed to test Security Solution functionalities in Kibana. All tests under Security plugins should only import from @kbn/scout-security, not from @kbn/scout. This PR is a POC to start testing development by providing custom Playwright fixtures, page objects, and utilities tailored for Security-related testing scenarios. Things to follow-up: - CustomQueryRule interface is already declared in `x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/model/rule_schema/rule_schemas.gen.ts` as `QueryRuleCreateProps` - DETECTION_ENGINE_RULES_URL and DETECTION_ENGINE_RULES_BULK_ACTION are already declared in `@kbn/security-solution-plugin/common/constants` It would be great if all of that is extracted from the plugin to a package so it can be reused instead of having to duplicate the code. Until the package is not ready to be used and has not been introduced to the different teams, appex-qa and myself will be the owners of it to make sure that best practices are followed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co> (cherry picked from commit d5a0501) # Conflicts: # .buildkite/scout_ci_config.yml
dmlemeshko
approved these changes
Mar 21, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Any counts in public APIs
Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
Unreferenced deprecated APIs
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation