use SavedObjectsClientProvider to provide SavedObjectLoader with an angular wrapped saved object client #21541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngular wrapped saved object client
nreese
added
bug
timroes
approved these changes
Aug 1, 2018
Contributor
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Code looks good to me, tested, that it fixes the broken saved search loading in the visualization wizard.
cjcenizal
approved these changes
Aug 1, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Great catch! Tested locally and it fixes the problem. Code LGTM.
Contributor
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 1, 2018
…ngular wrapped saved object client (elastic#21541)
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 1, 2018
…ngular wrapped saved object client (elastic#21541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20384 removed angular from the saved object client. That PR failed to update SavedObjectLoader with the angular wrapper around the saved object client provided by SavedObjectsClientProvider. This resulted in errors as seen in #21536