Skip to content

[One Discover] Add 'Read More', 'Read Less' functionality to highlight_fields#215326

Merged
rStelmach merged 8 commits intoelastic:mainfrom
rStelmach:198851-one-discover-big-blob-of-text-when-user-hovers-on-a-field-in-document-view-in-discover
Apr 2, 2025
Merged

[One Discover] Add 'Read More', 'Read Less' functionality to highlight_fields#215326
rStelmach merged 8 commits intoelastic:mainfrom
rStelmach:198851-one-discover-big-blob-of-text-when-user-hovers-on-a-field-in-document-view-in-discover

Conversation

@rStelmach
Copy link
Contributor

@rStelmach rStelmach commented Mar 20, 2025 •
edited by kibanamachine
Loading

Added Read More/ Read Less functionality to fields in Document view in Discover.
Also width of a field has been slightly increased.

Screenshot 2025-03-21 at 11 10 02 Screenshot 2025-03-21 at 11 15 28

@rStelmach rStelmach added backport:version Backport to applied version labels v9.1.0 v8.19.0 bug Fixes for quality problems that affect the customer experience Team:obs-onboarding Observability Onboarding Team labels Mar 21, 2025
@rStelmach rStelmach linked an issue Mar 21, 2025 that may be closed by this pull request
[One Discover] Big blob of text when user hovers on a field in document view in Discover #198851
Closed
@rStelmach rStelmach marked this pull request as ready for review March 21, 2025 10:19
@rStelmach rStelmach requested a review from a team as a code owner March 21, 2025 10:19
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 21, 2025

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@rStelmach rStelmach added the release_note:feature Makes this part of the condensed release notes label Mar 21, 2025
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner March 31, 2025 15:08
davismcphee
davismcphee approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review, Data Discovery changes LGTM (really just tsconfig.json update).

yngrdyn
yngrdyn reviewed Apr 2, 2025
View reviewed changes
src/platform/packages/shared/kbn-react-hooks/src/use_truncate_text/use_truncate_text.tsx
Copy link
Contributor

@yngrdyn yngrdyn Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you added tests to understand the behaviour of the hook.
Could you please also add information in src/platform/packages/shared/kbn-react-hooks/README.md

yngrdyn
yngrdyn approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rStelmach
Merge branch 'main' into 198851-one-discover-big-blob-of-text-when-us…
e16857f 
…er-hovers-on-a-field-in-document-view-in-discover
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 2, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / X-Pack Accessibility Tests - Group 1 Kibana Home Accessibility Observability overview page meets a11y requirements

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1888 1890 +2
cloudSecurityPosture 691 693 +2
controls 356 358 +2
datasetQuality 287 305 +18
discover 1205 1207 +2
esqlDataGrid 419 421 +2
infra 1434 1436 +2
inventory 234 236 +2
investigateApp 264 266 +2
lens 1364 1366 +2
maps 1256 1258 +2
presentationPanel 120 122 +2
searchPlayground 331 333 +2
securitySolution 7171 7173 +2
slo 1122 1124 +2
streamsApp 425 427 +2
unifiedDocViewer 288 305 +17
visualizations 472 474 +2
workchatApp 160 162 +2
total +69

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/react-hooks 19 23 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 240.6KB 240.8KB +222.0B
unifiedDocViewer 204.8KB 205.7KB +867.0B
total +1.1KB
Unknown metric groups

API count

id before after diff
@kbn/react-hooks 26 30 +4

History

@rStelmach rStelmach merged commit d92ecd4 into elastic:main Apr 2, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 2, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14221559934

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 2, 2025

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Discover] Fix formatting and sorting for custom ES|QL vars (#209360)

Manual backport

To create the backport manually run:

node scripts/backport --pr 215326

Questions ?

Please refer to the Backport tool documentation

@rStelmach rStelmach mentioned this pull request Apr 2, 2025
Merged
@rStelmach
Copy link
Contributor Author

rStelmach commented Apr 2, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

rStelmach added a commit to rStelmach/kibana that referenced this pull request Apr 2, 2025
@rStelmach
[One Discover] Add 'Read More', 'Read Less' functionality to highligh…
70f4ab9 
…t_fields (elastic#215326)

Added Read More/ Read Less functionality to fields in Document view in
Discover.
Also width of a field has been slightly increased.

<img width="766" alt="Screenshot 2025-03-21 at 11 10 02"
src="https://github.com/user-attachments/assets/771f0b0e-4613-4b5f-9785-558f22f44236"
/>
<img width="784" alt="Screenshot 2025-03-21 at 11 15 28"
src="https://github.com/user-attachments/assets/3b5a8b18-fbce-4cf6-9ede-9dfb70b33c2f"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d92ecd4)

# Conflicts:
#	src/platform/plugins/shared/unified_doc_viewer/tsconfig.json
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 4, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 4, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 7, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 8, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

rStelmach added a commit that referenced this pull request Apr 9, 2025
@rStelmach @kibanamachine
[8.x] [One Discover] Add 'Read More', 'Read Less' functionality to hi…
f0655ef 
…ghlight_fields (#215326) (#216856)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[One Discover] Add 'Read More', 'Read Less' functionality to
highlight_fields
(#215326)](#215326)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Robert
Stelmach","email":"60304951+rStelmach@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-02T14:01:12Z","message":"[One
Discover] Add 'Read More', 'Read Less' functionality to highlight_fields
(#215326)\n\nAdded Read More/ Read Less functionality to fields in
Document view in\nDiscover.\nAlso width of a field has been slightly
increased.\n\n<img width=\"766\" alt=\"Screenshot 2025-03-21 at 11 10
02\"\nsrc=\"https://github.com/user-attachments/assets/771f0b0e-4613-4b5f-9785-558f22f44236\"\n/>\n<img
width=\"784\" alt=\"Screenshot 2025-03-21 at 11 15
28\"\nsrc=\"https://github.com/user-attachments/assets/3b5a8b18-fbce-4cf6-9ede-9dfb70b33c2f\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d92ecd4a174d91cfb4772ef70c18262f23cdf0d0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:feature","Team:obs-ux-logs","backport:version","v9.1.0","v8.19.0"],"title":"[One
Discover] Add 'Read More', 'Read Less' functionality to
highlight_fields","number":215326,"url":"https://github.com/elastic/kibana/pull/215326","mergeCommit":{"message":"[One
Discover] Add 'Read More', 'Read Less' functionality to highlight_fields
(#215326)\n\nAdded Read More/ Read Less functionality to fields in
Document view in\nDiscover.\nAlso width of a field has been slightly
increased.\n\n<img width=\"766\" alt=\"Screenshot 2025-03-21 at 11 10
02\"\nsrc=\"https://github.com/user-attachments/assets/771f0b0e-4613-4b5f-9785-558f22f44236\"\n/>\n<img
width=\"784\" alt=\"Screenshot 2025-03-21 at 11 15
28\"\nsrc=\"https://github.com/user-attachments/assets/3b5a8b18-fbce-4cf6-9ede-9dfb70b33c2f\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d92ecd4a174d91cfb4772ef70c18262f23cdf0d0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215326","number":215326,"mergeCommit":{"message":"[One
Discover] Add 'Read More', 'Read Less' functionality to highlight_fields
(#215326)\n\nAdded Read More/ Read Less functionality to fields in
Document view in\nDiscover.\nAlso width of a field has been slightly
increased.\n\n<img width=\"766\" alt=\"Screenshot 2025-03-21 at 11 10
02\"\nsrc=\"https://github.com/user-attachments/assets/771f0b0e-4613-4b5f-9785-558f22f44236\"\n/>\n<img
width=\"784\" alt=\"Screenshot 2025-03-21 at 11 15
28\"\nsrc=\"https://github.com/user-attachments/assets/3b5a8b18-fbce-4cf6-9ede-9dfb70b33c2f\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d92ecd4a174d91cfb4772ef70c18262f23cdf0d0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

@davismcphee davismcphee davismcphee approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:feature Makes this part of the condensed release notes Team:obs-onboarding Observability Onboarding Team v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[One Discover] Big blob of text when user hovers on a field in document view in Discover

5 participants

@rStelmach @elasticmachine @kibanamachine @yngrdyn @davismcphee