[unification][oblt] Integrate AI Assistant CTA by clintandrewhall · Pull Request #215207 · elastic/kibana

clintandrewhall · 2025-03-19T16:25:19Z

Summary

This PR is one of a pair that integrates Call-to-Action and Knowledge Base components into the AI Assistant. It includes a commit that contains @elastic/appex-sharedux changes, which is included in both.

I fully expect CI tests to fail with the first pass or so.

This PR aligns the AI Assistant with the unified design for an Assistant.

No Connector

Before

After

No Knowledge Base

Before

After

Installing Knowledge Base

Before

After

Ready to Help

Before

After

elasticmachine · 2025-03-19T16:25:22Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

github-actions · 2025-03-25T15:28:30Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

...kages/shared/ai-assistant/ai-assistant-cta/install_knowledge_base/install_knowledge_base.tsx

stephmilovic

LGTM for the Security GenAI changes. Code review only, thanks!

...kages/shared/ai-assistant/ai-assistant-cta/install_knowledge_base/install_knowledge_base.tsx

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/welcome_message.tsx

arturoliduena · 2025-03-26T22:57:51Z

When opening the AI Assistant, before the “Install” button appears, there is a brief flash of another element. It is unclear what this element is, but it appears momentarily before the correct UI is displayed.

Screen.Recording.2025-03-26.at.23.53.20.mov

arturoliduena · 2025-03-26T23:12:45Z

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/conversation_list.tsx

-              </EuiFlexGroup>
-            </EuiPanel>
-          </EuiFlexItem>
+          {connectors?.length ? (


Why don’t we allow navigating to a new conversation when there are no connectors?

Currently, if there is no connector, we show a button to add one directly from the AI Assistant, without requiring navigation to the connector settings page. However, if a user previously had a connector, started a conversation, and then deleted the connector, they can still see the list of past conversations.

In this scenario, we should allow the user to navigate back to the “New Conversation” page from the “Add Connector” button.

This should be raised with @isaclfreire and others involved in the unified design. The designs make no allowances for "New Conversation" to be available.

clintandrewhall · 2025-03-27T03:14:36Z

@arturoliduena The "create connector" portion of the flow is flashing because retrieving the current connector and knowledge base state is delegated to a hook, which executes after the first render. I didn't have the depth of knowledge of the codebase to account for that until you pointed it out, but can look into it. I welcome commits in the meantime!

clintandrewhall · 2025-03-27T20:29:13Z

@viduni94 @arturoliduena I was able to address all of your feedback with my latest commit:

Loading state

Conversation width

Knowledge base "flashing"

elasticmachine · 2025-04-11T08:42:15Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2025-04-11T08:42:15Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine · 2025-04-11T08:42:15Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

rmyz

Infra & Services changes LGTM

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/incorrect_license_panel.tsx

viduni94 · 2025-04-11T14:15:25Z

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/welcome_message.tsx

+  );
+
+  const isConnectorReady = useMemo(
+    () => !connectors.error && connectors.connectors?.length && connectors.connectors.length > 0,


Why do we have both connectors.connectors?.length and connectors.connectors.length > 0 here?
Isn't checking for connectors.connectors?.length automatically mean connectors.connectors.length > 0 as well?

It just eliminates the undefined check for clarity. Happy to change it, just submit a suggestion and I'll merge it... or I can just change it.

elasticmachine · 2025-04-15T15:03:34Z

💔 Build Failed

Buildkite Build
Commit: d277e0d
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-215207-d277e0d21a44

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #15 / @ess @serverless SecuritySolution Explore Overview Overview Host With auditbeat Make sure that we get OverviewHost data
[job] [logs] FTR Configs #15 / @ess @serverless SecuritySolution Explore Overview Overview Host With auditbeat Make sure that we get OverviewHost data
[job] [logs] FTR Configs #49 / console app misc console behavior keyboard shortcuts open documentation should open documentation when Ctrl+/ is pressed
[job] [logs] FTR Configs #49 / console app misc console behavior keyboard shortcuts open documentation should open documentation when Ctrl+/ is pressed
[job] [logs] FTR Configs #49 / Observability AI Assistant Functional tests conversations/index.spec.ts Conversations without a connector after clicking on the setup connectors button opens a flyout
[job] [logs] FTR Configs #49 / Observability AI Assistant Functional tests conversations/index.spec.ts Conversations without a connector after clicking on the setup connectors button opens a flyout
[job] [logs] Jest Tests #5 / WelcomeMessageKnowledgeBase renders "Base setup failed" with inspect issues
[job] [logs] Jest Tests #5 / WelcomeMessageKnowledgeBase renders "Base setup failed" with inspect issues
[job] [logs] Jest Tests #5 / WelcomeMessageKnowledgeBase renders "not set up" if model is not ready (but no errorMessage because endpoint exists)
[job] [logs] Jest Tests #5 / WelcomeMessageKnowledgeBase renders "not set up" if model is not ready (but no errorMessage because endpoint exists)
[job] [logs] Jest Tests #5 / WelcomeMessageKnowledgeBase renders "We are setting up your knowledge base" with the inspect button
[job] [logs] Jest Tests #5 / WelcomeMessageKnowledgeBase renders "We are setting up your knowledge base" with the inspect button

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observabilityAIAssistantApp`	440	460	+20
`observabilityAiAssistantManagement`	387	407	+20
`searchAssistant`	270	290	+20
total			+60

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observabilityAIAssistantApp`	251.2KB	252.6KB	+1.4KB
`observabilityAiAssistantManagement`	92.0KB	95.8KB	+3.8KB
`searchAssistant`	165.5KB	166.9KB	+1.4KB
`stackConnectors`	618.1KB	618.1KB	-56.0B
total			+6.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityAIAssistantApp`	15.8KB	15.8KB	+11.0B

History

💔 Build #292251 failed 502d74c
💔 Build #292205 failed d8fc17f
💚 Build #289685 succeeded d159c12
💚 Build #287930 succeeded 770b0c0

clintandrewhall added review release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Team:Obs AI Assistant Observability AI Assistant v9.1.0 labels Mar 19, 2025

clintandrewhall requested review from a team as code owners March 19, 2025 16:25

clintandrewhall mentioned this pull request Mar 20, 2025

update knowledge base installation flow #214133

Merged

9 tasks

clintandrewhall force-pushed the ai/cta-oblt-integration branch from d5771d1 to d9147a7 Compare March 20, 2025 21:20

botelastic bot added the ci:project-deploy-observability Create an Observability project label Mar 25, 2025

clintandrewhall force-pushed the ai/cta-oblt-integration branch 2 times, most recently from 78b05ba to f191911 Compare March 26, 2025 01:35

clintandrewhall requested review from a team as code owners March 26, 2025 03:37

viduni94 reviewed Mar 26, 2025

View reviewed changes

...kages/shared/ai-assistant/ai-assistant-cta/install_knowledge_base/install_knowledge_base.tsx Show resolved Hide resolved

stephmilovic approved these changes Mar 26, 2025

View reviewed changes

viduni94 reviewed Mar 26, 2025

View reviewed changes

arturoliduena reviewed Mar 26, 2025

View reviewed changes

clintandrewhall force-pushed the ai/cta-oblt-integration branch from 8bf03eb to 5f30775 Compare March 27, 2025 18:54

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner March 27, 2025 19:17

clintandrewhall force-pushed the ai/cta-oblt-integration branch 2 times, most recently from e680d6c to 5f1e378 Compare March 27, 2025 20:25

clintandrewhall removed the request for review from a team March 27, 2025 20:29

clintandrewhall force-pushed the ai/cta-oblt-integration branch from 5f1e378 to 770b0c0 Compare March 28, 2025 01:24

arturoliduena requested review from a team as code owners April 11, 2025 08:42

rmyz approved these changes Apr 11, 2025

View reviewed changes

clintandrewhall and others added 3 commits April 11, 2025 11:50

[unification][oblt] Integrate AI Assistant CTA

50944f6

Address feedback

02828d1

Update WelcomeMessage components using KnowledgeBaseState

502d74c

arturoliduena force-pushed the ai/cta-oblt-integration branch from d8fc17f to 502d74c Compare April 11, 2025 10:03

arturoliduena removed request for a team April 11, 2025 10:04

arturoliduena disabled auto-merge April 11, 2025 10:05

arturoliduena mentioned this pull request Apr 11, 2025

Adopt KB installation AI Assistant Shared Components #217970

Open

viduni94 reviewed Apr 11, 2025

View reviewed changes

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/incorrect_license_panel.tsx Show resolved Hide resolved

viduni94 reviewed Apr 11, 2025

View reviewed changes

Merge branch 'main' into ai/cta-oblt-integration

d277e0d

delanni removed the backport:prev-minor label Sep 26, 2025

clintandrewhall closed this Dec 18, 2025

Conversation

clintandrewhall commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

No Connector

Before

After

No Knowledge Base

Before

After

Installing Knowledge Base

Before

After

Ready to Help

Before

After

Uh oh!

elasticmachine commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 25, 2025

🤖 GitHub comments

Uh oh!

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arturoliduena commented Mar 26, 2025

Uh oh!

arturoliduena Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

clintandrewhall commented Mar 27, 2025

Uh oh!

clintandrewhall commented Mar 27, 2025

Loading state

Conversation width

Knowledge base "flashing"

Uh oh!

elasticmachine commented Apr 11, 2025

Uh oh!

elasticmachine commented Apr 11, 2025

Uh oh!

elasticmachine commented Apr 11, 2025

Uh oh!

rmyz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

viduni94 Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

clintandrewhall commented Mar 19, 2025 •

edited

Loading

elasticmachine commented Apr 15, 2025 •

edited

Loading