[8.x] [Streams] [Dedicated Grok UI] Package / highlight matched parts / suggestions (#213278)#215204
Merged
Kerry350 merged 3 commits intoelastic:8.xfrom Mar 20, 2025
Merged
Conversation
…gestions (elastic#213278) ## Summary Closes elastic/streams-program#170 and elastic/streams-program#171 ## Reviewer notes It's worth reading the research in elastic/streams-program#168 to understand why certain decisions were made. Some of the resolving code is inspired by `grok-js`, unfortunately this wasn't something we could use directly. The design / UX is **not** final. This is just a functional version. The editor is currently on the streams > enrichment page so it can be played with, this will **not** be merged. There is pattern support for our ECS patterns, I have not added the legacy ones. There will almost certainly be some edge cases that don't work, every repo for a Grok tool I looked at had their own 😅 I've tried to test this with lots of varied examples though. I'd recommend unticking "No extension" from the file filter to remove the pattern files. <img width="323" alt="Screenshot 2025-03-06 at 22 40 19" src="https://github.com/user-attachments/assets/5b594f5f-0b0f-4ed0-ae10-2412fcf9e31a" /> ## Possible improvements / followups - We could in the future expand the UI to toggle on and off certain pattern collections. - Ability to add custom patterns (like in our Grok debugger). This can still be achieved with `(?<queue_id>[0-9A-F]{10,11})` syntax. - Point out when regex is invalid (right now it's silent). - I've copied over the patterns from the ES repo for now, with a light script to generate an object from them. There's a CLI skeleton in place if we feel we want to actually pull these from the ES repo directly. These patterns don't change often, and aren't heavy size wise. - Debouncing etc for processing, but I'd like to see how the final UX ends up. ## Media Screenshot  Simple example  Complex example  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f978350) # Conflicts: # .github/CODEOWNERS # yarn.lock
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
|
flash1293
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation