[Fleet] Report automatic upgrade status in UI by Supplementing · Pull Request #215069 · elastic/kibana

Supplementing · 2025-03-18T21:26:24Z

Closes 4718

Summary

After much discussion, updated to not show percentages but be very similar to existing upgrade text, but with an icon/tooltip letting the user know it was created from an automatic upgrade. Also applied to completed actions.
Made policyId persistent in newly created actions in order to streamline accessing the upgrade modal from agent activity
Added is_automatic field to ActionStatus type by retrieving from the source doc in getActions
Updated audit log to show if the action was created by the user or from the auto-upgrade functionality
Updated badging on table to show retry attempts
Added manage auto-upgrade button to agent activity actions created by automatic upgrades
Updated check in automatic_upgrade_task to only consider active agents in order to resolve an issue where uninstalled agents could affect the upgrade of new ones.
Reworked rounding functionality when percentages or counts of agents to upgrade were over or under where they should be. Rounding is now done in a way such that no agents get left behind, and we dont try to upgrade more than exist.
Added new test coverage for the rounding functionality, the new active vs inactive agents check, as well as ensuring the manage auto-upgrades button always renders.

Simplified UI with tooltip and button to quickly access auto-upgrade settings for the policy the action belongs to:

Updated tooltip to let the user know that rounding is in place:

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

N/A

…to tell whats happening

…or use in ActionStatus

…ogging, added retry attempt badge

…ristians feedback

…ded items due to simpler UI

Supplementing · 2025-03-28T07:28:39Z

/ci

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'

…ons to use the correct types

elasticmachine · 2025-03-28T16:59:14Z

Pinging @elastic/fleet (Team:Fleet)

Supplementing · 2025-03-28T16:59:27Z

@elasticmachine merge upstream

Supplementing · 2025-04-02T23:18:04Z

Can you reproduce this? If not I can double check, but I think that happened consistently.

Sent you a direct message, but yes I can reproduce, seems to be a minor flaw in the way we are calculating upgrading vs not in that modal. May not be a blocker here, but we either need to get it added to this PR, or track it separately.

jillguyonnet · 2025-04-04T15:18:16Z

Looking real good!

Quick UX question: is there a reason we only show the Manage auto-upgrade agents and Learn more buttons for in-progress actions?

Supplementing · 2025-04-04T15:34:35Z

Quick UX question: is there a reason we only show the Manage auto-upgrade agents and Learn more buttons for in-progress actions?

No real reason other than that was in the original scope/mockup. Learn more is existing, it was just moved from the top of the action to a button per @sileschristian recommendation. I can add them for parity if you think it makes sense? Its a very trivial change as the actions have everything we need to conditionally render them. Though, i do wonder if the manage button is needed on already completed items, managing them at that point is kind of a moot point, no?

sileschristian · 2025-04-04T15:58:58Z

Quick UX question: is there a reason we only show the Manage auto-upgrade agents and Learn more buttons for in-progress actions?

No real reason other than that was in the original scope/mockup. Learn more is existing, it was just moved from the top of the action to a button per @sileschristian recommendation. I can add them for parity if you think it makes sense? Its a very trivial change as the actions have everything we need to conditionally render them. Though, i do wonder if the manage button is needed on already completed items, managing them at that point is kind of a moot point, no?

I would keep the Manage auto-upgrade agents in case the user needs to change something. What's the URL behind the Learn more?

…completed on status column (to be moved to another issue)

Supplementing · 2025-04-04T16:21:08Z

I would keep the Manage auto-upgrade agents in case the user needs to change something. What's the URL behind the Learn more?

https://www.elastic.co/guide/en/fleet/current/upgrade-elastic-agent.html is where it links. I dont know if we need it on already complete items though?

…upgrades

… fix agent fetcher (#217024) ## Summary Filter out inactive agents in auto upgrade status API - this fixes uninstalled agents incorrectly included in the % calculation. For example with 10 active and 5 uninstalled agents, the percentages are lower than expected. <img width="1787" alt="image" src="https://github.com/user-attachments/assets/bd0ebcea-88c5-40d0-b982-f605e83b4eb8" /> After the change, the 5 uninstalled agents are not included: <img width="1778" alt="image" src="https://github.com/user-attachments/assets/72349902-bbb8-4adb-a69e-8dbfc92ad89e" /> The other fix is related to the auto upgrade logic: #215069 (comment) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

juliaElastic

LGTM

jillguyonnet · 2025-04-07T09:49:57Z

https://www.elastic.co/guide/en/fleet/current/upgrade-elastic-agent.html is where it links. I dont know if we need it on already complete items though?

As a note, this may need to be updated when we have public facing documentation for automatic upgrades.

jillguyonnet

Thanks for your work on this, LGTM 🚀

Supplementing · 2025-04-07T13:45:40Z

@elasticmachine merge upstream

Supplementing · 2025-04-07T14:32:17Z

@kilfoyle If you want to peek at the copy here now that you're back!

elasticmachine · 2025-04-07T15:31:58Z

💚 Build Succeeded

Buildkite Build
Commit: 95fcd18

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.7MB	1.7MB	+3.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	162.3KB	162.4KB	+54.0B

History

💚 Build #290432 succeeded 93c8636
💔 Build #289308 failed ba28195
💔 Build #289279 failed 983b5fa
💔 Build #288842 failed c9cfb8f
💔 Build #288840 failed 8746451
💔 Build #288839 failed 196fa4e

Closes [4718](elastic/ingest-dev#4718) ## Summary - After much discussion, updated to not show percentages but be very similar to existing upgrade text, but with an icon/tooltip letting the user know it was created from an automatic upgrade. Also applied to completed actions. - Made `policyId` persistent in newly created actions in order to streamline accessing the upgrade modal from agent activity - Added `is_automatic` field to `ActionStatus` type by retrieving from the source doc in `getActions` - Updated audit log to show if the action was created by the user or from the auto-upgrade functionality - Updated badging on table to show retry attempts - Added `manage auto-upgrade` button to agent activity actions created by automatic upgrades - Updated check in `automatic_upgrade_task` to only consider active agents in order to resolve an issue where uninstalled agents could affect the upgrade of new ones. - Reworked rounding functionality when percentages or counts of agents to upgrade were over or under where they should be. Rounding is now done in a way such that no agents get left behind, and we dont try to upgrade more than exist. - Added new test coverage for the rounding functionality, the new active vs inactive agents check, as well as ensuring the manage auto-upgrades button always renders. Simplified UI with tooltip and button to quickly access auto-upgrade settings for the policy the action belongs to: ![image](https://github.com/user-attachments/assets/44205322-d6ca-40fb-bfb3-c1f26132418b) Updated tooltip to let the user know that rounding is in place: ![image](https://github.com/user-attachments/assets/0d62688e-6d48-4c0a-9b03-a77deb814f1e) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks N/A --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Closes [4718](elastic/ingest-dev#4718) - After much discussion, updated to not show percentages but be very similar to existing upgrade text, but with an icon/tooltip letting the user know it was created from an automatic upgrade. Also applied to completed actions. - Made `policyId` persistent in newly created actions in order to streamline accessing the upgrade modal from agent activity - Added `is_automatic` field to `ActionStatus` type by retrieving from the source doc in `getActions` - Updated audit log to show if the action was created by the user or from the auto-upgrade functionality - Updated badging on table to show retry attempts - Added `manage auto-upgrade` button to agent activity actions created by automatic upgrades - Updated check in `automatic_upgrade_task` to only consider active agents in order to resolve an issue where uninstalled agents could affect the upgrade of new ones. - Reworked rounding functionality when percentages or counts of agents to upgrade were over or under where they should be. Rounding is now done in a way such that no agents get left behind, and we dont try to upgrade more than exist. - Added new test coverage for the rounding functionality, the new active vs inactive agents check, as well as ensuring the manage auto-upgrades button always renders. Simplified UI with tooltip and button to quickly access auto-upgrade settings for the policy the action belongs to: ![image](https://github.com/user-attachments/assets/44205322-d6ca-40fb-bfb3-c1f26132418b) Updated tooltip to let the user know that rounding is in place: ![image](https://github.com/user-attachments/assets/0d62688e-6d48-4c0a-9b03-a77deb814f1e) Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) N/A --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Supplementing added 17 commits March 12, 2025 14:47

manage auto-upgrade button hooked up, progress semi-added but wrong

3fcaac5

removed some console logs and added a few comments to make it easier …

7f98229

…to tell whats happening

almost have percentages working correctly. Ui is a placeholder for now

5d3bbef

updated types and getActions to send back/expect is_automatic field f…

427b4a3

…or use in ActionStatus

made policy id persistent on automatic upgrade action creation

51b686c

unified actions with same policies, etc

6bd3e89

unified actions (still needs some work around retries), added audit l…

a089f48

…ogging, added retry attempt badge

removed console logs from testing

bd0ef77

changed auto upgrade interval back to 30m

5fbf54c

added is_retry in case we need it later, scaffolded UI changes per ch…

947e9bf

…ristians feedback

finished polishing UI

d6b73c3

pushing for jill to test

5931190

changed UI back to be more simple, removed retry stuff, removed unnee…

a790d36

…ded items due to simpler UI

fixed issue with check to only consider active agents

dc751d7

added integration tests, cleaned up UI, other small changes;

7110e87

removed some comments

ef70ccd

changed interval back, forgot that one;

1da3014

kibanamachine and others added 2 commits March 28, 2025 07:44

small changes to tests, updated translations, and updated some functi…

7ff81d3

…ons to use the correct types

Supplementing marked this pull request as ready for review March 28, 2025 16:58

Supplementing requested a review from a team as a code owner March 28, 2025 16:58

Supplementing added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 28, 2025

Merge branch 'main' into enhancement-report-automatic-upgrade-status

4f63607

Supplementing requested a review from jillguyonnet March 28, 2025 17:13

[CI] Auto-commit changed files from 'make api-docs'

6e25adc

merged in remote changes

295a8c1

juliaElastic reviewed Apr 3, 2025

View reviewed changes

Comment thread x-pack/platform/plugins/shared/fleet/server/tasks/automatic_agent_upgrade_task.ts

juliaElastic mentioned this pull request Apr 3, 2025

[Fleet] Auto upgrade fixes: filter out inactive agents in status API, fix agent fetcher #217024

Merged

1 task

Supplementing mentioned this pull request Apr 3, 2025

[Fleet] Automatic upgrade modal not showing 'in progress' when upgrade starts #217031

Closed

Supplementing enabled auto-merge (squash) April 3, 2025 21:33

juliaElastic reviewed Apr 4, 2025

View reviewed changes

Comment thread ...ications/fleet/sections/agents/components/manage_auto_upgrade_agents_modal/status_column.tsx Outdated

juliaElastic reviewed Apr 4, 2025

View reviewed changes

Comment thread ...ications/fleet/sections/agents/components/manage_auto_upgrade_agents_modal/status_column.tsx Outdated

jillguyonnet reviewed Apr 4, 2025

View reviewed changes

Comment thread .../fleet/sections/agents/agent_list_page/components/agent_activity_flyout/activity_section.tsx Outdated

removed uneeded index variable, fixed plural text, removed check for …

935eb9c

…completed on status column (to be moved to another issue)

added manage button to completed actions that were triggered by auto …

13d5ae0

…upgrades

Supplementing requested review from jillguyonnet and juliaElastic April 4, 2025 16:34

Merge branch 'main' into enhancement-report-automatic-upgrade-status

93c8636

juliaElastic approved these changes Apr 7, 2025

View reviewed changes

jillguyonnet approved these changes Apr 7, 2025

View reviewed changes

Merge branch 'main' into enhancement-report-automatic-upgrade-status

95fcd18

Supplementing merged commit a46e811 into elastic:main Apr 7, 2025

kibanamachine added the v9.1.0 label Apr 7, 2025

Conversation

Supplementing commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

Supplementing commented Mar 28, 2025

Uh oh!

elasticmachine commented Mar 28, 2025

Uh oh!

Supplementing commented Mar 28, 2025

Uh oh!

Supplementing commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jillguyonnet commented Apr 4, 2025

Uh oh!

Supplementing commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sileschristian commented Apr 4, 2025

Uh oh!

Supplementing commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliaElastic left a comment

Choose a reason for hiding this comment

Uh oh!

jillguyonnet commented Apr 7, 2025

Uh oh!

jillguyonnet left a comment

Choose a reason for hiding this comment

Uh oh!

Supplementing commented Apr 7, 2025

Uh oh!

Supplementing commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Apr 7, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Supplementing commented Mar 18, 2025 •

edited

Loading

Supplementing commented Apr 2, 2025 •

edited

Loading

Supplementing commented Apr 4, 2025 •

edited

Loading

Supplementing commented Apr 4, 2025 •

edited

Loading

Supplementing commented Apr 7, 2025 •

edited

Loading