Skip to content

[9.0] [Lens][Datatable] Fix color by value for Last value array mode (#213917)#214919

Merged
kibanamachine merged 1 commit intoelastic:9.0from
kibanamachine:backport/9.0/pr-213917
Mar 18, 2025
Merged

[9.0] [Lens][Datatable] Fix color by value for Last value array mode (#213917)#214919
kibanamachine merged 1 commit intoelastic:9.0from
kibanamachine:backport/9.0/pr-213917

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

…ic#213917)

## Summary

Fixes the table side of elastic#188263

The [fix used for
`Metric`](elastic#209110) has been
generalized and re-used for the datatable visualization.

![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0b9df09)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Mar 18, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) March 18, 2025 09:15
@kibanamachine kibanamachine merged commit ce776ec into elastic:9.0 Mar 18, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1586 1585 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +104.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 49.7KB 49.7KB +13.0B

cc @dej611

nickofthyme added a commit that referenced this pull request Mar 27, 2025
…#213917) (#216118)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Lens][Datatable] Fix color by value for Last value array mode
(#213917)](#213917)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-18T09:09:03Z","message":"[Lens][Datatable]
Fix color by value for Last value array mode (#213917)\n\n##
Summary\n\nFixes the table side of #188263 \n\nThe [fix used
for\n`Metric`](#209110) has
been\ngeneralized and re-used for the datatable
visualization.\n\n\n![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v9.0.0","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Lens][Datatable]
Fix color by value for Last value array
mode","number":213917,"url":"https://github.com/elastic/kibana/pull/213917","mergeCommit":{"message":"[Lens][Datatable]
Fix color by value for Last value array mode (#213917)\n\n##
Summary\n\nFixes the table side of #188263 \n\nThe [fix used
for\n`Metric`](#209110) has
been\ngeneralized and re-used for the datatable
visualization.\n\n\n![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/214919","number":214919,"state":"MERGED","mergeCommit":{"sha":"ce776eca54a3b56d07d2404486162d5050098d26","message":"[9.0]
[Lens][Datatable] Fix color by value for Last value array mode (#213917)
(#214919)\n\n# Backport\n\nThis will backport the following commits from
`main` to `9.0`:\n- [[Lens][Datatable] Fix color by value for Last value
array
mode\n(#213917)](https://github.com/elastic/kibana/pull/213917)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Liberati
<dej611@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213917","number":213917,"mergeCommit":{"message":"[Lens][Datatable]
Fix color by value for Last value array mode (#213917)\n\n##
Summary\n\nFixes the table side of #188263 \n\nThe [fix used
for\n`Metric`](#209110) has
been\ngeneralized and re-used for the datatable
visualization.\n\n\n![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
nickofthyme added a commit that referenced this pull request Mar 28, 2025
…213917) (#216117)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens][Datatable] Fix color by value for Last value array mode
(#213917)](#213917)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-18T09:09:03Z","message":"[Lens][Datatable]
Fix color by value for Last value array mode (#213917)\n\n##
Summary\n\nFixes the table side of #188263 \n\nThe [fix used
for\n`Metric`](#209110) has
been\ngeneralized and re-used for the datatable
visualization.\n\n\n![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v9.0.0","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Lens][Datatable]
Fix color by value for Last value array
mode","number":213917,"url":"https://github.com/elastic/kibana/pull/213917","mergeCommit":{"message":"[Lens][Datatable]
Fix color by value for Last value array mode (#213917)\n\n##
Summary\n\nFixes the table side of #188263 \n\nThe [fix used
for\n`Metric`](#209110) has
been\ngeneralized and re-used for the datatable
visualization.\n\n\n![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/214919","number":214919,"state":"MERGED","mergeCommit":{"sha":"ce776eca54a3b56d07d2404486162d5050098d26","message":"[9.0]
[Lens][Datatable] Fix color by value for Last value array mode (#213917)
(#214919)\n\n# Backport\n\nThis will backport the following commits from
`main` to `9.0`:\n- [[Lens][Datatable] Fix color by value for Last value
array
mode\n(#213917)](https://github.com/elastic/kibana/pull/213917)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Marco Liberati
<dej611@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213917","number":213917,"mergeCommit":{"message":"[Lens][Datatable]
Fix color by value for Last value array mode (#213917)\n\n##
Summary\n\nFixes the table side of #188263 \n\nThe [fix used
for\n`Metric`](#209110) has
been\ngeneralized and re-used for the datatable
visualization.\n\n\n![color_by_value_table](https://github.com/user-attachments/assets/b347dba2-24d7-4233-8c0c-3236f5212f35)\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"0b9df094d1770065f79c05272a41175396caa27b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants