[8.x] [Response Ops] Es query rule "size" field re-initializes to 100 if set to 0 when editing (#213636)#214848
Merged
doakalexi merged 3 commits intoelastic:8.xfrom Mar 18, 2025
Merged
Conversation
…t to 0 when editing (elastic#213636) Resolves elastic#209427 ## Summary This PR fixes a bug when editing an es query rule with size set to 0. I also refactored the tests to use react testing library. ### Checklist Check the PR satisfies following conditions. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### To verify 1. Create an es query rule 2. Set the size to be 0 3. Save your rule 4. Edit your rule and verify that the size is set to 0 when you open the editor (cherry picked from commit 287eb3e)
Merged
1 task
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
ymao1
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation