Skip to content

[Dashboard] Inject / extract tag references #214788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickpeihl merged 18 commits into from
Mar 31, 2025
Merged

[Dashboard] Inject / extract tag references #214788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b02570f
Inject / extract tag references
nickpeihl Mar 17, 2025
16e760e
Fixes
nickpeihl Mar 18, 2025
4ffe843
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Mar 18, 2025
89b1312
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
kibanamachine Mar 18, 2025
bac5e56
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine Mar 19, 2025
8c95da2
Merge branch 'main' into refHandling-tags
nickpeihl Mar 19, 2025
dac9d75
Add api integration tests with tags
nickpeihl Mar 19, 2025
3095adb
Create tag if saved object matching tag name not found
nickpeihl Mar 20, 2025
bfe95bd
Merge branch 'main' of https://github.com/elastic/kibana into refHand…
nickpeihl Mar 24, 2025
64071bb
Fix unit test
nickpeihl Mar 28, 2025
e1b2121
Move tag creation to wrapper function
nickpeihl Mar 28, 2025
ff8e17a
Remove optional params from up transform
nickpeihl Mar 28, 2025
1be9e31
Merge branch 'main' into refHandling-tags
nickpeihl Mar 28, 2025
b1645c7
Fix lint error
nickpeihl Mar 28, 2025
aee4199
Fix functional test failure
nickpeihl Mar 28, 2025
fc9e0e7
Update functional test fixture
nickpeihl Mar 29, 2025
e57d432
Fix test
nickpeihl Mar 31, 2025
c4362c3
Merge branch 'main' into refHandling-tags
nickpeihl Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions oas_docs/bundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6738,6 +6738,13 @@
"description": "A short description.",
"type": "string"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeRestore": {
"default": false,
"description": "Whether to restore time upon viewing this dashboard",
Expand Down Expand Up @@ -7384,6 +7391,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8038,6 +8052,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8576,6 +8597,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -9202,6 +9230,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -9734,6 +9769,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down
42 changes: 42 additions & 0 deletions oas_docs/bundle.serverless.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6738,6 +6738,13 @@
"description": "A short description.",
"type": "string"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeRestore": {
"default": false,
"description": "Whether to restore time upon viewing this dashboard",
Expand Down Expand Up @@ -7384,6 +7391,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8038,6 +8052,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8576,6 +8597,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -9202,6 +9230,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -9734,6 +9769,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down
30 changes: 30 additions & 0 deletions oas_docs/output/kibana.serverless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6168,6 +6168,11 @@ paths:
default: ''
description: A short description.
type: string
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeRestore:
default: false
description: Whether to restore time upon viewing this dashboard
Expand Down Expand Up @@ -6628,6 +6633,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -7093,6 +7103,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -7481,6 +7496,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -7926,6 +7946,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -8310,6 +8335,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down
30 changes: 30 additions & 0 deletions oas_docs/output/kibana.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7703,6 +7703,11 @@ paths:
default: ''
description: A short description.
type: string
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeRestore:
default: false
description: Whether to restore time upon viewing this dashboard
Expand Down Expand Up @@ -8163,6 +8168,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -8628,6 +8638,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -9016,6 +9031,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -9461,6 +9481,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -9845,6 +9870,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down
2 changes: 2 additions & 0 deletions src/platform/plugins/shared/dashboard/public/dashboard_api/get_serialized_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ export const getSerializedState = ({
{ embeddablePersistableStateService: embeddableService }
);

// TODO Provide tags as an array of tag names in the attribute. In that case, tag references
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a followup issue for this?

Copy link
Copy Markdown
Contributor Author

@nickpeihl nickpeihl Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#216346

// will be extracted by the server.
const savedObjectsTaggingApi = savedObjectsTaggingService?.getTaggingApi();
const references = savedObjectsTaggingApi?.ui.updateTagsReferences
? savedObjectsTaggingApi?.ui.updateTagsReferences(dashboardReferences, tags)
Expand Down
Loading