Skip to content

Unauthorized route migration for routes owned by response-ops #214785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elena-shostak merged 2 commits into from
Mar 17, 2025
Merged

Unauthorized route migration for routes owned by response-ops #214785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c18710
[Authz]: Migrated routes owned by response-ops
elena-shostak Mar 17, 2025
a2aa5b4
Merge branch 'main' into authz-migration/response-ops
elena-shostak Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions x-pack/platform/plugins/shared/alerting/server/routes/gaps/apis/fill/fill_gap_by_id_route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ export const fillGapByIdRoute = (
router.post(
{
path: `${INTERNAL_ALERTING_GAPS_FILL_BY_ID_API_PATH}`,
security: {
authz: {
enabled: false,
reason: 'This route delegates authorization to the scoped ES client',
},
},
validate: {
query: fillGapByIdQuerySchemaV1,
},
Expand Down
6 changes: 6 additions & 0 deletions x-pack/platform/plugins/shared/alerting/server/routes/gaps/apis/find/find_gaps_route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ export const findGapsRoute = (
router.post(
{
path: INTERNAL_ALERTING_GAPS_FIND_API_PATH,
security: {
authz: {
enabled: false,
reason: 'This route delegates authorization to the scoped ES client',
},
},
validate: {
body: findGapsBodySchemaV1,
},
Expand Down
6 changes: 6 additions & 0 deletions ...erver/routes/gaps/apis/get_gaps_summary_by_rule_ids/get_gaps_summary_by_rule_ids_route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ export const getGapsSummaryByRuleIdsRoute = (
router.post(
{
path: `${INTERNAL_ALERTING_GAPS_GET_SUMMARY_BY_RULE_IDS_API_PATH}`,
security: {
authz: {
enabled: false,
reason: 'This route delegates authorization to the scoped ES client',
},
},
validate: {
body: getGapsSummaryByRuleIdsBodySchemaV1,
},
Expand Down
6 changes: 6 additions & 0 deletions ...d/alerting/server/routes/gaps/apis/get_rule_ids_with_gaps/get_rule_ids_with_gaps_route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ export const getRuleIdsWithGapsRoute = (
router.post(
{
path: `${INTERNAL_ALERTING_GAPS_GET_RULES_API_PATH}`,
security: {
authz: {
enabled: false,
reason: 'This route delegates authorization to the scoped ES client',
},
},
validate: {
body: getRuleIdsWithGapBodySchemaV1,
},
Expand Down
1 change: 1 addition & 0 deletions x-pack/platform/plugins/shared/cases/server/routes/api/cases/get_case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const getCaseRoute = () =>
export const resolveCaseRoute = createCasesRoute({
method: 'get',
path: `${CASE_DETAILS_URL}/resolve`,
security: DEFAULT_CASES_ROUTE_SECURITY,
routerOptions: {
access: 'internal',
},
Expand Down
2 changes: 2 additions & 0 deletions x-pack/platform/plugins/shared/cases/server/routes/api/cases/similar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ import { INTERNAL_CASE_SIMILAR_CASES_URL } from '../../../../common/constants';
import { createCaseError } from '../../../common/error';
import { createCasesRoute } from '../create_cases_route';
import type { caseApiV1 } from '../../../../common/types/api';
import { DEFAULT_CASES_ROUTE_SECURITY } from '../constants';

export const similarCaseRoute = createCasesRoute({
method: 'post',
path: INTERNAL_CASE_SIMILAR_CASES_URL,
security: DEFAULT_CASES_ROUTE_SECURITY,
params: {
params: schema.object({
case_id: schema.string(),
Expand Down
2 changes: 2 additions & 0 deletions x-pack/platform/plugins/shared/cases/server/routes/api/internal/find_user_actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import type { attachmentApiV1, userActionApiV1 } from '../../../../common/types/
import { INTERNAL_CASE_FIND_USER_ACTIONS_URL } from '../../../../common/constants';
import { createCaseError } from '../../../common/error';
import { createCasesRoute } from '../create_cases_route';
import { DEFAULT_CASES_ROUTE_SECURITY } from '../constants';

const params = {
params: schema.object({
Expand All @@ -22,6 +23,7 @@ const params = {
export const findUserActionsRoute = createCasesRoute({
method: 'get',
path: INTERNAL_CASE_FIND_USER_ACTIONS_URL,
security: DEFAULT_CASES_ROUTE_SECURITY,
params,
routerOptions: {
access: 'public',
Expand Down
2 changes: 2 additions & 0 deletions x-pack/platform/plugins/shared/cases/server/routes/api/observables/delete_observable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ import { schema } from '@kbn/config-schema';
import { INTERNAL_CASE_OBSERVABLES_DELETE_URL } from '../../../../common/constants';
import { createCaseError } from '../../../common/error';
import { createCasesRoute } from '../create_cases_route';
import { DEFAULT_CASES_ROUTE_SECURITY } from '../constants';

export const deleteObservableRoute = createCasesRoute({
method: 'delete',
path: INTERNAL_CASE_OBSERVABLES_DELETE_URL,
security: DEFAULT_CASES_ROUTE_SECURITY,
params: {
params: schema.object({
case_id: schema.string(),
Expand Down
2 changes: 2 additions & 0 deletions x-pack/platform/plugins/shared/cases/server/routes/api/observables/patch_observable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ import { INTERNAL_CASE_OBSERVABLES_PATCH_URL } from '../../../../common/constant
import { createCaseError } from '../../../common/error';
import { createCasesRoute } from '../create_cases_route';
import type { observableApiV1 } from '../../../../common/types/api';
import { DEFAULT_CASES_ROUTE_SECURITY } from '../constants';

export const patchObservableRoute = createCasesRoute({
method: 'patch',
path: INTERNAL_CASE_OBSERVABLES_PATCH_URL,
security: DEFAULT_CASES_ROUTE_SECURITY,
params: {
params: schema.object({
case_id: schema.string(),
Expand Down
2 changes: 2 additions & 0 deletions x-pack/platform/plugins/shared/cases/server/routes/api/observables/post_observable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ import { INTERNAL_CASE_OBSERVABLES_URL } from '../../../../common/constants';
import { createCaseError } from '../../../common/error';
import { createCasesRoute } from '../create_cases_route';
import type { observableApiV1 } from '../../../../common/types/api';
import { DEFAULT_CASES_ROUTE_SECURITY } from '../constants';

export const postObservableRoute = createCasesRoute({
method: 'post',
path: INTERNAL_CASE_OBSERVABLES_URL,
security: DEFAULT_CASES_ROUTE_SECURITY,
params: {
params: schema.object({
case_id: schema.string(),
Expand Down