Storybook 8 Upgrade Follow Up#214684
Merged
Ikuni17 merged 10 commits intoelastic:mainfrom Mar 24, 2025
Merged
Conversation
Ikuni17
added
release_note:skip
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
sabarasaba
approved these changes
Mar 18, 2025
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
kibana management changes lgtm
jughosta
approved these changes
Mar 18, 2025
Contributor
jughosta
left a comment
jughosta
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM 👍
nikitaindik
approved these changes
Mar 18, 2025
Contributor
nikitaindik
left a comment
nikitaindik
left a comment
There was a problem hiding this comment.
Thanks @Ikuni17! I've tested updated Rule Management owned stories and can confirm that they do work. Some of our stories are broken, but it's unrelated to this PR and we'll fix them in the future.
LGTM from the Rules Management 👍
ThomThomson
approved these changes
Mar 18, 2025
kowalczyk-krzysztof
approved these changes
Mar 20, 2025
Contributor
|
@kfirpeled the graph storybook doesn't show graph components for some reason. The same behavior I see in |
Contributor
Author
Contributor
|
@Ikuni17 yes, see screenshot. In the storybook built for this PR no graph is being displayed 
|
kfirpeled
approved these changes
Mar 24, 2025
Contributor
kfirpeled
left a comment
kfirpeled
left a comment
There was a problem hiding this comment.
I don't know yet what causes the graph not to appear, I approve the PR so it won't block you. I'll continue to investigate
Contributor
Author
|
@kfirpeled Thanks, I can take a look in a follow up PR as well. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @Ikuni17 |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
## Summary These Stories were missed in [Upgrade to Storybook 8 (elastic#195148)](elastic#195148) and should be migrated to the same format as other stories for consistency and to make future migrations easier. They technically work in SB8, I forgot to run the migration script again later on while working on the original PR. The changes have already been backported to elastic#214680 and elastic#214681
kfirpeled
added a commit
that referenced
this pull request
Apr 16, 2025
## Summary This fixes the graph layout stories not rendering properly after #214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 16, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com> (cherry picked from commit a7796cd)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 16, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com> (cherry picked from commit a7796cd)
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Apr 17, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary This fixes the graph layout stories not rendering properly after elastic#214684. Open to a better or preferred fix as I'm not familiar with these components. There was a console warning: ```js [React Flow]: The React Flow parent container needs a width and a height to render the graph. Help: https://reactflow.dev/error#004 ``` [Storybook preview link](https://ci-artifacts.kibana.dev/storybooks/pr-217766/cloud_security_posture_graph/index.html?path=/story/components-graph-components-graph-layout--simple-api-mock) --------- Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These Stories were missed in Upgrade to Storybook 8 (#195148) and should be migrated to the same format as other stories for consistency and to make future migrations easier. They technically work in SB8, I forgot to run the migration script again later on while working on the original PR.
The changes have already been backported to #214680 and #214681