[Fleet] Fix fleet server policy creation with non es default output#214590

Merged

nchaulet merged 10 commits intoelastic:mainfrom

nchaulet:fix-fleet-server-policy-creation-logstash-host

Mar 17, 2025

Member

nchaulet commented Mar 14, 2025 •

edited by kibanamachine

Loading

Summary

Resolve #208024

User were not able to create a fleet server policy when using a default logstash output without an enterprise license, this was due to a few bug in our validations, and no errors were displayed as we were missing error handling here.

That PR fix that by showing error message, and fixing the validation rules to allow a user to be able to create a fleet server policy in the advanced section with a custom output.

I considered trying to "magically" fix this by creating a ES output if none exists or trying to select one, but it seems to me we should probably not make that decision for the user, and having a better error reporting and fixing bugs in our form should do it. In my mind if they want to use a logstash output, they are a little familiar on how to create/select output.

Where should we backport that one? 9.0 and 8.18?

How to tests

With 2 outputs, one default logstash and one es, and no enterprise license

Screenshot 2025-03-14 at 10 18 34 AM

Trying to create a policy with the quick start fail with an explict message

Screenshot 2025-03-14 at 9 53 13 AM

Trying to create a policy from the advanced section also display an error message

Screenshot 2025-03-14 at 10 01 55 AM

The error is correctable and we allow to select an ES output

Screenshot 2025-03-14 at 10 05 18 AM

Screenshot 2025-03-14 at 10 07 23 AM

Todo

update unit tests

nchaulet added 2 commits

March 13, 2025 18:25


          [Fleet] Allow to create a fleet server policy when using a default lo…

d397513

…gsash output


          fix server side

2ce5f3c

nchaulet added release_note:skip Team:Fleet backport:prev-minor backport:version v8.18.1 labels

nchaulet self-assigned this

nchaulet requested a review from a team as a code owner

March 14, 2025 14:22

Contributor

elasticmachine commented Mar 14, 2025

Pinging @elastic/fleet (Team:Fleet)

kibanamachine added 2 commits

March 14, 2025 14:38


          [CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…

9510daa

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/dashboards --update'


          [CI] Auto-commit changed files from 'make api-docs'

db3315c

nchaulet commented

View reviewed changes

...public/applications/fleet/components/fleet_server_instructions/hooks/use_quick_start_form.ts Outdated Show resolved Hide resolved


          fix linting

001bfa6

jen-huang approved these changes

View reviewed changes

Contributor

jen-huang left a comment

Agree on the approach here where we explicitly tell the user what went wrong. I think we should backport to all open branches.

LGTM 🚀

nchaulet added 2 commits

March 14, 2025 15:53


          Merge branch 'fix-fleet-server-policy-creation-logstash-host' of gith…

1edf544

…ub.com:nchaulet/kibana into fix-fleet-server-policy-creation-logstash-host


          fix linting

Member Author

nchaulet commented Mar 16, 2025

@elasticmachine merge upstream

elasticmachine and others added 2 commits

March 16, 2025 21:43


          Merge branch 'main' into fix-fleet-server-policy-creation-logstash-host

8cb333e


          fix tests

97e58d8

Member Author

nchaulet commented Mar 17, 2025

@elasticmachine merge upstream


          Merge branch 'main' into fix-fleet-server-policy-creation-logstash-host

5b8aa95

Contributor

elasticmachine commented Mar 17, 2025

💚 Build Succeeded

Buildkite Build
Commit: 5b8aa95

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.7MB	1.7MB	+698.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	158.9KB	159.3KB	+449.0B

History

💛 Build #284628 was flaky 97e58d8
💔 Build #284402 failed 8cb333e
💔 Build #284302 failed 1edf544
💔 Build #284162 failed db3315c

nchaulet merged commit 6ed6d02 into elastic:main

10 checks passed

kibanamachine added the v9.1.0 label

Contributor

kibanamachine commented Mar 17, 2025

Starting backport for target branches: 8.18, 9.0

https://github.com/elastic/kibana/actions/runs/13907951013

Contributor

kibanamachine commented Mar 17, 2025

💔 All backports failed

Status	Branch	Result
❌	8.18	Backport failed because of merge conflicts
❌	9.0	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 214590

Questions ?

Please refer to the Backport tool documentation

kibanamachine added the backport missing label

Contributor

kibanamachine commented Mar 18, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

1 similar comment

Contributor

kibanamachine commented Mar 19, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

kibanamachine mentioned this pull request

[DOCS] Add minimal task manager health APIs #213862

Merged

9 tasks

Contributor

kibanamachine commented Mar 27, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

9 similar comments

Contributor

kibanamachine commented Mar 28, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Mar 31, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 1, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

kibanamachine mentioned this pull request

[Security Solution] Improving documentations for bulk_actions #216852

Merged

Contributor

kibanamachine commented Apr 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

kibanamachine mentioned this pull request

[DOCS] Add minimal synthetic APIs #214518

Merged

9 tasks

Contributor

kibanamachine commented Apr 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

5 similar comments

Contributor

kibanamachine commented Apr 14, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 15, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

Contributor

kibanamachine commented Apr 18, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 214590 locally

nchaulet mentioned this pull request

[9.0] [Fleet] Fix fleet server policy creation with non es default output (#214590) #218655

Merged

nchaulet added a commit to nchaulet/kibana that referenced this pull request


          [Fleet] Fix fleet server policy creation with non es default output (e…

8eef50f

…lastic#214590)

(cherry picked from commit 6ed6d02)

# Conflicts:
#	x-pack/platform/plugins/shared/fleet/public/hooks/use_request/agent_policy.ts
#	x-pack/test/fleet_api_integration/apis/agent_policy/agent_policy.ts

nchaulet mentioned this pull request

[8.18] [Fleet] Fix fleet server policy creation with non es default output (#214590) #218656

Merged

Member Author

nchaulet commented Apr 18, 2025

💚 All backports created successfully

Status	Branch	Result
✅	9.0
✅	8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nchaulet added a commit to nchaulet/kibana that referenced this pull request


          [Fleet] Fix fleet server policy creation with non es default output (e…

51408f4

…lastic#214590)

(cherry picked from commit 6ed6d02)

# Conflicts:
#	oas_docs/bundle.json
#	oas_docs/bundle.serverless.json
#	oas_docs/output/kibana.yaml
#	x-pack/platform/plugins/shared/fleet/public/hooks/use_request/agent_policy.ts
#	x-pack/platform/plugins/shared/fleet/server/routes/schema/errors.ts
#	x-pack/platform/plugins/shared/fleet/server/services/agent_policy.ts
#	x-pack/test/fleet_api_integration/apis/agent_policy/agent_policy.ts

Contributor

kibanamachine commented Apr 21, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

nchaulet added a commit that referenced this pull request


          [8.18] [Fleet] Fix fleet server policy creation with non es default o…

7734d99

…utput (#214590) (#218656)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Fleet] Fix fleet server policy creation with non es default output
(#214590)](#214590)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2025-03-17T19:14:25Z","message":"[Fleet]
Fix fleet server policy creation with non es default output
(#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:Fleet","backport:prev-minor","backport:version","v9.1.0","v8.18.1"],"title":"[Fleet]
Fix fleet server policy creation with non es default
output","number":214590,"url":"https://github.com/elastic/kibana/pull/214590","mergeCommit":{"message":"[Fleet]
Fix fleet server policy creation with non es default output
(#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214590","number":214590,"mergeCommit":{"message":"[Fleet]
Fix fleet server policy creation with non es default output
(#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

nchaulet added a commit that referenced this pull request


          [9.0] [Fleet] Fix fleet server policy creation with non es default ou…

b8a46e0

…tput (#214590) (#218655)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Fleet] Fix fleet server policy creation with non es default output
(#214590)](#214590)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2025-03-17T19:14:25Z","message":"[Fleet]
Fix fleet server policy creation with non es default output
(#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:Fleet","backport:prev-minor","backport:version","v9.1.0","v8.18.1"],"title":"[Fleet]
Fix fleet server policy creation with non es default
output","number":214590,"url":"https://github.com/elastic/kibana/pull/214590","mergeCommit":{"message":"[Fleet]
Fix fleet server policy creation with non es default output
(#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214590","number":214590,"mergeCommit":{"message":"[Fleet]
Fix fleet server policy creation with non es default output
(#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine added v9.0.1 and removed backport missing labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version release_note:skip Team:Fleet v8.18.1 v9.0.1 v9.1.0