Skip to content

[8.16] [Threat Hunting Investigations] Fix timeline column width bug (#214178)#214520

Merged
janmonschke merged 2 commits intoelastic:8.16from
janmonschke:backport/8.16/pr-214178
Mar 14, 2025
Merged

[8.16] [Threat Hunting Investigations] Fix timeline column width bug (#214178)#214520
janmonschke merged 2 commits intoelastic:8.16from
janmonschke:backport/8.16/pr-214178

Conversation

@janmonschke
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…c#214178)

## Summary

Fixes: elastic#213754

The issue above describes a bug in timeline that makes it impossible to
change the width of a timeline column. This PR fixes that issue and
makes sure that timeline column width settings are saved to
localStorage. This mimics the behaviour of the alerts table elsewhere in
security solution.

https://github.com/user-attachments/assets/8b9803a0-406d-4f2d-ada5-4c0b76cd6ab8

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit edbc618)

# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/timeline/unified_components/data_table/index.tsx
#	x-pack/plugins/security_solution/public/timelines/store/helpers.test.ts
#	x-pack/plugins/security_solution/public/timelines/store/helpers.ts
#	x-pack/plugins/security_solution/public/timelines/store/middlewares/create_timeline_middlewares.ts
#	x-pack/plugins/security_solution/public/timelines/store/middlewares/timeline_localstorage.test.ts
#	x-pack/plugins/security_solution/public/timelines/store/middlewares/timeline_localstorage.ts
@janmonschke janmonschke added the backport This PR is a backport of another PR label Mar 14, 2025
@janmonschke janmonschke enabled auto-merge (squash) March 14, 2025 08:41
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / useExpandedCard Hook when the card is expanded manually when scroll is enabled should scroll
  • [job] [logs] Jest Tests #10 / useTimelineEventsHandler should mock cache for active timeline when switching page

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6297 6298 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +951.0B

History

@janmonschke janmonschke merged commit f219410 into elastic:8.16 Mar 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants