Skip to content

[8.17] [Threat Hunting Investigations] Fix timeline column width bug (#214178)#214519

Merged
janmonschke merged 1 commit intoelastic:8.17from
janmonschke:backport/8.17/pr-214178
Mar 14, 2025
Merged

[8.17] [Threat Hunting Investigations] Fix timeline column width bug (#214178)#214519
janmonschke merged 1 commit intoelastic:8.17from
janmonschke:backport/8.17/pr-214178

Conversation

@janmonschke
Copy link
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

…c#214178)

## Summary

Fixes: elastic#213754

The issue above describes a bug in timeline that makes it impossible to
change the width of a timeline column. This PR fixes that issue and
makes sure that timeline column width settings are saved to
localStorage. This mimics the behaviour of the alerts table elsewhere in
security solution.

https://github.com/user-attachments/assets/8b9803a0-406d-4f2d-ada5-4c0b76cd6ab8

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit edbc618)

# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/timeline/unified_components/data_table/index.tsx
#	x-pack/plugins/security_solution/public/timelines/store/middlewares/create_timeline_middlewares.ts
#	x-pack/plugins/security_solution/public/timelines/store/middlewares/timeline_localstorage.test.ts
#	x-pack/plugins/security_solution/public/timelines/store/middlewares/timeline_localstorage.ts
@janmonschke janmonschke added the backport This PR is a backport of another PR label Mar 14, 2025
@janmonschke janmonschke enabled auto-merge (squash) March 14, 2025 08:33
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 14, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6479 6480 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.8MB 8.8MB +411.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 79.1KB 79.0KB -67.0B

History

@janmonschke janmonschke merged commit 0323c62 into elastic:8.17 Mar 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants