Skip to content

[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for Cloud Environments#214404

Merged
markjhoy merged 3 commits intoelastic:8.xfrom
markjhoy:markjhoy/8.x_ent-search_deprecation_cleanup_text
Mar 13, 2025
Merged

[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for Cloud Environments#214404
markjhoy merged 3 commits intoelastic:8.xfrom
markjhoy:markjhoy/8.x_ent-search_deprecation_cleanup_text

Conversation

@markjhoy
Copy link
Contributor

Summary

Updates the text for the flyout for the Enterprise Search node deprecation. The text includes verbiage asking the user to remove the configuration variables for Enterprise Search - in Cloud environments, this is taken care of already for the user when the node is removed from the deployment. This PR just hides that text (it will still show in non-Cloud environments)

image

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Unit or functional tests were updated or added to match the most common scenarios
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.

Copy link
Contributor

@mridula-s109 mridula-s109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markjhoy markjhoy enabled auto-merge (squash) March 13, 2025 15:42
@markjhoy markjhoy merged commit e7e9254 into elastic:8.x Mar 13, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@markjhoy
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

markjhoy added a commit to markjhoy/kibana that referenced this pull request Mar 13, 2025
…oud Environments (elastic#214404)

## Summary

Updates the text for the flyout for the Enterprise Search node
deprecation. The text includes verbiage asking the user to remove the
configuration variables for Enterprise Search - in Cloud environments,
this is taken care of already for the user when the node is removed from
the deployment. This PR just hides that text (it will still show in
non-Cloud environments)

![image](https://github.com/user-attachments/assets/f10620b6-25f8-4226-a851-95f242ed3369)

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.

(cherry picked from commit e7e9254)
markjhoy added a commit that referenced this pull request Mar 13, 2025
… for Cloud Environments (#214404) (#214460)

# Backport

This will backport the following commits from `8.x` to `8.18`:
- [[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for
Cloud Environments
(#214404)](#214404)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Mark J.
Hoy","email":"mark.hoy@elastic.co"},"sourceCommit":{"committedDate":"2025-03-13T17:34:45Z","message":"[8.x]
[Enterprise Search] Update Text in UA Deprecation Flyout for Cloud
Environments (#214404)\n\n## Summary\n\nUpdates the text for the flyout
for the Enterprise Search node\ndeprecation. The text includes verbiage
asking the user to remove the\nconfiguration variables for Enterprise
Search - in Cloud environments,\nthis is taken care of already for the
user when the node is removed from\nthe deployment. This PR just hides
that text (it will still show in\nnon-Cloud
environments)\n\n\n![image](https://github.com/user-attachments/assets/f10620b6-25f8-4226-a851-95f242ed3369)\n\n\n###
Checklist\n\n- [x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] This was
checked for breaking HTTP API changes, and any breaking\nchanges have
been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.","sha":"e7e92547656be37e1b4725e39f0d174717f57e95","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Upgrade
Assistant","Team:EnterpriseSearch","v8.19.0","backport:8.18","v8.18.1"],"title":"[8.x]
[Enterprise Search] Update Text in UA Deprecation Flyout for Cloud
Environments","number":214404,"url":"https://github.com/elastic/kibana/pull/214404","mergeCommit":{"message":"[8.x]
[Enterprise Search] Update Text in UA Deprecation Flyout for Cloud
Environments (#214404)\n\n## Summary\n\nUpdates the text for the flyout
for the Enterprise Search node\ndeprecation. The text includes verbiage
asking the user to remove the\nconfiguration variables for Enterprise
Search - in Cloud environments,\nthis is taken care of already for the
user when the node is removed from\nthe deployment. This PR just hides
that text (it will still show in\nnon-Cloud
environments)\n\n\n![image](https://github.com/user-attachments/assets/f10620b6-25f8-4226-a851-95f242ed3369)\n\n\n###
Checklist\n\n- [x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] This was
checked for breaking HTTP API changes, and any breaking\nchanges have
been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.","sha":"e7e92547656be37e1b4725e39f0d174717f57e95"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants