[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for Cloud Environments#214404
Merged
markjhoy merged 3 commits intoelastic:8.xfrom Mar 13, 2025
Conversation
efegurkan
approved these changes
Mar 13, 2025
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
markjhoy
added a commit
to markjhoy/kibana
that referenced
this pull request
Mar 13, 2025
…oud Environments (elastic#214404) ## Summary Updates the text for the flyout for the Enterprise Search node deprecation. The text includes verbiage asking the user to remove the configuration variables for Enterprise Search - in Cloud environments, this is taken care of already for the user when the node is removed from the deployment. This PR just hides that text (it will still show in non-Cloud environments)  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. (cherry picked from commit e7e9254)
markjhoy
added a commit
that referenced
this pull request
Mar 13, 2025
… for Cloud Environments (#214404) (#214460) # Backport This will backport the following commits from `8.x` to `8.18`: - [[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for Cloud Environments (#214404)](#214404) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mark J. Hoy","email":"mark.hoy@elastic.co"},"sourceCommit":{"committedDate":"2025-03-13T17:34:45Z","message":"[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for Cloud Environments (#214404)\n\n## Summary\n\nUpdates the text for the flyout for the Enterprise Search node\ndeprecation. The text includes verbiage asking the user to remove the\nconfiguration variables for Enterprise Search - in Cloud environments,\nthis is taken care of already for the user when the node is removed from\nthe deployment. This PR just hides that text (it will still show in\nnon-Cloud environments)\n\n\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.","sha":"e7e92547656be37e1b4725e39f0d174717f57e95","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Upgrade Assistant","Team:EnterpriseSearch","v8.19.0","backport:8.18","v8.18.1"],"title":"[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for Cloud Environments","number":214404,"url":"https://github.com/elastic/kibana/pull/214404","mergeCommit":{"message":"[8.x] [Enterprise Search] Update Text in UA Deprecation Flyout for Cloud Environments (#214404)\n\n## Summary\n\nUpdates the text for the flyout for the Enterprise Search node\ndeprecation. The text includes verbiage asking the user to remove the\nconfiguration variables for Enterprise Search - in Cloud environments,\nthis is taken care of already for the user when the node is removed from\nthe deployment. This PR just hides that text (it will still show in\nnon-Cloud environments)\n\n\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.","sha":"e7e92547656be37e1b4725e39f0d174717f57e95"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the text for the flyout for the Enterprise Search node deprecation. The text includes verbiage asking the user to remove the configuration variables for Enterprise Search - in Cloud environments, this is taken care of already for the user when the node is removed from the deployment. This PR just hides that text (it will still show in non-Cloud environments)
Checklist
release_note:breakinglabel should be applied in these situations.