Skip to content

[9.0] [Security Solution] Avoid showing rules update confirmation modal on basic license (#214340) #214385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Mar 13, 2025
Merged

[9.0] [Security Solution] Avoid showing rules update confirmation modal on basic license (#214340) #214385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions ...ity_solution/public/detection_engine/rule_management/hooks/use_prebuilt_rules_upgrade.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,21 @@ export function usePrebuiltRulesUpgrade({
return;
}

await upgradeRulesWithDryRun({
mode: 'ALL_RULES',
pick_version: isRulesCustomizationEnabled ? 'MERGED' : 'TARGET',
filter,
});
if (isRulesCustomizationEnabled) {
await upgradeRulesWithDryRun({
mode: 'ALL_RULES',
pick_version: 'MERGED',
filter,
});
} else {
// Upgrading prebuilt rules to TARGET version will erase any rule customizations.
// It's unnecessary to run a dry run request since we don't expect skipped rules.
await upgradeRulesRequest({
mode: 'ALL_RULES',
pick_version: 'TARGET',
filter,
});
}
} catch {
// Error is handled by the mutation's onError callback, so no need to do anything here
} finally {
Expand All @@ -214,6 +224,7 @@ export function usePrebuiltRulesUpgrade({
}, [
upgradeableRules,
upgradeRulesWithDryRun,
upgradeRulesRequest,
confirmLegacyMLJobs,
isRulesCustomizationEnabled,
filter,
Expand Down