[Security Solution] Hide conflict badges when rule customization is not enabled#214365
Merged
nikitaindik merged 1 commit intoelastic:mainfrom Mar 13, 2025
Conversation
nikitaindik
added
release_note:skip
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
xcrzx
approved these changes
Mar 13, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13837619355 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
cc @nikitaindik |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2025
…ot enabled (elastic#214365) **Resolves: elastic#214301 ## Summary This PR removes conflict badges from the Rule Updates table for users with license that is insufficient for prebuilt rule customization. **Before (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 44 07" src="https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786" /> **After (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 39 01" src="https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227" /> Since users on Basic license can't customize rules, it doesn't make sense to show these badges - they are not actionable anyways. Users will still see a callout mentioning that their modifications will be erased if they open a flyout for a customized rule. <img width="953" alt="Schermafbeelding 2025-03-13 om 13 41 21" src="https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6" /> (cherry picked from commit 9f2e07f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2025
…ot enabled (elastic#214365) **Resolves: elastic#214301 ## Summary This PR removes conflict badges from the Rule Updates table for users with license that is insufficient for prebuilt rule customization. **Before (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 44 07" src="https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786" /> **After (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 39 01" src="https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227" /> Since users on Basic license can't customize rules, it doesn't make sense to show these badges - they are not actionable anyways. Users will still see a callout mentioning that their modifications will be erased if they open a flyout for a customized rule. <img width="953" alt="Schermafbeelding 2025-03-13 om 13 41 21" src="https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6" /> (cherry picked from commit 9f2e07f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2025
…ot enabled (elastic#214365) **Resolves: elastic#214301 ## Summary This PR removes conflict badges from the Rule Updates table for users with license that is insufficient for prebuilt rule customization. **Before (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 44 07" src="https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786" /> **After (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 39 01" src="https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227" /> Since users on Basic license can't customize rules, it doesn't make sense to show these badges - they are not actionable anyways. Users will still see a callout mentioning that their modifications will be erased if they open a flyout for a customized rule. <img width="953" alt="Schermafbeelding 2025-03-13 om 13 41 21" src="https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6" /> (cherry picked from commit 9f2e07f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
…n is not enabled (#214365) (#214410) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)](#214365) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-03-13T14:52:48Z","message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Hide conflict badges when rule customization is not enabled","number":214365,"url":"https://github.com/elastic/kibana/pull/214365","mergeCommit":{"message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214365","number":214365,"mergeCommit":{"message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
…on is not enabled (#214365) (#214407) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)](#214365) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-03-13T14:52:48Z","message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Hide conflict badges when rule customization is not enabled","number":214365,"url":"https://github.com/elastic/kibana/pull/214365","mergeCommit":{"message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214365","number":214365,"mergeCommit":{"message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
…n is not enabled (#214365) (#214408) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)](#214365) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-03-13T14:52:48Z","message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Hide conflict badges when rule customization is not enabled","number":214365,"url":"https://github.com/elastic/kibana/pull/214365","mergeCommit":{"message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214365","number":214365,"mergeCommit":{"message":"[Security Solution] Hide conflict badges when rule customization is not enabled (#214365)\n\n**Resolves: https://github.com/elastic/kibana/issues/214301**\n\n## Summary\n\nThis PR removes conflict badges from the Rule Updates table for users\nwith license that is insufficient for prebuilt rule customization.\n\n**Before (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 44 07\"\nsrc=\"https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786\"\n/>\n\n\n**After (on Basic license)**\n<img width=\"1014\" alt=\"Schermafbeelding 2025-03-13 om 13 39 01\"\nsrc=\"https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227\"\n/>\n\nSince users on Basic license can't customize rules, it doesn't make\nsense to show these badges - they are not actionable anyways.\n\nUsers will still see a callout mentioning that their modifications will\nbe erased if they open a flyout for a customized rule.\n\n<img width=\"953\" alt=\"Schermafbeelding 2025-03-13 om 13 41 21\"\nsrc=\"https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6\"\n/>","sha":"9f2e07f2dedce88e51b80afd0cb215b6467c8f37"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…ot enabled (elastic#214365) **Resolves: elastic#214301 ## Summary This PR removes conflict badges from the Rule Updates table for users with license that is insufficient for prebuilt rule customization. **Before (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 44 07" src="https://github.com/user-attachments/assets/fd830253-80d0-4250-861c-88b0a11d6786" /> **After (on Basic license)** <img width="1014" alt="Schermafbeelding 2025-03-13 om 13 39 01" src="https://github.com/user-attachments/assets/f8b00964-72bf-4d0a-9f03-9e47231c5227" /> Since users on Basic license can't customize rules, it doesn't make sense to show these badges - they are not actionable anyways. Users will still see a callout mentioning that their modifications will be erased if they open a flyout for a customized rule. <img width="953" alt="Schermafbeelding 2025-03-13 om 13 41 21" src="https://github.com/user-attachments/assets/b2a2514e-2b19-4653-9076-d742130b30b6" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #214301
Summary
This PR removes conflict badges from the Rule Updates table for users with license that is insufficient for prebuilt rule customization.
Before (on Basic license)
After (on Basic license)
Since users on Basic license can't customize rules, it doesn't make sense to show these badges - they are not actionable anyways.
Users will still see a callout mentioning that their modifications will be erased if they open a flyout for a customized rule.