[8.17] [Feature Flags] Retry provider setup (#214200)#214299
Merged
afharo merged 1 commit intoelastic:8.17from Mar 13, 2025
Merged
[8.17] [Feature Flags] Retry provider setup (#214200)#214299afharo merged 1 commit intoelastic:8.17from
afharo merged 1 commit intoelastic:8.17from
Conversation
## Summary We identified that on some occasions, the Feature Flags provider times out when setting up, and, since we don't restart the Kibana server, it never sets it up. This PR adds a retry logic to try to set the provider in case there's an error. cc @pmuellr as he found out about this bug ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 1337c11) # Conflicts: # packages/core/feature-flags/core-feature-flags-server-internal/src/feature_flags_service.ts # packages/core/feature-flags/core-feature-flags-server-internal/src/set_provider_with_retries.test.ts # packages/core/feature-flags/core-feature-flags-server-internal/src/set_provider_with_retries.ts
1 task
gsoldevila
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation