Skip to content

[Obs AI Assistant] Forward telemetryMetadata.pluginId to the EIS use case header #214285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viduni94 merged 4 commits into from
Mar 13, 2025
Merged

[Obs AI Assistant] Forward telemetryMetadata.pluginId to the EIS use case header #214285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
488b53d
Forward plugin ID
viduni94 Mar 12, 2025
c65e29c
Update tests
viduni94 Mar 12, 2025
2fcab52
Update tests
viduni94 Mar 13, 2025
9a97da3
Merge branch 'main' into forward-plugin-id-to-eis-use-case-header
viduni94 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...ck/platform/plugins/shared/observability_ai_assistant/server/service/client/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,11 @@ describe('Observability AI Assistant client', () => {
functionCalling: 'auto',
toolChoice: undefined,
tools: undefined,
metadata: {
connectorTelemetry: {
pluginId: 'observability_ai_assistant',
},
},
},
]);
});
Expand Down Expand Up @@ -847,6 +852,11 @@ describe('Observability AI Assistant client', () => {
functionCalling: 'auto',
toolChoice: 'auto',
tools: expect.any(Object),
metadata: {
connectorTelemetry: {
pluginId: 'observability_ai_assistant',
},
},
},
]);
});
Expand Down Expand Up @@ -996,6 +1006,11 @@ describe('Observability AI Assistant client', () => {
functionCalling: 'auto',
toolChoice: 'auto',
tools: expect.any(Object),
metadata: {
connectorTelemetry: {
pluginId: 'observability_ai_assistant',
},
},
},
]);
});
Expand Down
5 changes: 5 additions & 0 deletions x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,11 @@ export class ObservabilityAIAssistantClient {
toolChoice,
tools,
functionCalling: (simulateFunctionCalling ? 'simulated' : 'auto') as FunctionCallingMode,
metadata: {
connectorTelemetry: {
Copy link
Copy Markdown
Contributor

@stephmilovic stephmilovic Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the field is called telemetryMetadata, and should exist at the subActionParams level of the execute request. For example:

subActionParams: {
    telemetryMetadata: {
        pluginId: 'observability_ai_assistant'
    }
}

I've not used the inferenceClient.chatComplete, but you'll want to make sure this data is at the subActionParams level of wherever the connector call is being made

Copy link
Copy Markdown
Contributor Author

@viduni94 viduni94 Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stephmilovic

The Inference ChatComplete API has metadata:

kibana/x-pack/platform/packages/shared/ai-infra/inference-common/src/chat_complete/api.ts

Line 116 in 6a3becf

metadata?: ChatCompleteMetadata;

And that has connectorTelemetry -

kibana/x-pack/platform/packages/shared/ai-infra/inference-common/src/chat_complete/metadata.ts

Lines 13 to 15 in 6a3becf

export interface ChatCompleteMetadata {
connectorTelemetry?: ConnectorTelemetryMetadata;
}

And in the inference adapter, it gets passed as subActionParams to telemetryMetadata:

kibana/x-pack/platform/plugins/shared/inference/server/chat_complete/adapters/inference/inference_adapter.ts

Lines 49 to 54 in 6a3becf

subActionParams: {
body: request,
signal: abortSignal,
...(metadata?.connectorTelemetry
? { telemetryMetadata: metadata.connectorTelemetry }
: {}),

Copy link
Copy Markdown
Contributor

@stephmilovic stephmilovic Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks!

pluginId: 'observability_ai_assistant',
},
},
};

this.dependencies.logger.debug(
Expand Down