[8.17] Alerts table in Rule Preview panel fills container width (#214028)#214271
Closed
kibanamachine wants to merge 1 commit intoelastic:8.17from
Closed
[8.17] Alerts table in Rule Preview panel fills container width (#214028)#214271kibanamachine wants to merge 1 commit intoelastic:8.17from
kibanamachine wants to merge 1 commit intoelastic:8.17from
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
) ## Summary Addresses elastic#213706. I suspect that this stopped working when elastic#206523 removed the `FullScreenContainer` from the inner StatefulEventsViewer component; that change combined with the `display:flex` on this parent element caused the table to no longer grow as expected. Luckily, the fix here was simply not using flexbox on the container. Since the table is the only element within this container, I saw no reason why flexbox was needed here; testing has confirmed this. ### Screenshot (after fix; see bug for "before" image) <kbd><img width="1709" alt="Screenshot 2025-03-11 at 5 35 43 PM" src="https://github.com/user-attachments/assets/108be815-00e2-48b7-8821-e63566eefa09" /></kbd> (cherry picked from commit 01e31ea)
kibanamachine
force-pushed
the
backport/8.17/pr-214028
branch
from
fa5a81b to
09179ff
Compare
Contributor
|
Unneeded here, as the bug didn't make it back this far (only to 8.18). |
auto-merge was automatically disabled
March 12, 2025 19:30
Pull request was closed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation