[8.x] [Discover] Added context aware logic for logs view in discover to show Load More… (#211176)#214229
Merged
achyutjhunjhunwala merged 4 commits intoelastic:8.xfrom Mar 13, 2025
Conversation
…w Load More… (elastic#211176) ## Summary Closes - elastic#166679 ## What's included ? - The PR adds a feature in Logs View of Observability (to start with) to hide the regular pagination toolbar from the footer and show Load More only when the user has scrolled to the bottom of the page. - The table would always load the items in batches of default set 500 - This PR also add 2 helper functions `useThrottleFn` and `useDebounceFn`. Current React help library which KIbana uses called -`react-use` does not have these and we cannot use Lodash variant of these. We need such hooks which are React safe. Hence added these 2 ## What's pending ? - [x] Unit tests for the 2 new helper React hooks - [x] Unit tests for data table footer component - [x] Unit tests for Profile Resolution - [x] Functional Serverless Tests - [x] Functional Stateful Tests  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Davis McPhee <davismcphee@hotmail.com> Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> Co-authored-by: Davis McPhee <davis.mcphee@elastic.co> (cherry picked from commit 591c5b7) # Conflicts: # .github/CODEOWNERS # src/platform/packages/shared/kbn-unified-data-table/tsconfig.json # src/platform/plugins/shared/discover/public/application/main/components/layout/discover_documents.test.tsx
5 tasks
Contributor
💔 Build Failed
Failed CI StepsHistory |
yngrdyn
approved these changes
Mar 13, 2025
Contributor
yngrdyn
left a comment
yngrdyn
left a comment
There was a problem hiding this comment.
Approving manual backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation