[Fleet] Allow to override data stream type in policies for input packages #214216
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { | ||
| ADD_INTEGRATION_POLICY_BTN, | ||
| CREATE_PACKAGE_POLICY_SAVE_BTN, | ||
| INTEGRATION_NAME_LINK, | ||
| POLICY_EDITOR, | ||
| } from '../screens/integrations'; | ||
| import { EXISTING_HOSTS_TAB } from '../screens/fleet'; | ||
| import { CONFIRM_MODAL } from '../screens/navigation'; | ||
|
|
||
| import { API_VERSIONS } from '../../common'; | ||
| import { cleanupAgentPolicies } from '../tasks/cleanup'; | ||
| import { login } from '../tasks/login'; | ||
| import { request } from '../tasks/common'; | ||
|
|
||
| const INPUT_TEST_PACKAGE = 'input_package-1.0.0'; | ||
|
|
||
| describe('Input package with custom data stream type', () => { | ||
| beforeEach(() => { | ||
| login(); | ||
| }); | ||
|
|
||
| const agentPolicyId = 'test-input-package-policy'; | ||
| const agentPolicyName = 'Test input package policy'; | ||
| const packagePolicyName = 'input-package-policy'; | ||
| const datasetName = 'logs'; // Default from the package. | ||
| const dataStreamType = 'metrics'; | ||
|
|
||
| before(() => { | ||
| cy.task('installTestPackage', INPUT_TEST_PACKAGE); | ||
|
|
||
| request({ | ||
| method: 'POST', | ||
| url: `/api/fleet/agent_policies`, | ||
| body: { | ||
| id: agentPolicyId, | ||
| name: agentPolicyName, | ||
| description: 'desc', | ||
| namespace: 'default', | ||
| monitoring_enabled: [], | ||
| }, | ||
| headers: { 'kbn-xsrf': 'cypress', 'Elastic-Api-Version': `${API_VERSIONS.public.v1}` }, | ||
| }); | ||
| }); | ||
|
|
||
| after(() => { | ||
| cleanupAgentPolicies(); | ||
| cy.task('uninstallTestPackage', INPUT_TEST_PACKAGE); | ||
| }); | ||
|
|
||
| it('should successfully create a package policy', () => { | ||
| cy.visit(`/app/integrations/detail/${INPUT_TEST_PACKAGE}/overview`); | ||
| cy.getBySel(ADD_INTEGRATION_POLICY_BTN).click(); | ||
|
|
||
| cy.getBySel(POLICY_EDITOR.POLICY_NAME_INPUT).click().clear().type(packagePolicyName); | ||
| cy.getBySel('multiTextInput-paths') | ||
| .find('[data-test-subj="multiTextInputRow-0"]') | ||
| .click() | ||
| .type('/var/log/test.log'); | ||
|
|
||
| cy.getBySel('multiTextInput-tags') | ||
| .find('[data-test-subj="multiTextInputRow-0"]') | ||
| .click() | ||
| .type('tag1'); | ||
|
|
||
| // Select metrics data stream type. | ||
| cy.get('[data-test-subj^="advancedStreamOptionsToggle"]').click(); | ||
| cy.get('[data-test-subj="packagePolicyDataStreamType"') | ||
| .find(`label[for="${dataStreamType}"]`) | ||
| .click(); | ||
|
|
||
| cy.getBySel(EXISTING_HOSTS_TAB).click(); | ||
|
|
||
| cy.getBySel(POLICY_EDITOR.AGENT_POLICY_SELECT).click(); | ||
| cy.getBySel('agentPolicyMultiItem').each(($el) => { | ||
| if ($el.text() === agentPolicyName) { | ||
| $el.trigger('click'); | ||
| } | ||
| }); | ||
| cy.wait(1000); // wait for policy id to be set | ||
| cy.getBySel(CREATE_PACKAGE_POLICY_SAVE_BTN).click(); | ||
|
|
||
| cy.getBySel(CONFIRM_MODAL.CANCEL_BUTTON).click(); | ||
| }); | ||
|
|
||
| it(`${dataStreamType} checkbox should be checked`, () => { | ||
| cy.visit(`/app/integrations/detail/${INPUT_TEST_PACKAGE}/policies`); | ||
|
|
||
| cy.getBySel(INTEGRATION_NAME_LINK).contains(packagePolicyName).click(); | ||
|
|
||
| cy.get('button').contains('Change defaults').click(); | ||
| cy.get('[data-test-subj^="advancedStreamOptionsToggle"]').click(); | ||
| cy.get('[data-test-subj="packagePolicyDataStreamType"') | ||
| .find(`input#${dataStreamType}`) | ||
| .should('be.checked'); | ||
| }); | ||
|
|
||
| it('should not allow to edit data stream type', () => { | ||
| cy.visit(`/app/integrations/detail/${INPUT_TEST_PACKAGE}/policies`); | ||
|
|
||
| cy.getBySel(INTEGRATION_NAME_LINK).contains(packagePolicyName).click(); | ||
|
|
||
| cy.get('button').contains('Change defaults').click(); | ||
| cy.get('[data-test-subj^="advancedStreamOptionsToggle"]').click(); | ||
| cy.get('[data-test-subj="packagePolicyDataStreamType"') | ||
| .find('input') | ||
| .should('have.length', 3) | ||
| .each(($el) => cy.wrap($el).should('be.disabled')); | ||
| }); | ||
|
|
||
| it('has an index template', () => { | ||
| cy.visit(`app/management/data/index_management/templates/${dataStreamType}-${datasetName}`); | ||
|
|
||
| // Check that the index pattern appears in the view. | ||
| cy.get('[data-test-subj="templateDetails"').contains(`${dataStreamType}-${datasetName}-*`); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be probably nice to add some kind of E2E or integration test to check that this radio button works and that the expected index template is created after installing the package and adding a policy.
@juliaElastic @nchaulet wdyt? do you have recommendations about where to start adding such a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably could have a cypress test here for that https://github.com/nchaulet/kibana/blob/9ec5275d2f6a8ca0ac3a5a37059d5cb22326fa20/x-pack/platform/plugins/shared/fleet/cypress/e2e/package_policy.cy.ts#L161