[9.0] [Security Solution] Fix inconsistent rule's modified status after applying bulk actions (#214115)#214153
Merged
kibanamachine merged 2 commits intoelastic:9.0from Mar 12, 2025
Conversation
…lying bulk actions (elastic#214115) ## Summary Fixes a problem [`Bulk adding tags to rules marks some rules as customized and doesn't mark other rules as customized. It looks like it depends on the existence of the base version.`](elastic#212761 (review)) discovered while smoke testing after enabling Prebuilt Rules Customization FF. ## Details The problems manifests as some rules have `Modified` badge missing after modifying tags via bulk actions. The root cause is that current bulk actions implementation expects unmodified rule's data in `paramsModifier()` callback. But Alerting Framework's Rules Client invokes `paramsModifier()` providing already modified rule. Alerting Framework managed fields like `rule.tags` have modified values. The fix makes sure rule customizartion state is calculated by using unmodified rule data. ## Screenshots Before: https://github.com/user-attachments/assets/eeb65b18-c51f-4c5e-b0e6-6552e442994e After: https://github.com/user-attachments/assets/d18d8765-4f40-4513-95a1-2cd84ac2a0a9 (cherry picked from commit 6b87869)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
⏳ Build in-progress, with failures
Failed CI Steps
Historycc @maximpn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation