[8.17] [Lens] fix drag and drop ghost after Chrome update to 134 (#213928)#214124
Merged
kibanamachine merged 3 commits intoelastic:8.17from Mar 22, 2025
Merged
[8.17] [Lens] fix drag and drop ghost after Chrome update to 134 (#213928)#214124kibanamachine merged 3 commits intoelastic:8.17from
kibanamachine merged 3 commits intoelastic:8.17from
Conversation
…3928) ## Summary Fixes elastic#213708 Fixes the ghost display. As @nickofthyme pointed out [here](elastic#213708 (comment)), the reason was using inset-inline-start: -10000px for the keyboard handler that is one of the children of the draggable component. The quick fix is to just move it outside of the html element that is dragged. @markov00 please assesswhere it should be merged 🙏🏼 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 84ae9c9)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Historycc @mbondyra |
## Summary Fixes elastic#213324 For some reason this PR elastic#213928 didn't catch that the changes make the test fail. This PR fixes it. After this, we'll be able to backport the original PR. (The pattern of using `data-attr-field` is already used in Discover so I think it's a good opportunity to align) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation