[Security Solution] Adds check for license level for rule editing callout message#213995
Merged
banderror merged 1 commit intoelastic:mainfrom Mar 12, 2025
Merged
Conversation
dplumlee
added
bug
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @dplumlee |
maximpn
approved these changes
Mar 12, 2025
Contributor
maximpn
left a comment
maximpn
left a comment
There was a problem hiding this comment.
Tested the PR locally. I can confirm the callout isn't shown on rule's editing page with insufficient license.
dhurley14
approved these changes
Mar 12, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13814649402 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
…lout message (elastic#213995) ## Summary Resolves elastic#213983 Adds gating logic to only display the rule upgrade related warning callout on the rule editing page if the user has the appropriate license level, otherwise the message is irrelevant as the user wouldn't be able to edit a prebuilt rule in the way the message refers to ### Testing **Steps to reproduce:** 1. Use a Platinum license or any tier that does not allow prebuilt rule updates. 2. Navigate to the Rule Management page and select a prebuilt rule with an available update. 3. Open Rule Details page -> Edit rule settings 4. Observe the callout message is not displayed at the top of the page NOTE: When using the enterprise license, the callout should still be displayed (cherry picked from commit 0485578)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
…lout message (elastic#213995) ## Summary Resolves elastic#213983 Adds gating logic to only display the rule upgrade related warning callout on the rule editing page if the user has the appropriate license level, otherwise the message is irrelevant as the user wouldn't be able to edit a prebuilt rule in the way the message refers to ### Testing **Steps to reproduce:** 1. Use a Platinum license or any tier that does not allow prebuilt rule updates. 2. Navigate to the Rule Management page and select a prebuilt rule with an available update. 3. Open Rule Details page -> Edit rule settings 4. Observe the callout message is not displayed at the top of the page NOTE: When using the enterprise license, the callout should still be displayed (cherry picked from commit 0485578)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
…lout message (elastic#213995) ## Summary Resolves elastic#213983 Adds gating logic to only display the rule upgrade related warning callout on the rule editing page if the user has the appropriate license level, otherwise the message is irrelevant as the user wouldn't be able to edit a prebuilt rule in the way the message refers to ### Testing **Steps to reproduce:** 1. Use a Platinum license or any tier that does not allow prebuilt rule updates. 2. Navigate to the Rule Management page and select a prebuilt rule with an available update. 3. Open Rule Details page -> Edit rule settings 4. Observe the callout message is not displayed at the top of the page NOTE: When using the enterprise license, the callout should still be displayed (cherry picked from commit 0485578)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
…ng callout message (#213995) (#214199) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Adds check for license level for rule editing callout message (#213995)](#213995) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T15:03:38Z","message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds check for license level for rule editing callout message","number":213995,"url":"https://github.com/elastic/kibana/pull/213995","mergeCommit":{"message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213995","number":213995,"mergeCommit":{"message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
…ng callout message (#213995) (#214198) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds check for license level for rule editing callout message (#213995)](#213995) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T15:03:38Z","message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds check for license level for rule editing callout message","number":213995,"url":"https://github.com/elastic/kibana/pull/213995","mergeCommit":{"message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213995","number":213995,"mergeCommit":{"message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
…ing callout message (#213995) (#214197) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Adds check for license level for rule editing callout message (#213995)](#213995) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T15:03:38Z","message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds check for license level for rule editing callout message","number":213995,"url":"https://github.com/elastic/kibana/pull/213995","mergeCommit":{"message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213995","number":213995,"mergeCommit":{"message":"[Security Solution] Adds check for license level for rule editing callout message (#213995)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/213983\n\nAdds gating logic to only display the rule upgrade related warning\ncallout on the rule editing page if the user has the appropriate license\nlevel, otherwise the message is irrelevant as the user wouldn't be able\nto edit a prebuilt rule in the way the message refers to\n\n### Testing\n\n**Steps to reproduce:**\n\n1. Use a Platinum license or any tier that does not allow prebuilt rule\nupdates.\n2. Navigate to the Rule Management page and select a prebuilt rule with\nan available update.\n3. Open Rule Details page -> Edit rule settings\n4. Observe the callout message is not displayed at the top of the page\n\nNOTE: When using the enterprise license, the callout should still be\ndisplayed","sha":"0485578022006a183c5d0db1dd3a404ba2bff015"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…lout message (elastic#213995) ## Summary Resolves elastic#213983 Adds gating logic to only display the rule upgrade related warning callout on the rule editing page if the user has the appropriate license level, otherwise the message is irrelevant as the user wouldn't be able to edit a prebuilt rule in the way the message refers to ### Testing **Steps to reproduce:** 1. Use a Platinum license or any tier that does not allow prebuilt rule updates. 2. Navigate to the Rule Management page and select a prebuilt rule with an available update. 3. Open Rule Details page -> Edit rule settings 4. Observe the callout message is not displayed at the top of the page NOTE: When using the enterprise license, the callout should still be displayed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #213983
Adds gating logic to only display the rule upgrade related warning callout on the rule editing page if the user has the appropriate license level, otherwise the message is irrelevant as the user wouldn't be able to edit a prebuilt rule in the way the message refers to
Testing
Steps to reproduce:
NOTE: When using the enterprise license, the callout should still be displayed