Skip to content

[Performance] Refactor TTFMP query from, to fields #213911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awahab07 merged 6 commits into from
Mar 20, 2025
Merged

[Performance] Refactor TTFMP query from, to fields #213911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b93ea40
Refactor TTFMP query `from`, `to` fields.
awahab07 Mar 11, 2025
41f7fbc
Merge remote-tracking branch 'origin/main' into observability-dev-429…
awahab07 Mar 13, 2025
9e863ed
Merge remote-tracking branch 'origin/main' into observability-dev-429…
awahab07 Mar 13, 2025
ce38ced
Merge remote-tracking branch 'origin/main' into observability-dev-429…
awahab07 Mar 18, 2025
6d51cfc
merge elastic/main into current branch
awahab07 Mar 19, 2025
1ab6700
Merge remote-tracking branch 'origin/main' into observability-dev-429…
awahab07 Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dev_docs/tutorials/performance/adding_custom_performance_metrics.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,9 @@ This will be indexed as:
"duration": 736, // Event duration as specified when reporting it
"meta": {
"target": '/home',
"query_range_secs": 900
"query_offset_secs": 0 // now
"query_range_secs": 900, // 15 minutes
"query_from_offset_secs": -900 // From 15 minutes ago
"query_to_offset_secs": 0 // To now
},
"context": { // Context holds information identifying the deployment, version, application and page that generated the event
"version": "8.16.0-SNAPSHOT",
Expand Down
22 changes: 16 additions & 6 deletions src/core/packages/analytics/browser-internal/src/track_performance_measure_entries.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ describe('trackPerformanceMeasureEntries', () => {
meta: {
isInitialLoad: true,
queryRangeSecs: 86400,
queryOffsetSecs: 0,
queryFromOffsetSecs: -86400,
queryToOffsetSecs: 0,
},
},
},
Expand All @@ -129,7 +130,12 @@ describe('trackPerformanceMeasureEntries', () => {
duration: 1000,
eventName: 'kibana:plugin_render_time',
key1: 'key1',
meta: { is_initial_load: true, query_range_secs: 86400, query_offset_secs: 0 },
meta: {
is_initial_load: true,
query_range_secs: 86400,
query_from_offset_secs: -86400,
query_to_offset_secs: 0,
},
value1: 'value1',
});
});
Expand All @@ -146,7 +152,8 @@ describe('trackPerformanceMeasureEntries', () => {
type: 'kibana:performance',
meta: {
queryRangeSecs: 86400,
queryOffsetSecs: 0,
queryFromOffsetSecs: -86400,
queryToOffsetSecs: 0,
},
},
},
Expand All @@ -159,7 +166,8 @@ describe('trackPerformanceMeasureEntries', () => {
eventName: 'kibana:plugin_render_time',
meta: {
query_range_secs: 86400,
query_offset_secs: 0,
query_from_offset_secs: -86400,
query_to_offset_secs: 0,
},
});
});
Expand Down Expand Up @@ -191,7 +199,8 @@ describe('trackPerformanceMeasureEntries', () => {
meta: {
is_initial_load: false,
query_range_secs: undefined,
query_offset_secs: undefined,
query_from_offset_secs: undefined,
query_to_offset_secs: undefined,
description:
'[ttfmp_dependencies] onPageReady is called when the most important content is rendered',
},
Expand Down Expand Up @@ -227,7 +236,8 @@ describe('trackPerformanceMeasureEntries', () => {
meta: {
is_initial_load: false,
query_range_secs: undefined,
query_offset_secs: undefined,
query_from_offset_secs: undefined,
query_to_offset_secs: undefined,
description: truncatedDescription,
},
});
Expand Down
3 changes: 2 additions & 1 deletion src/core/packages/analytics/browser-internal/src/track_performance_measure_entries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ export function trackPerformanceMeasureEntries(analytics: AnalyticsClient, isDev
...customMetrics,
meta: {
query_range_secs: meta?.queryRangeSecs,
query_offset_secs: meta?.queryOffsetSecs,
query_from_offset_secs: meta?.queryFromOffsetSecs,
query_to_offset_secs: meta?.queryToOffsetSecs,
description: description?.slice(0, MAX_DESCRIPTION_LENGTH),
is_initial_load: meta?.isInitialLoad,
},
Expand Down
7 changes: 5 additions & 2 deletions ...ackages/shared/kbn-ebt-tools/src/performance_metrics/context/measure_interaction/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import { DescriptionWithPrefix } from '../types';

interface PerformanceMeta {
queryRangeSecs?: number;
queryOffsetSecs?: number;
queryFromOffsetSecs?: number;
queryToOffsetSecs?: number;
isInitialLoad?: boolean;
description?: DescriptionWithPrefix;
}
Expand Down Expand Up @@ -46,7 +47,9 @@ export function measureInteraction(pathname: string) {
});

performanceMeta.queryRangeSecs = getTimeDifferenceInSeconds(dateRangesInEpoch);
performanceMeta.queryOffsetSecs =
performanceMeta.queryFromOffsetSecs =
rangeFrom === 'now' ? 0 : getOffsetFromNowInSeconds(dateRangesInEpoch.startDate);
performanceMeta.queryToOffsetSecs =
rangeTo === 'now' ? 0 : getOffsetFromNowInSeconds(dateRangesInEpoch.endDate);
}

Expand Down
15 changes: 10 additions & 5 deletions ...bt-tools/src/performance_metrics/context/measure_interaction/measure_interaction.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ describe('measureInteraction', () => {
customMetrics: eventData.customMetrics,
meta: {
queryRangeSecs: 900,
queryOffsetSecs: 0,
queryFromOffsetSecs: -900,
queryToOffsetSecs: 0,
isInitialLoad: true,
},
},
Expand Down Expand Up @@ -102,7 +103,8 @@ describe('measureInteraction', () => {
customMetrics: undefined,
meta: {
queryRangeSecs: 1800,
queryOffsetSecs: 0,
queryFromOffsetSecs: -1800,
queryToOffsetSecs: 0,
isInitialLoad: true,
},
},
Expand Down Expand Up @@ -130,7 +132,8 @@ describe('measureInteraction', () => {
customMetrics: undefined,
meta: {
queryRangeSecs: 86400,
queryOffsetSecs: -1800,
queryFromOffsetSecs: -88200,
queryToOffsetSecs: -1800,
isInitialLoad: true,
},
},
Expand Down Expand Up @@ -159,7 +162,8 @@ describe('measureInteraction', () => {
customMetrics: undefined,
meta: {
queryRangeSecs: 86400,
queryOffsetSecs: 1800,
queryFromOffsetSecs: -84600,
queryToOffsetSecs: 1800,
isInitialLoad: true,
},
},
Expand Down Expand Up @@ -198,7 +202,8 @@ describe('measureInteraction', () => {
customMetrics: undefined,
meta: {
queryRangeSecs: 86400,
queryOffsetSecs: 1800,
queryFromOffsetSecs: -84600,
queryToOffsetSecs: 1800,
isInitialLoad: false,
},
},
Expand Down