[Logs UI] Make logs ui categories page tests more robust#213834
Merged
weltenwort merged 3 commits intoelastic:mainfrom Mar 12, 2025
Merged
[Logs UI] Make logs ui categories page tests more robust#213834weltenwort merged 3 commits intoelastic:mainfrom
weltenwort merged 3 commits intoelastic:mainfrom
Conversation
weltenwort
added
Feature:Logs UI
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
awahab07
reviewed
Mar 11, 2025
| async () => { | ||
| await logsUi.logEntryCategoriesPage.navigateTo(); | ||
|
|
||
| await retry.try(async () => { |
Contributor
There was a problem hiding this comment.
Will the outer tryWithRetries outlive the inner try in terms of timeout?
Member
Author
There was a problem hiding this comment.
Good catch, thank you. The timeout needs to be higher, of course. 🤦
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @weltenwort |
Contributor
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13816112098 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
) (cherry picked from commit 3338092)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
) (cherry picked from commit 3338092)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
) (cherry picked from commit 3338092)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
) (cherry picked from commit 3338092)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
) (cherry picked from commit 3338092)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
…) (#214223) # Backport This will backport the following commits from `main` to `9.0`: - [[Logs UI] Make logs ui categories page tests more robust (#213834)](#213834) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"weltenwort@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T16:08:11Z","message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Logs UI","release_note:skip","backport:all-open","Team:obs-ux-logs","v9.1.0"],"title":"[Logs UI] Make logs ui categories page tests more robust","number":213834,"url":"https://github.com/elastic/kibana/pull/213834","mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213834","number":213834,"mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}}]}] BACKPORT--> Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
) (#214221) # Backport This will backport the following commits from `main` to `8.18`: - [[Logs UI] Make logs ui categories page tests more robust (#213834)](#213834) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"weltenwort@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T16:08:11Z","message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Logs UI","release_note:skip","backport:all-open","Team:obs-ux-logs","v9.1.0"],"title":"[Logs UI] Make logs ui categories page tests more robust","number":213834,"url":"https://github.com/elastic/kibana/pull/213834","mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213834","number":213834,"mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}}]}] BACKPORT--> Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
…) (#214222) # Backport This will backport the following commits from `main` to `8.x`: - [[Logs UI] Make logs ui categories page tests more robust (#213834)](#213834) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"weltenwort@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T16:08:11Z","message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Logs UI","release_note:skip","backport:all-open","Team:obs-ux-logs","v9.1.0"],"title":"[Logs UI] Make logs ui categories page tests more robust","number":213834,"url":"https://github.com/elastic/kibana/pull/213834","mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213834","number":213834,"mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}}]}] BACKPORT--> Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
) (#214218) # Backport This will backport the following commits from `main` to `8.16`: - [[Logs UI] Make logs ui categories page tests more robust (#213834)](#213834) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"weltenwort@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T16:08:11Z","message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Logs UI","release_note:skip","backport:all-open","Team:obs-ux-logs","v9.1.0"],"title":"[Logs UI] Make logs ui categories page tests more robust","number":213834,"url":"https://github.com/elastic/kibana/pull/213834","mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213834","number":213834,"mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}}]}] BACKPORT--> Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
) (#214220) # Backport This will backport the following commits from `main` to `8.17`: - [[Logs UI] Make logs ui categories page tests more robust (#213834)](#213834) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"weltenwort@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T16:08:11Z","message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Logs UI","release_note:skip","backport:all-open","Team:obs-ux-logs","v9.1.0"],"title":"[Logs UI] Make logs ui categories page tests more robust","number":213834,"url":"https://github.com/elastic/kibana/pull/213834","mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213834","number":213834,"mergeCommit":{"message":"[Logs UI] Make logs ui categories page tests more robust (#213834)","sha":"3338092efcc707ef7fa80c0ef34d1b23d257193e"}}]}] BACKPORT--> Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is another attempt at fixing the very spurious functional test failures for the log categorization page. The fix retries the navigation once, because the hypothesis is that the deletion of the indices is delayed and the navigation might be too quick for it sometimes.
closes #196031