only transform legend if present#213814
Merged
TinaHeiligers merged 2 commits intoelastic:mainfrom Mar 10, 2025
Merged
Conversation
TinaHeiligers
added
release_note:skip
1 task
bryce-b
approved these changes
Mar 10, 2025
Contributor
💚 Build Succeeded
Metrics [docs]
|
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13775663768 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
The inventory_view saved object allows the legend attribute to be optional and limits and/or sets the number of steps during an upgrade between model version 1 and 2. The transform function needs to handle cases where legend is not set to prevent migration failures. Related to elastic#207007 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 85baab2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
The inventory_view saved object allows the legend attribute to be optional and limits and/or sets the number of steps during an upgrade between model version 1 and 2. The transform function needs to handle cases where legend is not set to prevent migration failures. Related to elastic#207007 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 85baab2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
The inventory_view saved object allows the legend attribute to be optional and limits and/or sets the number of steps during an upgrade between model version 1 and 2. The transform function needs to handle cases where legend is not set to prevent migration failures. Related to elastic#207007 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 85baab2)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [only transform legend if present (#213814)](#213814) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T22:03:56Z","message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"only transform legend if present","number":213814,"url":"https://github.com/elastic/kibana/pull/213814","mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213814","number":213814,"mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [only transform legend if present (#213814)](#213814) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T22:03:56Z","message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"only transform legend if present","number":213814,"url":"https://github.com/elastic/kibana/pull/213814","mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213814","number":213814,"mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [only transform legend if present (#213814)](#213814) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T22:03:56Z","message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"only transform legend if present","number":213814,"url":"https://github.com/elastic/kibana/pull/213814","mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213814","number":213814,"mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
TinaHeiligers
added
backport:8.17
v8.17.0
backport:version
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13841096132 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2025
The inventory_view saved object allows the legend attribute to be optional and limits and/or sets the number of steps during an upgrade between model version 1 and 2. The transform function needs to handle cases where legend is not set to prevent migration failures. Related to elastic#207007 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 85baab2)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
# Backport This will backport the following commits from `main` to `8.17`: - [only transform legend if present (#213814)](#213814) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T22:03:56Z","message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0","backport:8.17","v9.1.0","v8.19.0"],"title":"only transform legend if present","number":213814,"url":"https://github.com/elastic/kibana/pull/213814","mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213840","number":213840,"state":"MERGED","mergeCommit":{"sha":"755e23ac6765e64ce9f68ccfdad5ef4eb394467f","message":"[9.0] only transform legend if present (#213814) (#213840)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [only transform legend if present\n(#213814)](https://github.com/elastic/kibana/pull/213814)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213838","number":213838,"state":"MERGED","mergeCommit":{"sha":"fb7e387a319929eeeafc8b394355c76aad168329","message":"[8.18] only transform legend if present (#213814) (#213838)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.18`:\n- [only transform legend if present\n(#213814)](https://github.com/elastic/kibana/pull/213814)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213814","number":213814,"mergeCommit":{"message":"only transform legend if present (#213814)\n\nThe inventory_view saved object allows the legend attribute to be\noptional and limits and/or sets the number of steps during an upgrade\nbetween model version 1 and 2. The transform function needs to handle\ncases where legend is not set to prevent migration failures.\n\nRelated to https://github.com/elastic/kibana/pull/207007\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"85baab2431bea918a68d752ec912b792ee93e00f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213839","number":213839,"state":"MERGED","mergeCommit":{"sha":"d7675f0b32ecfca0a01b10a9779ae492f1e652db","message":"[8.x] only transform legend if present (#213814) (#213839)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [only transform legend if present\n(#213814)](https://github.com/elastic/kibana/pull/213814)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>"}}]}] BACKPORT--> Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
The inventory_view saved object allows the legend attribute to be optional and limits and/or sets the number of steps during an upgrade between model version 1 and 2. The transform function needs to handle cases where legend is not set to prevent migration failures. Related to elastic#207007 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
|
Hi @CAWilson94 , is the fix available on ECH 8.17.4 that is released today ? |
rudolf
added
the
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
rudolf
added
the
bug
|
Hi @CAWilson94 @rudolf @bryce-b , is the fix available on ECH 8.17.4 that was released yesterday ? |
Contributor
|
Yes, this fix was included in 8.17.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inventory_view saved object allows the legend attribute to be optional and limits and/or sets the number of steps during an upgrade between model version 1 and 2. The transform function needs to handle cases where legend is not set to prevent migration failures.
Related to #207007